From owner-freebsd-ports@freebsd.org Thu Sep 8 22:29:18 2016 Return-Path: Delivered-To: freebsd-ports@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id 1FCABBD16A0 for ; Thu, 8 Sep 2016 22:29:18 +0000 (UTC) (envelope-from amaniatis@apache.org) Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by mx1.freebsd.org (Postfix) with SMTP id 04BDBD8B for ; Thu, 8 Sep 2016 22:29:17 +0000 (UTC) (envelope-from amaniatis@apache.org) Received: (qmail 97693 invoked by uid 99); 8 Sep 2016 22:29:16 -0000 Received: from mail-relay.apache.org (HELO mail-relay.apache.org) (140.211.11.15) by apache.org (qpsmtpd/0.29) with ESMTP; Thu, 08 Sep 2016 22:29:16 +0000 Received: from Aristedess-MacBook-Pro.local (ppp59-167-140-203.static.internode.on.net [59.167.140.203]) by mail-relay.apache.org (ASF Mail Server at mail-relay.apache.org) with ESMTPSA id E09FC1A018B; Thu, 8 Sep 2016 22:29:15 +0000 (UTC) Subject: Re: ${INSTALL_DATA} problems To: Mathieu Arnold , Aristedes Maniatis , FreeBSD Mailing List References: From: Aristedes Maniatis Message-ID: <3f536359-c17a-d226-7ddc-7264b5af7c97@apache.org> Date: Fri, 9 Sep 2016 08:29:12 +1000 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.11; rv:49.0) Gecko/20100101 Thunderbird/49.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-BeenThere: freebsd-ports@freebsd.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: Porting software to FreeBSD List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 08 Sep 2016 22:29:18 -0000 Thanks Mathieu On 8/09/2016 10:47pm, Mathieu Arnold wrote: > Like Matthew said, INSTALL_DATA is for installing one file, not a > directory hierarchy, this is done using COPYTREE_SHARE. As a side not, > we never use CP -R to install files. I'm trying to do my best to follow the rules, but the rules are very hard to find. For example if the docs mentioned the one file thing for INSTALL_DATA that would be helpful. Or if the error message was clear... I also don't understand the need for a recursive COPYTREE_SHARE which I believe requires a "cd" first, and a non-recursive INSTALL_*. Maybe the Makefile language will become clearer to me one day, but I've been using FreeBSD since 4.0 and it hasn't clicked yet. > Now, I'm seeing something else that is a bad idea, it is using the -o > flag. Ports must build as a regular user. A regular user will not be > able to change the owner of the files. Then why does INSTALL_DATA have an -o flag at all? I copied this idea from another port I found. > This must be done in the > pkg-plist file, using @owner/@group as described in the Porter's > Handbook: > https://www.freebsd.org/doc/en/books/porters-handbook/plist-keywords.html OK, thanks. I appreciate your help and I'll try your suggestions. Ari -- --------------------------> Aristedes Maniatis GPG fingerprint CBFB 84B4 738D 4E87 5E5C 5EFA EF6A 7D2E 3E49 102A