From owner-freebsd-current@FreeBSD.ORG  Sun Sep  7 07:09:21 2008
Return-Path: <owner-freebsd-current@FreeBSD.ORG>
Delivered-To: current@FreeBSD.org
Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34])
	by hub.freebsd.org (Postfix) with ESMTP id C0F741065684;
	Sun,  7 Sep 2008 07:09:21 +0000 (UTC)
	(envelope-from pjd@garage.freebsd.pl)
Received: from mail.garage.freebsd.pl (chello087206045140.chello.pl
	[87.206.45.140])
	by mx1.freebsd.org (Postfix) with ESMTP id 223058FC2E;
	Sun,  7 Sep 2008 07:09:20 +0000 (UTC)
	(envelope-from pjd@garage.freebsd.pl)
Received: by mail.garage.freebsd.pl (Postfix, from userid 65534)
	id 9427745C9B; Sun,  7 Sep 2008 09:09:19 +0200 (CEST)
Received: from localhost (abhr89.neoplus.adsl.tpnet.pl [83.7.107.89])
	(using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits))
	(No client certificate requested)
	by mail.garage.freebsd.pl (Postfix) with ESMTP id 771B745684;
	Sun,  7 Sep 2008 09:09:14 +0200 (CEST)
Date: Sun, 7 Sep 2008 09:09:16 +0200
From: Pawel Jakub Dawidek <pjd@FreeBSD.org>
To: Joe Marcus Clarke <marcus@FreeBSD.org>
Message-ID: <20080907070916.GA2250@garage.freebsd.pl>
References: <1220770049.10898.40.camel@shumai.marcuscom.com>
Mime-Version: 1.0
Content-Type: multipart/signed; micalg=pgp-sha1;
	protocol="application/pgp-signature"; boundary="4Ckj6UjgE2iN1+kY"
Content-Disposition: inline
In-Reply-To: <1220770049.10898.40.camel@shumai.marcuscom.com>
User-Agent: Mutt/1.4.2.3i
X-PGP-Key-URL: http://people.freebsd.org/~pjd/pjd.asc
X-OS: FreeBSD 8.0-CURRENT i386
X-Spam-Checker-Version: SpamAssassin 3.0.4 (2005-06-05) on 
	mail.garage.freebsd.pl
X-Spam-Level: 
X-Spam-Status: No, score=-0.6 required=3.0 tests=BAYES_00,RCVD_IN_SORBS_DUL 
	autolearn=no version=3.0.4
Cc: current <current@FreeBSD.org>
Subject: Re: Crash when loading zfs.ko
X-BeenThere: freebsd-current@freebsd.org
X-Mailman-Version: 2.1.5
Precedence: list
List-Id: Discussions about the use of FreeBSD-current
	<freebsd-current.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-current>, 
	<mailto:freebsd-current-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/freebsd-current>
List-Post: <mailto:freebsd-current@freebsd.org>
List-Help: <mailto:freebsd-current-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-current>,
	<mailto:freebsd-current-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Sun, 07 Sep 2008 07:09:21 -0000


--4Ckj6UjgE2iN1+kY
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable

On Sun, Sep 07, 2008 at 02:47:29AM -0400, Joe Marcus Clarke wrote:
> I'm seeing a very reproducible crash when the ZFS kernel module is
> loaded with today's -CURRENT.  I think it has to do with an extra
> VOP_UNLOCK() call.  Here is a backtrace:
>=20
> http://www.marcuscom.com/downloads/zfs.jpg
>=20
> And here is my proposed patch to fix it:
>=20
> http://www.marcuscom.com/downloads/zfs_znode.c.diff

Can you try this patch instead?

	http://people.freebsd.org/~pjd/patches/zfs_znode.c.patch

--=20
Pawel Jakub Dawidek                       http://www.wheel.pl
pjd@FreeBSD.org                           http://www.FreeBSD.org
FreeBSD committer                         Am I Evil? Yes, I Am!

--4Ckj6UjgE2iN1+kY
Content-Type: application/pgp-signature
Content-Disposition: inline

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v2.0.4 (FreeBSD)

iD8DBQFIw34bForvXbEpPzQRAqU/AJ9G9Q4Rj6mFURozFEDYS0kNVDt5gwCg1DHR
XlxEsSeNyH6cHS6t70AR2NE=
=58Nk
-----END PGP SIGNATURE-----

--4Ckj6UjgE2iN1+kY--