From owner-svn-src-all@freebsd.org Fri May 27 06:35:16 2016 Return-Path: Delivered-To: svn-src-all@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id BD5CEB4CCE1 for ; Fri, 27 May 2016 06:35:16 +0000 (UTC) (envelope-from ed@nuxi.nl) Received: from mail-yw0-x22a.google.com (mail-yw0-x22a.google.com [IPv6:2607:f8b0:4002:c05::22a]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (Client CN "smtp.gmail.com", Issuer "Google Internet Authority G2" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 7F5E61C37 for ; Fri, 27 May 2016 06:35:16 +0000 (UTC) (envelope-from ed@nuxi.nl) Received: by mail-yw0-x22a.google.com with SMTP id o16so97891524ywd.2 for ; Thu, 26 May 2016 23:35:16 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=nuxi-nl.20150623.gappssmtp.com; s=20150623; h=mime-version:in-reply-to:references:date:message-id:subject:from:to :cc; bh=3s97E49Ct5adPxV70H1r8X2bpeBXuDxbnDHLmGT1oOI=; b=LPxoo3dNDO52Oc75Xid6JrmhHE25FQlQqLri4v7djYnxBHesT1Wurs/LBtEgWX1IlL 0LmsqNxeYaYkmFSsLl1RR9/gK2fghVKYQP+siBcjzCbTtAFccRp1Fkv5o+bfZyrIrCIj v89WfvdRZqp9ISq+5+abPv3ru2+ag9CHrXmk5hzwwspzct9RRpaA9T9vK7sxulPt4hSX Q8OmFnVXn1gP8BBRH9KlAARMM1CEWc9IsUElMyC/BFK1ggC2Zwa/UgEWczVxXd27y9fp aiR6xfyt42ox0zx4M/HgeVR7h96nuzj/6uKvHrpNbRwfWEsf7uz5Au1uyO9T5ZDRgXy7 0uuA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:mime-version:in-reply-to:references:date :message-id:subject:from:to:cc; bh=3s97E49Ct5adPxV70H1r8X2bpeBXuDxbnDHLmGT1oOI=; b=lKYvMGVIWYIQaUCjerDDf7T9YRjObwuhT1bvlbUxymOvG5WHakiI/Hye4WkFLdEqbC E4nm9xtkGL46Q/OQ9wFOfAPOCQS8LqoQaeQU37RoOFBFMIsOWeYedJuhxlfnMH8Dy8FV OwXi5F4sxpCsLZPhk5bgG6QDk42YgI8KTrpfOYwImKpjoPubsgPWb4HKPDJT6pvX+V3s oE/nMy5nBhT35fZSHoQTCzQ3Wj11GNbvupMyEj1ZgtpS3wzNqsvjKSq6uIv1QXFQ79qA HL/c1iLf45hhmOBss1isqyOAfrcMBmKywQnK/B578is41KUOIuyRP6NBGVFRiC0V80kx 6ezw== X-Gm-Message-State: ALyK8tJswRTs3O1N+FvimjqPnxDsuhThlLRgvni+SpM9/WEFIfzcGl7AldHx2hgXilZdTAyl8jrAGa2WpwhYoA== MIME-Version: 1.0 X-Received: by 10.13.202.207 with SMTP id m198mr8322878ywd.140.1464330915507; Thu, 26 May 2016 23:35:15 -0700 (PDT) Received: by 10.13.201.199 with HTTP; Thu, 26 May 2016 23:35:15 -0700 (PDT) In-Reply-To: <201605270531.u4R5VE6R006890@repo.freebsd.org> References: <201605270531.u4R5VE6R006890@repo.freebsd.org> Date: Fri, 27 May 2016 08:35:15 +0200 Message-ID: Subject: Re: svn commit: r300824 - head/lib/libmd From: Ed Schouten To: "Conrad E. Meyer" Cc: src-committers , svn-src-all@freebsd.org, svn-src-head@freebsd.org Content-Type: text/plain; charset=UTF-8 X-BeenThere: svn-src-all@freebsd.org X-Mailman-Version: 2.1.22 Precedence: list List-Id: "SVN commit messages for the entire src tree \(except for " user" and " projects" \)" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 27 May 2016 06:35:16 -0000 Hi Conrad, 2016-05-27 7:31 GMT+02:00 Conrad E. Meyer : > libmd: Work around C++'s inability to understand C So C++ doesn't support using 'static' within array types, right? What I personally dislike about this specific change: - Including directly still doesn't work. - If is ever going to include a 'static inline' function, the static keyword would also be stripped off. Would it make sense to come up with a macro in to deal with this? #if defined(__cplusplus) || defined(ancient compiler) #define __minimum_size(n) n #else #define __minimum_size(n) static (n) #endif That way we can annotate this everwhere we'd want, without needing to care about compiler versions, languages, etc. -- Ed Schouten Nuxi, 's-Hertogenbosch, the Netherlands KvK-nr.: 62051717