From owner-cvs-all Sun Jan 7 7: 3: 8 2001 Delivered-To: cvs-all@freebsd.org Received: from harmony.village.org (rover.village.org [204.144.255.66]) by hub.freebsd.org (Postfix) with ESMTP id 12DC137B6A4; Sun, 7 Jan 2001 07:01:09 -0800 (PST) Received: from harmony.village.org (localhost.village.org [127.0.0.1]) by harmony.village.org (8.11.1/8.11.1) with ESMTP id f07F13s06277; Sun, 7 Jan 2001 08:01:04 -0700 (MST) (envelope-from imp@harmony.village.org) Message-Id: <200101071501.f07F13s06277@harmony.village.org> To: Peter Wemm Subject: Re: cvs commit: src/sys/dev/pccard card_if.m pccard.c src/sys/dev/pccbb pccbb.c Cc: cvs-committers@FreeBSD.org, cvs-all@FreeBSD.org In-reply-to: Your message of "Sun, 07 Jan 2001 05:33:46 PST." <200101071333.f07DXlt11106@mobile.wemm.org> References: <200101071333.f07DXlt11106@mobile.wemm.org> Date: Sun, 07 Jan 2001 08:01:03 -0700 From: Warner Losh Sender: owner-cvs-all@FreeBSD.ORG Precedence: bulk X-Loop: FreeBSD.ORG In message <200101071333.f07DXlt11106@mobile.wemm.org> Peter Wemm writes: : For what it is worth, this is all that would have been required to get : ray and oldcard to work without breaking newcard: : + if (offsetp) : + *offsetp = offset; Except that the NEWCARD stuff doesn't check offsetp not being null and always uses it. Also, the *offsetp parameter isn't what it sets the offset (in cardspace) to, but rather the delta from the requested value to the actual value. Since that was hard to do, I punted back on level and backed out the interface change. And there were a couple of other spots that you must have missed because sys/pccard/pccard.c also has the function in question, which means we'd hit stack garbage. I didn't want to break OLDCARD, even for a short while, which is why I went ahead and committed the back out. It seemed the easiest thing to do. I'm sorry that I broke NEWCARD in the process. If you'll send me some patches to try, I'll test both oldcard and newcard here (I have a ray card to test) and commit the change. Warner To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe cvs-all" in the body of the message