Skip site navigation (1)Skip section navigation (2)
Date:      Sun, 12 Feb 2006 10:02:15 -0800
From:      =?UTF-8?Q?Vadim_Kurland_=E2=9C=8D?= <vadim@fwbuilder.org>
To:        Sam Lawrance <lawrance@FreeBSD.org>
Cc:        freebsd-ports-bugs@FreeBSD.org
Subject:   Re: ports/93225: [patch] [maintainer update] Update port security/fwbuilder
Message-ID:  <9D2D11E1-AEAE-492B-B9FF-8CE4087B590D@fwbuilder.org>
In-Reply-To: <200602121252.k1CCqoHW075667@freefall.freebsd.org>
References:  <200602121252.k1CCqoHW075667@freefall.freebsd.org>

next in thread | previous in thread | raw e-mail | index | archive | help

--Apple-Mail-3-398862422
Content-Transfer-Encoding: 7bit
Content-Type: text/plain;
	charset=US-ASCII;
	delsp=yes;
	format=flowed


the MD5 has changed because all the files were autogenerated as part  
of automatic build. You are right, there is no need to change the  
source tar.gz and hence MD5 in the distfile should not change either.  
I've fixed that, and returned PORTREVISION back to 1. New diff is  
attached.

thanks
--vk

--Apple-Mail-3-398862422
Content-Transfer-Encoding: 7bit
Content-Type: application/octet-stream; x-unix-mode=0644;
	name="fwbuilder-port.diff"
Content-Disposition: attachment;
	filename=fwbuilder-port.diff

diff -urN fwbuilder-current/Makefile fwbuilder/Makefile
--- fwbuilder-current/Makefile	Sun Nov 27 22:33:06 2005
+++ fwbuilder/Makefile	Sat Feb 11 19:19:56 2006
@@ -7,6 +7,7 @@
 
 PORTNAME=	fwbuilder
 PORTVERSION=	2.0.10
+PORTREVISION=	1
 CATEGORIES=	security
 MASTER_SITES=	${MASTER_SITE_SOURCEFORGE}
 MASTER_SITE_SUBDIR=	fwbuilder
@@ -17,15 +18,12 @@
 BUILD_DEPENDS=	qmake:${PORTSDIR}/devel/qmake
 LIB_DEPENDS=	fwbuilder.6:${PORTSDIR}/security/libfwbuilder
 
-.if !exists(/usr/include/getopt.h)
-USE_GETOPT_LONG=	yes
-.endif
-
 USE_QT_VER=	3
 
 QTDIR?=		${X11BASE}
 
 USE_OPENSSL=	yes
+USE_GETOPT_LONG=	yes
 USE_GMAKE=	yes
 GNU_CONFIGURE=	yes
 CONFIGURE_ENV=	CPPFLAGS="-I${LOCALBASE}/include" \

--Apple-Mail-3-398862422
Content-Transfer-Encoding: 7bit
Content-Type: text/plain;
	charset=US-ASCII;
	delsp=yes;
	format=flowed


On Feb 12, 2006, at 12:52 PM, Sam Lawrance wrote:

> Synopsis: [patch] [maintainer update] Update port security/fwbuilder
>
> State-Changed-From-To: open->feedback
> State-Changed-By: lawrance
> State-Changed-When: Sun Feb 12 12:46:26 UTC 2006
> State-Changed-Why:
> Your patch removes the SHA256 checksum and replaces the MD5 checksum
> in distinfo.  Please send an updated patch with SHA256 as well.
>
> Why did the MD5 checksum change?  If the distfile was changed please
> compare the old and new distfiles and summarise the changes so we can
> be sure nothing nasty has been inserted.
>
> Do these changes affect the function or contents of the built package?
> If it is just a build fix for 4.x, there is no need to bump  
> PORTREVISION.
>
>
>
> Responsible-Changed-From-To: freebsd-ports-bugs->lawrance
> Responsible-Changed-By: lawrance
> Responsible-Changed-When: Sun Feb 12 12:46:26 UTC 2006
> Responsible-Changed-Why:
> Track
>
> http://www.freebsd.org/cgi/query-pr.cgi?pr=93225
>
>
> !DSPAM:43ef2fb8297119086017675!
>


--Apple-Mail-3-398862422--



Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?9D2D11E1-AEAE-492B-B9FF-8CE4087B590D>