From owner-svn-src-head@freebsd.org Fri May 27 22:39:47 2016 Return-Path: Delivered-To: svn-src-head@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id A1DD5B4D799; Fri, 27 May 2016 22:39:47 +0000 (UTC) (envelope-from kostikbel@gmail.com) Received: from kib.kiev.ua (kib.kiev.ua [IPv6:2001:470:d5e7:1::1]) (using TLSv1 with cipher DHE-RSA-CAMELLIA256-SHA (256/256 bits)) (Client did not present a certificate) by mx1.freebsd.org (Postfix) with ESMTPS id 1FC6A1ADB; Fri, 27 May 2016 22:39:46 +0000 (UTC) (envelope-from kostikbel@gmail.com) Received: from tom.home (kib@localhost [127.0.0.1]) by kib.kiev.ua (8.15.2/8.15.2) with ESMTPS id u4RMdgo3018851 (version=TLSv1 cipher=DHE-RSA-CAMELLIA256-SHA bits=256 verify=NO); Sat, 28 May 2016 01:39:42 +0300 (EEST) (envelope-from kostikbel@gmail.com) DKIM-Filter: OpenDKIM Filter v2.10.3 kib.kiev.ua u4RMdgo3018851 Received: (from kostik@localhost) by tom.home (8.15.2/8.15.2/Submit) id u4RMdgqb018850; Sat, 28 May 2016 01:39:42 +0300 (EEST) (envelope-from kostikbel@gmail.com) X-Authentication-Warning: tom.home: kostik set sender to kostikbel@gmail.com using -f Date: Sat, 28 May 2016 01:39:42 +0300 From: Konstantin Belousov To: "Ngie Cooper (yaneurabeya)" Cc: Alan Cox , Ivan Klymenko , Alan Cox , src-committers , svn-src-all@freebsd.org, svn-src-head@freebsd.org Subject: Re: svn commit: r300865 - in head/sys: sys vm Message-ID: <20160527223942.GS38613@kib.kiev.ua> References: <201605271915.u4RJFkEl013139@repo.freebsd.org> <20160527225103.67ae3547@nonamehost.local> <20160527210148.GR38613@kib.kiev.ua> <016BEE0D-05B6-4042-8CD4-471D4D1C9162@gmail.com> <3018B8E4-5E33-49EF-8154-D7D5ECEE8403@gmail.com> <5CAD8DF0-0D56-4EBD-AB93-645B21E3792D@gmail.com> <4318dffc-fef5-2128-74c2-0e97767b36c8@rice.edu> <05E6AFC6-E7B4-45E9-8E5B-C2CDA439D33B@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <05E6AFC6-E7B4-45E9-8E5B-C2CDA439D33B@gmail.com> User-Agent: Mutt/1.6.1 (2016-04-27) X-Spam-Status: No, score=-2.0 required=5.0 tests=ALL_TRUSTED,BAYES_00, DKIM_ADSP_CUSTOM_MED,FREEMAIL_FROM,NML_ADSP_CUSTOM_MED autolearn=no autolearn_force=no version=3.4.1 X-Spam-Checker-Version: SpamAssassin 3.4.1 (2015-04-28) on tom.home X-BeenThere: svn-src-head@freebsd.org X-Mailman-Version: 2.1.22 Precedence: list List-Id: SVN commit messages for the src tree for head/-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 27 May 2016 22:39:47 -0000 On Fri, May 27, 2016 at 03:32:48PM -0700, Ngie Cooper (yaneurabeya) wrote: > > > On May 27, 2016, at 14:26, Alan Cox wrote: > > > > On 05/27/2016 16:22, Ngie Cooper (yaneurabeya) wrote: > >>> On May 27, 2016, at 14:21, Ngie Cooper (yaneurabeya) wrote: > >>>> I added #include to zfs/arc.c in r300870 ??? it was missing from the file. Looking into drm2 and fed. > >>> Oy. Bad test before I did the fix. The issue was libzpool -_- (just saw alc???s comment)??? I???ll fix my commit.. > >> Actually, I???ll just revert my commit and report back about whether or not your patch worked kib. > > > > > > Revert and remove the vm_pageout.h #include from arc.c. > > Confirmed. Reverting r300870 and applying kib???s diff passes buildworld. Please commit the patch. There was Alan' suggestion to remove vm_pageout.h at all. Either way, commit my patch, or preferrably Alan' suggested changes yourself.