Skip site navigation (1)Skip section navigation (2)
Date:      Thu, 6 Aug 2020 13:50:09 +0200
From:      Mateusz Piotrowski <0mp@FreeBSD.org>
To:        =?UTF-8?Q?Danilo_Eg=c3=aaa_Gondolfo?= <danilo@freebsd.org>, Alexey Dokuchaev <danfe@freebsd.org>
Cc:        ports-committers <ports-committers@freebsd.org>, svn-ports-all@freebsd.org, svn-ports-head@freebsd.org
Subject:   Re: svn commit: r544245 - head/x11/sakura
Message-ID:  <c30e03c9-1b8e-294b-c02c-14ada40f5d26@FreeBSD.org>
In-Reply-To: <CAFU7VyOkoJ2yp6Oz88Tfkhts0GzVPDfKXJnyTbfJmmRS0QhcJw@mail.gmail.com>
References:  <202008052155.075LtmtD072730@repo.freebsd.org> <20200806033440.GA53929@FreeBSD.org> <CAFU7VyOkoJ2yp6Oz88Tfkhts0GzVPDfKXJnyTbfJmmRS0QhcJw@mail.gmail.com>

next in thread | previous in thread | raw e-mail | index | archive | help
On 8/6/20 12:46 PM, Danilo EgĂȘa Gondolfo wrote:
> On Thu, Aug 6, 2020 at 4:34 AM Alexey Dokuchaev <danfe@freebsd.org> wrote:
>
>> On Wed, Aug 05, 2020 at 09:55:48PM +0000, Danilo Egea Gondolfo wrote:
>>> New Revision: 544245
>>> URL: https://svnweb.freebsd.org/changeset/ports/544245
>>>
>>> @@ -14,9 +14,10 @@ LICENSE=   GPLv2
>>>   LIB_DEPENDS= libgnutls.so:security/gnutls \
>>>                libpcre2-8.so:devel/pcre2
>>>
>>> +USES=                cmake gnome pkgconfig gettext perl5 tar:bz2 xorg
>>> +
>>>   OPTIONS_DEFINE=      DOCS
>>>
>>> -USES=                cmake gnome pkgconfig gettext perl5 xorg
>>>   USE_GNOME=   cairo gdkpixbuf2 vte3
>> I'd argue that USES was placed better before this change (right next to
>> USE_FOO knobs).  It should've been left where it was and OPTIONS_DEFINE
>> moved downwards instead.
>>
>> ./danfe
>>
> Just tried to make portlint happy on this one ("USES should appear
> earlier").

Please try portfmt and portclippy from ports-mgmt/portfmt. They are much better for order fixes and 
simple style fixes than portlint in most cases.

Cheers,

Mateusz Piotrowski




Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?c30e03c9-1b8e-294b-c02c-14ada40f5d26>