From owner-svn-src-head@freebsd.org Mon Jan 2 22:54:28 2017 Return-Path: Delivered-To: svn-src-head@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id 2B195C9C63D; Mon, 2 Jan 2017 22:54:28 +0000 (UTC) (envelope-from cse.cem@gmail.com) Received: from mail-wm0-f44.google.com (mail-wm0-f44.google.com [74.125.82.44]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (Client CN "smtp.gmail.com", Issuer "Google Internet Authority G2" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id BEEEF1EF0; Mon, 2 Jan 2017 22:54:27 +0000 (UTC) (envelope-from cse.cem@gmail.com) Received: by mail-wm0-f44.google.com with SMTP id k184so220620744wme.1; Mon, 02 Jan 2017 14:54:27 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=Y1qcN5ev+3v0aGkFXnNMogwuB7b48Yg1gun1u8K/rm4=; b=kj3YGLwVo5zs98LF5NEfANrDUN/o7xM3stpZ5k0Gt21rOneLv0ehsmFYUUAxWyxtIs 6wEnHtJBD5+ueWHDuR2sjZEm1j8BsHjNylRQkhPL3F5dy9Ig0dGQyNsxGP3rFduhQje/ pl08PgtH6H/prUk4/fyOmQrQQuYSZMv6v3ouI9LDHBC63EWZCHzxyQdyGe8cbYiV8bXZ W/4OOIaRBkMyqJnhTWdjeUU1WEU4AB9tZh6v4+RJGPL/3lss49irYEwUq4ojrbN2Fi7+ Accf+7nI4K3Xi6KFSd1zRbgf7ucuCTZc2A5hBqu6OkmNCyCJ+SuXyRDr3ixjdV+LJxeT h/uA== X-Gm-Message-State: AIkVDXIQEggkn/vc275GyRD2Az8q/0WMJ/vBrBV0BYrNAFGbo2qJCXypvThCfhS3vH6WPw== X-Received: by 10.28.189.136 with SMTP id n130mr55343938wmf.133.1483397659780; Mon, 02 Jan 2017 14:54:19 -0800 (PST) Received: from mail-wm0-f42.google.com (mail-wm0-f42.google.com. [74.125.82.42]) by smtp.gmail.com with ESMTPSA id e3sm54942589wjm.12.2017.01.02.14.54.19 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Mon, 02 Jan 2017 14:54:19 -0800 (PST) Received: by mail-wm0-f42.google.com with SMTP id k184so220620555wme.1; Mon, 02 Jan 2017 14:54:19 -0800 (PST) X-Received: by 10.28.88.11 with SMTP id m11mr50743150wmb.45.1483397659081; Mon, 02 Jan 2017 14:54:19 -0800 (PST) MIME-Version: 1.0 References: <201701021823.v02INWXc028047@repo.freebsd.org> In-Reply-To: From: Conrad Meyer Date: Mon, 02 Jan 2017 22:54:08 +0000 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: svn commit: r311109 - head/usr.bin/patch To: Pedro Giffuni , cem@freebsd.org Cc: src-committers , svn-src-all@freebsd.org, svn-src-head@freebsd.org Content-Type: text/plain; charset=UTF-8 X-Content-Filtered-By: Mailman/MimeDel 2.1.23 X-BeenThere: svn-src-head@freebsd.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: SVN commit messages for the src tree for head/-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 02 Jan 2017 22:54:28 -0000 I was suggesting using UINT32_MAX/2 on all platforms (which is safe everywhere). Best, Conrad On Mon, Jan 2, 2017 at 11:48 AM Pedro Giffuni wrote: > Hi; > > > > On 01/02/17 13:28, Conrad Meyer wrote: > > > IMO this patch was mostly fine, you just need to restrict line length > > > to UINT32_MAX/2 instead of UINT_MAX (== UINT32_MAX) for 32-bit > > > platforms. > > > > > > Best, > > > Conrad > > > > > > > I dislike the idea of special cases for some platforms. I guess moving > > to int/INT_MAX would be the way to go. > > > > TBH, no one has asked for patches wider than USHRT_MAX though. > > > > Pedro. > >