From owner-cvs-all@FreeBSD.ORG Sat Jun 10 19:43:50 2006 Return-Path: X-Original-To: cvs-all@freebsd.org Delivered-To: cvs-all@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 5640616A47C for ; Sat, 10 Jun 2006 19:43:50 +0000 (UTC) (envelope-from kabaev@gmail.com) Received: from nz-out-0102.google.com (nz-out-0102.google.com [64.233.162.204]) by mx1.FreeBSD.org (Postfix) with ESMTP id BF84C43D72 for ; Sat, 10 Jun 2006 19:43:48 +0000 (GMT) (envelope-from kabaev@gmail.com) Received: by nz-out-0102.google.com with SMTP id 13so947834nzn for ; Sat, 10 Jun 2006 12:43:36 -0700 (PDT) DomainKey-Signature: a=rsa-sha1; q=dns; c=nofws; s=beta; d=gmail.com; h=received:date:from:to:cc:subject:message-id:in-reply-to:references:x-mailer:mime-version:content-type; b=RmiOVj2PiXuRfdI69aEFLiU1uENme5kRv3RrQc0uOH0pQzRMIkH2+4U0KLhab08JwED+W8uHc5PiNVSAI7iTqHswZuC4nb3T3B2jcKJWeCQf65giMrbgO+0JzGeHJlb5j2NoSp2fAMht9RvDReujFlimwKwo2mTmkfB8Tf6blw4= Received: by 10.64.181.19 with SMTP id d19mr3800533qbf; Sat, 10 Jun 2006 12:43:36 -0700 (PDT) Received: from kan.dnsalias.net ( [24.63.93.195]) by mx.gmail.com with ESMTP id f14sm549870qba.2006.06.10.12.43.35; Sat, 10 Jun 2006 12:43:36 -0700 (PDT) Date: Sat, 10 Jun 2006 15:43:31 -0400 From: Alexander Kabaev To: Craig Rodrigues Message-ID: <20060610154331.5ad36dd3@kan.dnsalias.net> In-Reply-To: <200606101904.k5AJ4Lol074220@repoman.freebsd.org> References: <200606101904.k5AJ4Lol074220@repoman.freebsd.org> X-Mailer: Sylpheed-Claws 2.2.0 (GTK+ 2.8.17; i386-portbld-freebsd7.0) Mime-Version: 1.0 Content-Type: multipart/signed; boundary="Sig_QNF3JRESA5/SSbguZQHDEXS"; protocol="application/pgp-signature"; micalg=PGP-SHA1 Cc: cvs-all@FreeBSD.org Subject: Re: cvs commit: src/sys/gnu/fs/xfs/FreeBSD xfs_mountops.c X-BeenThere: cvs-all@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the entire tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sat, 10 Jun 2006 19:43:50 -0000 --Sig_QNF3JRESA5/SSbguZQHDEXS Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: quoted-printable On Sat, 10 Jun 2006 19:04:21 +0000 (UTC) Craig Rodrigues wrote: > rodrigc 2006-06-10 19:04:21 UTC >=20 > FreeBSD src repository >=20 > Modified files: > sys/gnu/fs/xfs/FreeBSD xfs_mountops.c=20 > Log: > Call g_vfs_close() if: > (1) _xfs_mount() fails > (2) at the end of _xfs_unmount() > =20 > Revision Changes Path > 1.6 +36 -3 src/sys/gnu/fs/xfs/FreeBSD/xfs_mountops.c >=20 > http://cvsweb.FreeBSD.org/src/sys/gnu/fs/xfs/FreeBSD/xfs_mountops.c.diff?= r1=3D1.5&r2=3D1.6 This is plain wrong. XFS was responsible in the past for releasing all devices it opened, and that should get fixed if it got broken somehow instead of adding ad-hoc patches to plaster over the real issue. --=20 Alexander Kabaev --Sig_QNF3JRESA5/SSbguZQHDEXS Content-Type: application/pgp-signature; name=signature.asc Content-Disposition: attachment; filename=signature.asc -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.3 (FreeBSD) iD8DBQFEiyDmQ6z1jMm+XZYRAigLAJ9jS1oJoBKWr5Vianpf38s7I/R6pwCg6NEy nEvpeJX0rRhJTVXkh8DQh/c= =eQnq -----END PGP SIGNATURE----- --Sig_QNF3JRESA5/SSbguZQHDEXS--