From owner-freebsd-net@FreeBSD.ORG  Mon Feb  2 19:44:47 2009
Return-Path: <owner-freebsd-net@FreeBSD.ORG>
Delivered-To: freebsd-net@freebsd.org
Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34])
	by hub.freebsd.org (Postfix) with ESMTP id 2AD4910657A3
	for <freebsd-net@freebsd.org>; Mon,  2 Feb 2009 19:44:47 +0000 (UTC)
	(envelope-from jroberson@jroberson.net)
Received: from yx-out-2324.google.com (yx-out-2324.google.com [74.125.44.30])
	by mx1.freebsd.org (Postfix) with ESMTP id DFB1A8FC1C
	for <freebsd-net@freebsd.org>; Mon,  2 Feb 2009 19:44:46 +0000 (UTC)
	(envelope-from jroberson@jroberson.net)
Received: by yx-out-2324.google.com with SMTP id 8so640142yxb.13
	for <freebsd-net@freebsd.org>; Mon, 02 Feb 2009 11:44:46 -0800 (PST)
Received: by 10.64.143.4 with SMTP id q4mr2831354qbd.67.1233603885995;
	Mon, 02 Feb 2009 11:44:45 -0800 (PST)
Received: from ?10.0.1.199? ([72.14.241.159])
	by mx.google.com with ESMTPS id p30sm5502569qbp.17.2009.02.02.11.44.43
	(version=SSLv3 cipher=RC4-MD5); Mon, 02 Feb 2009 11:44:44 -0800 (PST)
Date: Mon, 2 Feb 2009 09:42:57 -1000 (HST)
From: Jeff Roberson <jroberson@jroberson.net>
X-X-Sender: jroberson@desktop
To: Fabian Keil <freebsd-listen@fabiankeil.de>
In-Reply-To: <20090201170550.482bf325@fabiankeil.de>
Message-ID: <20090202094226.E983@desktop>
References: <20090131125100.N983@desktop>
	<20090201160544.4f1961b4@fabiankeil.de>
	<20090201170550.482bf325@fabiankeil.de>
MIME-Version: 1.0
Content-Type: TEXT/PLAIN; charset=US-ASCII; format=flowed
Cc: freebsd-net@freebsd.org
Subject: Re: mbuf revision, testers/comments wanted.
X-BeenThere: freebsd-net@freebsd.org
X-Mailman-Version: 2.1.5
Precedence: list
List-Id: Networking and TCP/IP with FreeBSD <freebsd-net.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-net>,
	<mailto:freebsd-net-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/freebsd-net>
List-Post: <mailto:freebsd-net@freebsd.org>
List-Help: <mailto:freebsd-net-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-net>,
	<mailto:freebsd-net-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Mon, 02 Feb 2009 19:44:48 -0000

On Sun, 1 Feb 2009, Fabian Keil wrote:

> Fabian Keil <freebsd-listen@fabiankeil.de> wrote:
>
>> Jeff Roberson <jroberson@jroberson.net> wrote:
>>
>>> http://people.freebsd.org/~jeff/mbuf_ref2.diff
>>
>>> I have been experimenting with different revisions to the mbuf api to
>>> improve performance and simplify code.  This patch is the first of
>>> several proposed steps towards those goals.  The aim of this patch is
>>> two fold;
>>
>>> I would appreciate testing feedback from varied workloads to make sure
>>> there are no bugs before I go forward with this.  I have tested only
>>> host oriented networking with a few drivers.  It is not anticipated
>>> that there will be any significant incompatibilities introduced with
>>> this round but there is always that possibility.
>
>> 5)
>> Finally, I tested the patch on an IBM ThinPad R51. The kernel
>> hangs on boot, the last messages are (hand transcribed):
>>
>> iwi0: <Intel(R) PRO/Wireless 2200BG> mem 0xc0214000-0xc0214fff irq 11 at device 2.0 on pci2
>> iwi0: Reserved 0x1000 bytes for rid 0x10 type 3 at 0xc0214000
>> iwi0: could not allocate rx mbuf
>> iwi0: could not allocate Rx ring
>> bpfdetach: was not attached
>
> Never mind, kernel and user land weren't completely in
> sync and this might be related to the recent wlan commits.
> I'll retry with an up-to-date user land.
>

I have updated the patch here:

http://people.freebsd.org/~jeff/mbuf_ref2.diff

This resolves the !INVARIANTS bug and improves the style as you suggested.

Thanks,
Jeff

> Fabian
>