Date: Wed, 20 Feb 2008 13:14:44 +0200 From: Kostik Belousov <kostikbel@gmail.com> To: d@delphij.net Cc: freebsd-fs@freebsd.org, Alexander Leidinger <Alexander@Leidinger.net>, FreeBSD Current <freebsd-current@freebsd.org> Subject: Re: [PATCH FOR REVIEW] fsck_ffs: Recover from catastrophic damage Message-ID: <20080220111444.GH57756@deviant.kiev.zoral.com.ua> In-Reply-To: <47BBF9CC.4030404@delphij.net> References: <47BBD864.3070905@delphij.net> <20080220105614.eydtkfap4gogk0cw@webmail.leidinger.net> <47BBF9CC.4030404@delphij.net>
next in thread | previous in thread | raw e-mail | index | archive | help
[-- Attachment #1 --] On Wed, Feb 20, 2008 at 01:58:36AM -0800, Xin LI wrote: > -----BEGIN PGP SIGNED MESSAGE----- > Hash: SHA1 > > Alexander Leidinger wrote: > > Quoting Xin LI <delphij@delphij.net> (from Tue, 19 Feb 2008 23:36:04 > > -0800): > > > >> Change summary: > >> > >> fsutil.c: > >> - Really update standard superblock. fsck_ffs -b used to update the > >> backup superblock which does not recover file systems which have bad > >> master superblocks. > >> - Instead of coredump, zero out whole cg if its signature is bad. > >> > >> inode.c: > >> - Instead of coredump, zero out whole cg if its signature is bad. > > > > Does this modify (zero out) on-disk blocks? If yes, shouldn't this ask > > for confirmation? > > My assumption is that if a cylinder group's magic number is damaged, > then the whole stuff can not be trusted at all, but yes, I think this > should come with a prompt, will add tomorrow. I have some uneasy feeling about automatically zeroing a cg. I think it would be safer to show the message there, and add the same functionality to fsdb, something like clrcg command, analogous to clri. [-- Attachment #2 --] -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.8 (FreeBSD) iEYEARECAAYFAke8C6MACgkQC3+MBN1Mb4hvnACeLqs9DokpnnsjAcFSWXrxLYDq 1iIAnjNMukCTe1AzihTKlCP1jAi+zLvG =ltem -----END PGP SIGNATURE-----
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20080220111444.GH57756>