From owner-freebsd-current@freebsd.org Wed Sep 19 17:08:22 2018 Return-Path: Delivered-To: freebsd-current@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id 58C2410A1DA1 for ; Wed, 19 Sep 2018 17:08:22 +0000 (UTC) (envelope-from marklmi@yahoo.com) Received: from sonic311-14.consmr.mail.bf2.yahoo.com (sonic311-14.consmr.mail.bf2.yahoo.com [74.6.131.124]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (Client did not present a certificate) by mx1.freebsd.org (Postfix) with ESMTPS id 00B4E8A115 for ; Wed, 19 Sep 2018 17:08:21 +0000 (UTC) (envelope-from marklmi@yahoo.com) X-YMail-OSG: Q.L4NZQVM1mOjI4mL.g4zrH59cEdMSdl.DzL7c5ACcJyJfqgctPZXZcBNwWmegH pc5uiReV_OZJ.82PKt234LUtJaCaiwxJeu_EyRe.RmegxyAsrhl8WpHBT2O.R2UUrb1Xg_gmSMy6 rlrD8gQZx_RskVlMoWpEjCQGv5oSJg9NTwAe5UmY6qq83sXGPtdcQcZxUJBJaHSsIOxgBmK4ODzr zR6TBdDwdpvAQ4r9ak1yXR1Ix_hgdiTMM4gvZSsDSbHfEasiMGj44E.GZ_pyQfQiCnWKa0evSfB5 VsSoIuQ.lKtQ7lretbnrTmdQt6C.rPhWX3_fISjW39lgwM9.bbwY_TI_Gv7PqFOzklQ9XKesBw4J qwT5XaOR5lv.qTdupQW6jYm.wWnVMFzhvBCEg37RcAQb8wrtiPsbrlHVOE2g8FC_MgZJJKg.rVmU hzPPLNxAS20ZBbiI0oZCNe6zctEN1yQjdGDQBHj4PaEAsdMSWK6SXtCc_RTV0N5_37Ek6m0Z_MTR .pt_oyFfXgArN4BvUlGuU7z.Cv_743lWBUUPG.sqQxQXgncJQNcy3YmwEdL4nC6ejmR2_n28ZLTv ku8JiFqbgoif_leYLmXPPRuufnYDZQT6jgmbIC14I0fL4GlRIPgo_bpiNKQEV1CjBoqsDSNZahUf 0oMkwQusoG789GaHRZOZ8nITXbsGmw9hvVB5wqaRfok7pqXGaqbVKdu4hRPKRuwygdBrjlGWDVCj vn7iPIC.xIoDSpxG8YBJdS_FO2nglwWfQAqnWPEmilofqqOX3KtXV5PkhpZEK3fAkQnk6M3X2o4B NwjMKaF_OaCIF1ldK.o04a23JChv.XdW8OX4LbPwME2cSjEc2eH4Zo.GOrwTKNY0zFvYCzRuQM2. 0Uy9.tLO0pYJFHWS.ZfiQv2YrklEFhyhysLuWWNpCoNvwnhQNH94t_yWR4Z47itS2IZpZgOlZHdF hFSLUPrvgUN.AVqOf7eD9HOZOdj.QzQz_TcH__WNECqPOv51AclDsMEi85uTcnY21fWYVJQa3GYc UEaSdWa53QVY- Received: from sonic.gate.mail.ne1.yahoo.com by sonic311.consmr.mail.bf2.yahoo.com with HTTP; Wed, 19 Sep 2018 17:08:21 +0000 Received: from ip70-189-131-151.lv.lv.cox.net (EHLO [192.168.0.105]) ([70.189.131.151]) by smtp414.mail.bf1.yahoo.com (Oath Hermes SMTP Server) with ESMTPA ID 9b40400b4fba9e6a27c69837c3431738; Wed, 19 Sep 2018 17:08:18 +0000 (UTC) Content-Type: text/plain; charset=us-ascii Mime-Version: 1.0 (Mac OS X Mail 11.5 \(3445.9.1\)) Subject: Re: Some delete-old detrius From: Mark Millard In-Reply-To: Date: Wed, 19 Sep 2018 10:08:16 -0700 Cc: FreeBSD Current Content-Transfer-Encoding: quoted-printable Message-Id: <446D76C1-4563-43FA-8B25-3A84245385F7@yahoo.com> References: <26183B75-2CBD-4D98-A59F-85617D5D18E2@yahoo.com> To: Sean Bruno X-Mailer: Apple Mail (2.3445.9.1) X-BeenThere: freebsd-current@freebsd.org X-Mailman-Version: 2.1.27 Precedence: list List-Id: Discussions about the use of FreeBSD-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 19 Sep 2018 17:08:22 -0000 On 2018-Sep-19, at 9:14 AM, Sean Bruno wrote: > On 9/18/18 8:48 PM, Mark Millard wrote: >> A problem here is that the references should be to usr.bin instead >> of usr/bin . See: >>=20 >> = https://lists.freebsd.org/pipermail/svn-src-head/2018-September/118426.htm= l >>=20 >> which reports for svn commit: r336601 - head: >>=20 >> QUOTE >> Looks like this head/ObsoleteFiles.inc update has a typo >> in each thing added to OLD_FILES . . . >>=20 >> # ls -lTdt /usr/tests/usr.bin/indent/* >> -r--r--r-- 1 root wheel 121 Sep 13 22:53:30 2018 = /usr/tests/usr.bin/indent/Kyuafile >> . . . >> -r--r--r-- 1 root wheel 295 Sep 13 22:53:29 2018 = /usr/tests/usr.bin/indent/binary.0 >> -r--r--r-- 1 root wheel 92 May 1 19:35:24 2018 = /usr/tests/usr.bin/indent/sac.0.pro >> -r--r--r-- 1 root wheel 130 May 1 19:35:24 2018 = /usr/tests/usr.bin/indent/sac.0.stdout >> -r--r--r-- 1 root wheel 122 May 1 19:35:24 2018 = /usr/tests/usr.bin/indent/sac.0 >> -r--r--r-- 1 root wheel 94 May 1 19:35:24 2018 = /usr/tests/usr.bin/indent/nsac.0.pro >> -r--r--r-- 1 root wheel 130 May 1 19:35:24 2018 = /usr/tests/usr.bin/indent/nsac.0.stdout >> -r--r--r-- 1 root wheel 123 May 1 19:35:24 2018 = /usr/tests/usr.bin/indent/nsac.0 >>=20 >> vs. ( note usr.bin vs. usr/bin ): >>=20 >> Modified: head/ObsoleteFiles.inc >> = =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D >> --- head/ObsoleteFiles.inc Sun Jul 22 12:04:21 2018 = (r336600) >> +++ head/ObsoleteFiles.inc Sun Jul 22 12:45:02 2018 = (r336601) >> @@ -38,6 +38,13 @@ >> # xargs -n1 | sort | uniq -d; >> # done >>=20 >> +# 20180722: indent(1) option renamed, test files follow >> +OLD_FILES+=3Dusr/bin/indent/tests/nsac.0 >> +OLD_FILES+=3Dusr/bin/indent/tests/nsac.0.pro >> +OLD_FILES+=3Dusr/bin/indent/tests/nsac.0.stdout >> +OLD_FILES+=3Dusr/bin/indent/tests/sac.0 >> +OLD_FILES+=3Dusr/bin/indent/tests/sac.0.pro >> +OLD_FILES+=3Dusr/bin/indent/tests/sac.0.stdout >> # 20180721: move of libmlx5.so.1 and libibverbs.so.1 >> OLD_LIBS+=3Dusr/lib/libmlx5.so.1 >> OLD_LIBS+=3Dusr/lib/libibverbs.so.1 >> END QUOTE >>=20 >> This was after having the nsac and sac kyua tests report >> failures in my environment, long after they should have >> not existed. >>=20 >>=20 >>=20 >> =3D=3D=3D >> Mark Millard >> marklmi at yahoo.com >> ( dsl-only.net went >> away in early 2018-Mar) >>=20 >>=20 >=20 > So, what should we even do here? It sort of looks like this entire > section should be purged or something. >=20 > There was a bit of error committing this section I guess. As near as I can tell the fix would be something like: # svnlite diff /usr/src/ObsoleteFiles.inc Index: /usr/src/ObsoleteFiles.inc =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D --- /usr/src/ObsoleteFiles.inc (revision 338675) +++ /usr/src/ObsoleteFiles.inc (working copy) @@ -48,12 +48,12 @@ # 20180725: Cleanup old libcasper.so.0 OLD_LIBS+=3Dlib/libcasper.so.0 # 20180722: indent(1) option renamed, test files follow -OLD_FILES+=3Dusr/bin/indent/tests/nsac.0 -OLD_FILES+=3Dusr/bin/indent/tests/nsac.0.pro -OLD_FILES+=3Dusr/bin/indent/tests/nsac.0.stdout -OLD_FILES+=3Dusr/bin/indent/tests/sac.0 -OLD_FILES+=3Dusr/bin/indent/tests/sac.0.pro -OLD_FILES+=3Dusr/bin/indent/tests/sac.0.stdout +OLD_FILES+=3Dusr/tests/usr.bin/indent/nsac.0 +OLD_FILES+=3Dusr/tests/usr.bin/indent/nsac.0.pro +OLD_FILES+=3Dusr/tests/usr.bin/indent/nsac.0.stdout +OLD_FILES+=3Dusr/tests/usr.bin/indent/sac.0 +OLD_FILES+=3Dusr/tests/usr.bin/indent/sac.0.pro +OLD_FILES+=3Dusr/tests/usr.bin/indent/sac.0.stdout # 20180721: move of libmlx5.so.1 and libibverbs.so.1 OLD_LIBS+=3Dusr/lib/libmlx5.so.1 OLD_LIBS+=3Dusr/lib/libibverbs.so.1 This is sort of like the older part of the file: # 20170322: rename to _test to match the FreeBSD test suite name = scheme OLD_FILES+=3Dusr/tests/usr.bin/col/col OLD_FILES+=3Dusr/tests/usr.bin/diff/diff OLD_FILES+=3Dusr/tests/usr.bin/ident/ident OLD_FILES+=3Dusr/tests/usr.bin/mkimg/mkimg OLD_FILES+=3Dusr/tests/usr.bin/sdiff/sdiff OLD_FILES+=3Dusr/tests/usr.bin/soelim/soelim OLD_FILES+=3Dusr/tests/usr.sbin/pw/pw_config OLD_FILES+=3Dusr/tests/usr.sbin/pw/pw_etcdir OLD_FILES+=3Dusr/tests/usr.sbin/pw/pw_groupadd OLD_FILES+=3Dusr/tests/usr.sbin/pw/pw_groupdel OLD_FILES+=3Dusr/tests/usr.sbin/pw/pw_groupmod OLD_FILES+=3Dusr/tests/usr.sbin/pw/pw_lock OLD_FILES+=3Dusr/tests/usr.sbin/pw/pw_useradd OLD_FILES+=3Dusr/tests/usr.sbin/pw/pw_userdel OLD_FILES+=3Dusr/tests/usr.sbin/pw/pw_usermod OLD_FILES+=3Dusr/tests/usr.sbin/pw/pw_usernext =3D=3D=3D Mark Millard marklmi at yahoo.com ( dsl-only.net went away in early 2018-Mar)