Date: Wed, 9 Mar 2016 17:13:49 +0000 (UTC) From: Mark Felder <feld@FreeBSD.org> To: ports-committers@freebsd.org, svn-ports-all@freebsd.org, svn-ports-head@freebsd.org Subject: svn commit: r410712 - in head/graphics/giflib: . files Message-ID: <201603091713.u29HDnQa091508@repo.freebsd.org>
next in thread | raw e-mail | index | archive | help
Author: feld Date: Wed Mar 9 17:13:49 2016 New Revision: 410712 URL: https://svnweb.freebsd.org/changeset/ports/410712 Log: graphics/giflib: Add patch to fix regression There is a regression with the 5.1.2 update to giflib. This affects the ability for applications to render gif images usually ocurring after the first gif image is rendered. Upstream has been notified but has not yet provided feedback. giflib 5.1.2 was a security fix, so reverting is not reasonable. "The removed check look redundant - I couldn't find a code path where Private->RunningBits would exceed that limit after initialization. (Currently Private->RunningBits is checked before it is initialized)." PR: 207849 Submitted by: Stefan Ehmann <shoesoft@gmx.net> Approved by: ports-secteam (with hat) MFH: 2016Q1 Added: head/graphics/giflib/files/patch-lib_dgif__lib.c (contents, props changed) Modified: head/graphics/giflib/Makefile Modified: head/graphics/giflib/Makefile ============================================================================== --- head/graphics/giflib/Makefile Wed Mar 9 17:06:53 2016 (r410711) +++ head/graphics/giflib/Makefile Wed Mar 9 17:13:49 2016 (r410712) @@ -3,7 +3,7 @@ PORTNAME= giflib PORTVERSION= 5.1.2 -PORTREVISION= 1 +PORTREVISION= 2 CATEGORIES= graphics MASTER_SITES= SF/${PORTNAME} Added: head/graphics/giflib/files/patch-lib_dgif__lib.c ============================================================================== --- /dev/null 00:00:00 1970 (empty, because file is newly added) +++ head/graphics/giflib/files/patch-lib_dgif__lib.c Wed Mar 9 17:13:49 2016 (r410712) @@ -0,0 +1,11 @@ +--- lib/dgif_lib.c.orig 2016-03-06 10:52:49.090426000 +0100 ++++ lib/dgif_lib.c 2016-03-06 10:53:00.938584000 +0100 +@@ -764,7 +764,7 @@ + BitsPerPixel = CodeSize; + + /* this can only happen on a severely malformed GIF */ +- if (BitsPerPixel > 8 || Private->RunningBits > 32) { ++ if (BitsPerPixel > 8) { + GifFile->Error = D_GIF_ERR_READ_FAILED; /* somewhat bogus error code */ + return GIF_ERROR; /* Failed to read Code size. */ + }
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?201603091713.u29HDnQa091508>