From owner-freebsd-virtualization@freebsd.org Wed Jan 15 08:53:00 2020 Return-Path: Delivered-To: freebsd-virtualization@mailman.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.nyi.freebsd.org (Postfix) with ESMTP id E74BE225AF6 for ; Wed, 15 Jan 2020 08:53:00 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from mailman.nyi.freebsd.org (unknown [127.0.1.3]) by mx1.freebsd.org (Postfix) with ESMTP id 47yLgw5vjHz4GQR for ; Wed, 15 Jan 2020 08:53:00 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: by mailman.nyi.freebsd.org (Postfix) id C8CA6225AF5; Wed, 15 Jan 2020 08:53:00 +0000 (UTC) Delivered-To: virtualization@mailman.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.nyi.freebsd.org (Postfix) with ESMTP id C88B2225AF4 for ; Wed, 15 Jan 2020 08:53:00 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from mxrelay.nyi.freebsd.org (mxrelay.nyi.freebsd.org [IPv6:2610:1c1:1:606c::19:3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) server-signature RSA-PSS (4096 bits) client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "mxrelay.nyi.freebsd.org", Issuer "Let's Encrypt Authority X3" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 47yLgw4whPz4GQQ for ; Wed, 15 Jan 2020 08:53:00 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from kenobi.freebsd.org (kenobi.freebsd.org [IPv6:2610:1c1:1:606c::50:1d]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client did not present a certificate) by mxrelay.nyi.freebsd.org (Postfix) with ESMTPS id A48904140 for ; Wed, 15 Jan 2020 08:53:00 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from kenobi.freebsd.org ([127.0.1.5]) by kenobi.freebsd.org (8.15.2/8.15.2) with ESMTP id 00F8r0uS095827 for ; Wed, 15 Jan 2020 08:53:00 GMT (envelope-from bugzilla-noreply@freebsd.org) Received: (from www@localhost) by kenobi.freebsd.org (8.15.2/8.15.2/Submit) id 00F8r0V1095825 for virtualization@FreeBSD.org; Wed, 15 Jan 2020 08:53:00 GMT (envelope-from bugzilla-noreply@freebsd.org) X-Authentication-Warning: kenobi.freebsd.org: www set sender to bugzilla-noreply@freebsd.org using -f From: bugzilla-noreply@freebsd.org To: virtualization@FreeBSD.org Subject: [Bug 236922] Virtio fails as QEMU-KVM guest with Q35 chipset on Ubuntu 18.04.2 LTS Date: Wed, 15 Jan 2020 08:53:00 +0000 X-Bugzilla-Reason: AssignedTo X-Bugzilla-Type: changed X-Bugzilla-Watch-Reason: None X-Bugzilla-Product: Base System X-Bugzilla-Component: kern X-Bugzilla-Version: 12.0-RELEASE X-Bugzilla-Keywords: needs-qa X-Bugzilla-Severity: Affects Some People X-Bugzilla-Who: drum@graphica.com.au X-Bugzilla-Status: Open X-Bugzilla-Resolution: X-Bugzilla-Priority: --- X-Bugzilla-Assigned-To: virtualization@FreeBSD.org X-Bugzilla-Flags: X-Bugzilla-Changed-Fields: Message-ID: In-Reply-To: References: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Bugzilla-URL: https://bugs.freebsd.org/bugzilla/ Auto-Submitted: auto-generated MIME-Version: 1.0 X-BeenThere: freebsd-virtualization@freebsd.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "Discussion of various virtualization techniques FreeBSD supports." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 15 Jan 2020 08:53:01 -0000 https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=3D236922 --- Comment #42 from John Hartley --- (In reply to Tommy P from comment #41) Hi Tommy P & Brian V & Vicenzo, the VirtIO network update conflicts with Vincenzo's netmap fix. In my earlier test of VirtIO patch test I had just disable netmap via GENER= IC conf file and not applied netmap fix. I have now tested against 12.1 where I first applied the netmap fix. Here is compile error: cc -target x86_64-unknown-freebsd12.1 --sysroot=3D/usr/obj/usr/src/amd64.amd64/tmp -B/usr/obj/usr/src/amd64.amd64/tmp/usr/bin -c -O2 -pipe -fno-strict-aliasin= g=20 -g -nostdinc -I. -I/usr/src/sys -I/usr/src/sys/contrib/ck/include -I/usr/src/sys/contrib/libfdt -D_KERNEL -DHAVE_KERNEL_OPTION_HEADERS -inclu= de opt_global.h -fno-omit-frame-pointer -mno-omit-leaf-frame-pointer -MD=20 -MF.depend.if_vtnet.o -MTif_vtnet.o -fdebug-prefix-map=3D./machine=3D/usr/src/sys/amd64/include -fdebug-prefix-map=3D./x86=3D/usr/src/sys/x86/include -mcmodel=3Dkernel -mn= o-red-zone -mno-mmx -mno-sse -msoft-float -fno-asynchronous-unwind-tables -ffreestand= ing -fwrapv -fstack-protector -gdwarf-2 -Wall -Wredundant-decls -Wnested-externs -Wstrict-prototypes -Wmissing-prototypes -Wpointer-arith -Wcast-qual -Wundef -Wno-pointer-sign -D__printf__=3D__freebsd_kprintf__ -Wmissing-include-dirs -fdiagnostics-show-option -Wno-unknown-pragmas -Wno-error-tautological-comp= are -Wno-error-empty-body -Wno-error-parentheses-equality -Wno-error-unused-function -Wno-error-pointer-sign -Wno-error-shift-negative-value -Wno-address-of-packed-member -mno-aes -mno-avx -std=3Diso9899:1999 -Werror /usr/src/sys/dev/virtio/network/if_v= tnet.c In file included from /usr/src/sys/dev/virtio/network/if_vtnet.c:351: /usr/src/sys/dev/netmap/if_vtnet_netmap.h:94:2: error: implicit declaration= of function 'D' is invalid in C99 [-Werror,-Wimplicit-function-declaration] D("freed %d mbufs, %d netmap bufs on %d queues", ^ /usr/src/sys/dev/netmap/if_vtnet_netmap.h:94:2: error: this function declaration is not a prototype [-Werror,-Wstrict-prototypes] /usr/src/sys/dev/netmap/if_vtnet_netmap.h:297:3: error: implicit declaratio= n of function 'ND' is invalid in C99 [-Werror,-Wimplicit-function-declaration] ND(3,"sent %d packets, hwcur %d", n, nm_i); ^ /usr/src/sys/dev/netmap/if_vtnet_netmap.h:297:3: error: this function declaration is not a prototype [-Werror,-Wstrict-prototypes] /usr/src/sys/dev/netmap/if_vtnet_netmap.h:306:7: error: implicit declaratio= n of function 'ND' is invalid in C99 [-Werror,-Wimplicit-function-declaration] ND(5, "pure notify ? head %d tail %d nused %d %d", ^ /usr/src/sys/dev/netmap/if_vtnet_netmap.h:340:3: error: implicit declaratio= n of function 'ND' is invalid in C99 [-Werror,-Wimplicit-function-declaration] ND(3, "disable intr, hwcur %d", nm_i); ^ /usr/src/sys/dev/netmap/if_vtnet_netmap.h:343:3: error: implicit declaratio= n of function 'ND' is invalid in C99 [-Werror,-Wimplicit-function-declaration] ND(3, "enable intr, hwcur %d", nm_i); ^ /usr/src/sys/dev/netmap/if_vtnet_netmap.h:297:37: error: variable 'n' is uninitialized when used here [-Werror,-Wuninitialized] ND(3,"sent %d packets, hwcur %d", n, nm_i); ^ /usr/src/sys/dev/netmap/if_vtnet_netmap.h:245:9: note: initialize the varia= ble 'n' to silence this warning u_int n; ^ =3D 0 /usr/src/sys/dev/netmap/if_vtnet_netmap.h:486:6: error: implicit declaratio= n of function 'RD' is invalid in C99 [-Werror,-Wimplicit-function-declaration] RD(1, "Truncated virtio-net-header,= " ^ /usr/src/sys/dev/netmap/if_vtnet_netmap.h:486:6: error: this function declaration is not a prototype [-Werror,-Wstrict-prototypes] /usr/src/sys/dev/netmap/if_vtnet_netmap.h:498:2: error: implicit declaratio= n of function 'ND' is invalid in C99 [-Werror,-Wimplicit-function-declaration] ND("[B] h %d c %d hwcur %d hwtail %d", ^ /usr/src/sys/dev/netmap/if_vtnet_netmap.h:566:4: error: implicit declaratio= n of function 'D' is invalid in C99 [-Werror,-Wimplicit-function-declaration] D("strange, null netmap ring %d", r); ^ /usr/src/sys/dev/netmap/if_vtnet_netmap.h:662:2: error: implicit declaratio= n of function 'D' is invalid in C99 [-Werror,-Wimplicit-function-declaration] D("max rings %d", sc->vtnet_max_vq_pairs); ^ /usr/src/sys/dev/virtio/network/if_vtnet.c:3411:3: error: implicit declarat= ion of function 'D' is invalid in C99 [-Werror,-Wimplicit-function-declaration] D("try to attach again"); ^ 14 errors generated. *** Error code 1 As sys/dev/netmap/if_vtnet_netmap.h was one of replaced files that was prov= ided with fix, I put back the original 12.1 version (this was not changed or upd= ate by Vincenzo's netmap fix). The result was failure in compiling sys/dev/virtio/network/if_vtnet.c Here is compile result: cc -target x86_64-unknown-freebsd12.1 --sysroot=3D/usr/obj/usr/src/amd64.amd64/tmp -B/usr/obj/usr/src/amd64.amd64/tmp/usr/bin -c -O2 -pipe -fno-strict-aliasin= g=20 -g -nostdinc -I. -I/usr/src/sys -I/usr/src/sys/contrib/ck/include -I/usr/src/sys/contrib/libfdt -D_KERNEL -DHAVE_KERNEL_OPTION_HEADERS -inclu= de opt_global.h -fno-omit-frame-pointer -mno-omit-leaf-frame-pointer -MD=20 -MF.depend.if_vtnet.o -MTif_vtnet.o -fdebug-prefix-map=3D./machine=3D/usr/src/sys/amd64/include -fdebug-prefix-map=3D./x86=3D/usr/src/sys/x86/include -mcmodel=3Dkernel -mn= o-red-zone -mno-mmx -mno-sse -msoft-float -fno-asynchronous-unwind-tables -ffreestand= ing -fwrapv -fstack-protector -gdwarf-2 -Wall -Wredundant-decls -Wnested-externs -Wstrict-prototypes -Wmissing-prototypes -Wpointer-arith -Wcast-qual -Wundef -Wno-pointer-sign -D__printf__=3D__freebsd_kprintf__ -Wmissing-include-dirs -fdiagnostics-show-option -Wno-unknown-pragmas -Wno-error-tautological-comp= are -Wno-error-empty-body -Wno-error-parentheses-equality -Wno-error-unused-function -Wno-error-pointer-sign -Wno-error-shift-negative-value -Wno-address-of-packed-member -mno-aes -mno-avx -std=3Diso9899:1999 -Werror /usr/src/sys/dev/virtio/network/if_v= tnet.c /usr/src/sys/dev/virtio/network/if_vtnet.c:3219:6: error: implicit declarat= ion of function 'vtnet_netmap_init_rx_buffers' is invalid in C99 [-Werror,-Wimplicit-function-declaration] if (vtnet_netmap_init_rx_buffers(sc)) ^ /usr/src/sys/dev/virtio/network/if_vtnet.c:3219:6: error: this function declaration is not a prototype [-Werror,-Wstrict-prototypes] /usr/src/sys/dev/virtio/network/if_vtnet.c:3411:3: error: implicit declarat= ion of function 'D' is invalid in C99 [-Werror,-Wimplicit-function-declaration] D("try to attach again"); ^ /usr/src/sys/dev/virtio/network/if_vtnet.c:3411:3: error: this function declaration is not a prototype [-Werror,-Wstrict-prototypes] 4 errors generated. *** Error code 1 Stop. make[2]: stopped in /usr/obj/usr/src/amd64.amd64/sys/GENERIC *** Error code 1 Given that both Brian (virtio committer) and Vincenzo (netmap committer) ha= ve both been involved in helping to resolve VirtIO and netmap related issues, = it would be great if we could get VirtIO and netmap fixes that worked together. Thanks, John Hartley. --=20 You are receiving this mail because: You are the assignee for the bug.=