From owner-freebsd-hackers@FreeBSD.ORG Sun Oct 7 12:17:36 2012 Return-Path: Delivered-To: freebsd-hackers@FreeBSD.org Received: from mx1.freebsd.org (mx1.freebsd.org [69.147.83.52]) by hub.freebsd.org (Postfix) with ESMTP id 42CA4106566C for ; Sun, 7 Oct 2012 12:17:36 +0000 (UTC) (envelope-from avg@FreeBSD.org) Received: from citadel.icyb.net.ua (citadel.icyb.net.ua [212.40.38.140]) by mx1.freebsd.org (Postfix) with ESMTP id 930F38FC18 for ; Sun, 7 Oct 2012 12:17:34 +0000 (UTC) Received: from porto.starpoint.kiev.ua (porto-e.starpoint.kiev.ua [212.40.38.100]) by citadel.icyb.net.ua (8.8.8p3/ICyb-2.3exp) with ESMTP id PAA14196 for ; Sun, 07 Oct 2012 15:17:32 +0300 (EEST) (envelope-from avg@FreeBSD.org) Received: from localhost ([127.0.0.1]) by porto.starpoint.kiev.ua with esmtp (Exim 4.34 (FreeBSD)) id 1TKpnY-000873-Gy for freebsd-hackers@freebsd.org; Sun, 07 Oct 2012 15:17:32 +0300 Message-ID: <507172DA.2020309@FreeBSD.org> Date: Sun, 07 Oct 2012 15:17:30 +0300 From: Andriy Gapon User-Agent: Mozilla/5.0 (X11; FreeBSD amd64; rv:15.0) Gecko/20120913 Thunderbird/15.0.1 MIME-Version: 1.0 To: freebsd-hackers X-Enigmail-Version: 1.4.3 Content-Type: text/plain; charset=X-VIET-VPS Content-Transfer-Encoding: 7bit Cc: Subject: machine/cpu.h in userland X-BeenThere: freebsd-hackers@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: Technical Discussions relating to FreeBSD List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sun, 07 Oct 2012 12:17:36 -0000 I noticed that couple of our userland file include machine/cpu.h for no apparent good reason. It looks like at least amd64 cpu.h has no userland serviceable parts inside. Maybe its content should be put under _KERNEL ? Also: --- a/sbin/adjkerntz/adjkerntz.c +++ b/sbin/adjkerntz/adjkerntz.c @@ -51,7 +51,6 @@ __FBSDID("$FreeBSD$"); #include #include #include -#include #include #include "pathnames.h" diff --git a/usr.bin/w/w.c b/usr.bin/w/w.c index 8441ce5..9674fc2 100644 --- a/usr.bin/w/w.c +++ b/usr.bin/w/w.c @@ -57,7 +57,6 @@ static const char sccsid[] = "@(#)w.c 8.4 (Berkeley) 4/16/94"; #include #include -#include #include #include #include -- Andriy Gapon