From owner-freebsd-geom@FreeBSD.ORG  Tue Jun 20 06:35:27 2006
Return-Path: <owner-freebsd-geom@FreeBSD.ORG>
X-Original-To: freebsd-geom@freebsd.org
Delivered-To: freebsd-geom@freebsd.org
Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125])
	by hub.freebsd.org (Postfix) with ESMTP id 4462116A47A;
	Tue, 20 Jun 2006 06:35:27 +0000 (UTC)
	(envelope-from rodrigc@crodrigues.org)
Received: from sccrmhc15.comcast.net (sccrmhc15.comcast.net [63.240.77.85])
	by mx1.FreeBSD.org (Postfix) with ESMTP id EFA8E43D46;
	Tue, 20 Jun 2006 06:35:25 +0000 (GMT)
	(envelope-from rodrigc@crodrigues.org)
Received: from c-71-233-168-2.hsd1.ma.comcast.net ([71.233.168.2])
	by comcast.net (sccrmhc15) with ESMTP
	id <200606200635240150091q9ie>; Tue, 20 Jun 2006 06:35:24 +0000
Received: from c-71-233-168-2.hsd1.ma.comcast.net (localhost [127.0.0.1])
	by c-71-233-168-2.hsd1.ma.comcast.net (8.13.6/8.13.1) with ESMTP id
	k5K6ZP7e011559; Tue, 20 Jun 2006 02:35:25 -0400 (EDT)
	(envelope-from rodrigc@c-71-233-168-2.hsd1.ma.comcast.net)
Received: (from rodrigc@localhost)
	by c-71-233-168-2.hsd1.ma.comcast.net (8.13.6/8.13.1/Submit) id
	k5K6ZPF0011558; Tue, 20 Jun 2006 02:35:25 -0400 (EDT)
	(envelope-from rodrigc)
Date: Tue, 20 Jun 2006 02:35:25 -0400
From: Craig Rodrigues <rodrigc@crodrigues.org>
To: Pawel Jakub Dawidek <pjd@freebsd.org>
Message-ID: <20060620063525.GA11441@crodrigues.org>
References: <20060619131101.GD1130@garage.freebsd.pl>
Mime-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20060619131101.GD1130@garage.freebsd.pl>
User-Agent: Mutt/1.4.2.1i
Cc: freebsd-fs@freebsd.org, freebsd-current@freebsd.org,
	freebsd-geom@freebsd.org
Subject: Re: Journaling UFS with gjournal.
X-BeenThere: freebsd-geom@freebsd.org
X-Mailman-Version: 2.1.5
Precedence: list
List-Id: GEOM-specific discussions and implementations
	<freebsd-geom.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-geom>,
	<mailto:freebsd-geom-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/freebsd-geom>
List-Post: <mailto:freebsd-geom@freebsd.org>
List-Help: <mailto:freebsd-geom-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-geom>,
	<mailto:freebsd-geom-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Tue, 20 Jun 2006 06:35:27 -0000

On Mon, Jun 19, 2006 at 03:11:01PM +0200, Pawel Jakub Dawidek wrote:
> 	http://people.freebsd.org/~pjd/patches/gjournal.patch (for HEAD)
> 	http://people.freebsd.org/~pjd/patches/gjournal6.patch (for RELENG_6)

I would recommend that you not introduce a new MNT_GJOURNAL flag to 
<sys/mount.h>,
and that instead you just pass -o gjournal directly down into
nmount().  In kernel code, you can use vfs_flagopt()/vfs_getopt()
to determine if you have this mount option or not.
The mount(8) userland utility would not need any modifications,
since it just passes -o options down to nmount().

gjournal looks very interesting!
-- 
Craig Rodrigues        
rodrigc@crodrigues.org