Date: Tue, 20 Jun 2006 02:35:25 -0400 From: Craig Rodrigues <rodrigc@crodrigues.org> To: Pawel Jakub Dawidek <pjd@freebsd.org> Cc: freebsd-fs@freebsd.org, freebsd-current@freebsd.org, freebsd-geom@freebsd.org Subject: Re: Journaling UFS with gjournal. Message-ID: <20060620063525.GA11441@crodrigues.org> In-Reply-To: <20060619131101.GD1130@garage.freebsd.pl> References: <20060619131101.GD1130@garage.freebsd.pl>
next in thread | previous in thread | raw e-mail | index | archive | help
On Mon, Jun 19, 2006 at 03:11:01PM +0200, Pawel Jakub Dawidek wrote: > http://people.freebsd.org/~pjd/patches/gjournal.patch (for HEAD) > http://people.freebsd.org/~pjd/patches/gjournal6.patch (for RELENG_6) I would recommend that you not introduce a new MNT_GJOURNAL flag to <sys/mount.h>, and that instead you just pass -o gjournal directly down into nmount(). In kernel code, you can use vfs_flagopt()/vfs_getopt() to determine if you have this mount option or not. The mount(8) userland utility would not need any modifications, since it just passes -o options down to nmount(). gjournal looks very interesting! -- Craig Rodrigues rodrigc@crodrigues.org
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20060620063525.GA11441>