Date: Sat, 8 Mar 1997 18:28:05 -0500 (EST) From: mab@sjca.edu To: FreeBSD-gnats-submit@freebsd.org Subject: ports/2921: wide-dhcp client doesn't work because of byte-ordering problems Message-ID: <199703082328.SAA20618@continuity> Resent-Message-ID: <199703090030.QAA11787@freefall.freebsd.org>
next in thread | raw e-mail | index | archive | help
>Number: 2921
>Category: ports
>Synopsis: wide-dhcp client doesn't work because of byte-ordering problems
>Confidential: no
>Severity: serious
>Priority: high
>Responsible: freebsd-ports
>State: open
>Class: sw-bug
>Submitter-Id: current-users
>Arrival-Date: Sat Mar 8 16:30:02 PST 1997
>Last-Modified:
>Originator: Matt Braithwaite
>Organization:
>Release: FreeBSD 2.1-STABLE i386
>Environment:
wide-dhcp 1.3beta port from ports-current, and ISC DHCPd 5.14beta (i
think...)
>Description:
the client doesn't notice the DHCPOFFER sent by the server. patch
enclosed.
>How-To-Repeat:
try to obtain an address with the client.
>Fix:
*** ./client/dhcpc.c~ Sat Mar 8 17:46:14 1997
--- ./client/dhcpc.c Tue Mar 4 15:58
:15 1997
***************
*** 265,273 ****
* split conditions into pieces for debugging
*/
#ifndef sun
! if (ntohs(rcv.ip->ip_len) < DFLTBOOTPLEN + UDPHL + IPHL)
return(0);
! if (ntohs(rcv.udp->uh_ulen) < DFLTBOOTPLEN + UDPHL)
return(0);
#else
if (rcv.udp->uh_dport != dhcpc_port)
--- 265,273 ----
* split conditions into pieces for debugging
*/
#ifndef sun
! if (rcv.ip->ip_len < DFLTBOOTPLEN + UDPHL + IPHL)
return(0);
! if (rcv.udp->uh_ulen < DFLTBOOTPLEN + UDPHL)
return(0);
#else
if (rcv.udp->uh_dport != dhcpc_port)
***************
*** 322,330 ****
* split conditions into pieces for debugging
*/
#ifndef sun
! if (ntohs(rcv.ip->ip_len) < DFLTBOOTPLEN + UDPHL + IPHL)
return(0);
! if (ntohs(rcv.udp->uh_ulen) < DFLTBOOTPLEN + UDPHL)
return(0);
#else
if (rcv.udp->uh_dport != dhcpc_port)
--- 322,330 ----
* split conditions into pieces for debugging
*/
#ifndef sun
! if (rcv.ip->ip_len < DFLTBOOTPLEN + UDPHL + IPHL)
return(0);
! if (rcv.udp->uh_ulen < DFLTBOOTPLEN + UDPHL)
return(0);
#else
if (rcv.udp->uh_dport != dhcpc_port)
>Audit-Trail:
>Unformatted:
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?199703082328.SAA20618>