Skip site navigation (1)Skip section navigation (2)
Date:      Mon, 2 Sep 2002 12:40:32 -0400
From:      Mike Barcroft <mike@FreeBSD.org>
To:        luigi@FreeBSD.org
Cc:        current@FreeBSD.org
Subject:   Fatal warnings breaks ipfw on LP64
Message-ID:  <20020902124032.D94253@espresso.q9media.com>

next in thread | raw e-mail | index | archive | help

cc1: warnings being treated as errors
/usr/src/sys/netinet/ip_fw2.c: In function `ipfw_ctl':
/usr/src/sys/netinet/ip_fw2.c:2508: warning: cast from pointer to integer of different size
/usr/src/sys/netinet/ip_fw2.c:2521: warning: cast from pointer to integer of different size

Some of the code in question looks questionable:
                        /*
                         * abuse 'next_rule' to store the set_disable word
                         */
                        (u_int32_t)(((struct ip_fw *)bp)->next_rule) =
                                set_disable;

The rvalue is being cast in an assignment to make a pointer store an
integer?  Surely this can be written better.

Best regards,
Mike Barcroft

To Unsubscribe: send mail to majordomo@FreeBSD.org
with "unsubscribe freebsd-current" in the body of the message




Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20020902124032.D94253>