From owner-freebsd-bugs@FreeBSD.ORG  Sun Sep  6 14:30:07 2009
Return-Path: <owner-freebsd-bugs@FreeBSD.ORG>
Delivered-To: freebsd-bugs@hub.freebsd.org
Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34])
	by hub.freebsd.org (Postfix) with ESMTP id C1152106566B
	for <freebsd-bugs@hub.freebsd.org>;
	Sun,  6 Sep 2009 14:30:07 +0000 (UTC)
	(envelope-from gnats@FreeBSD.org)
Received: from freefall.freebsd.org (freefall.freebsd.org
	[IPv6:2001:4f8:fff6::28])
	by mx1.freebsd.org (Postfix) with ESMTP id B07AA8FC17
	for <freebsd-bugs@hub.freebsd.org>;
	Sun,  6 Sep 2009 14:30:07 +0000 (UTC)
Received: from freefall.freebsd.org (gnats@localhost [127.0.0.1])
	by freefall.freebsd.org (8.14.3/8.14.3) with ESMTP id n86EU7B9017754
	for <freebsd-bugs@freefall.freebsd.org>; Sun, 6 Sep 2009 14:30:07 GMT
	(envelope-from gnats@freefall.freebsd.org)
Received: (from gnats@localhost)
	by freefall.freebsd.org (8.14.3/8.14.3/Submit) id n86EU78x017751;
	Sun, 6 Sep 2009 14:30:07 GMT (envelope-from gnats)
Date: Sun, 6 Sep 2009 14:30:07 GMT
Message-Id: <200909061430.n86EU78x017751@freefall.freebsd.org>
To: freebsd-bugs@FreeBSD.org
From: dfilter@FreeBSD.ORG (dfilter service)
Cc: 
Subject: Re: kern/127316: commit references a PR
X-BeenThere: freebsd-bugs@freebsd.org
X-Mailman-Version: 2.1.5
Precedence: list
Reply-To: dfilter service <dfilter@FreeBSD.ORG>
List-Id: Bug reports <freebsd-bugs.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-bugs>,
	<mailto:freebsd-bugs-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/freebsd-bugs>
List-Post: <mailto:freebsd-bugs@freebsd.org>
List-Help: <mailto:freebsd-bugs-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-bugs>,
	<mailto:freebsd-bugs-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Sun, 06 Sep 2009 14:30:07 -0000

The following reply was made to PR kern/127316; it has been noted by GNATS.

From: dfilter@FreeBSD.ORG (dfilter service)
To: bug-followup@FreeBSD.org
Cc:  
Subject: Re: kern/127316: commit references a PR
Date: Sun,  6 Sep 2009 14:23:36 +0000 (UTC)

 Author: mav
 Date: Sun Sep  6 14:23:26 2009
 New Revision: 196893
 URL: http://svn.freebsd.org/changeset/base/196893
 
 Log:
   Remove constraint, requiring request data to fulfill controller's alignment
   requirements. It is busdma task, to manage proper alignment by loading
   data to bounce buffers.
   
   PR:		kern/127316
   Reviewed by:	current@
   Tested by:	Ryan Rogers
 
 Modified:
   head/sys/dev/ata/ata-dma.c
 
 Modified: head/sys/dev/ata/ata-dma.c
 ==============================================================================
 --- head/sys/dev/ata/ata-dma.c	Sun Sep  6 14:05:01 2009	(r196892)
 +++ head/sys/dev/ata/ata-dma.c	Sun Sep  6 14:23:26 2009	(r196893)
 @@ -272,10 +272,10 @@ ata_dmaload(struct ata_request *request,
  		      "FAILURE - zero length DMA transfer attempted\n");
  	return EIO;
      }
 -    if (((uintptr_t)(request->data) & (ch->dma.alignment - 1)) ||
 -	(request->bytecount & (ch->dma.alignment - 1))) {
 +    if (request->bytecount & (ch->dma.alignment - 1)) {
  	device_printf(request->dev,
 -		      "FAILURE - non aligned DMA transfer attempted\n");
 +		      "FAILURE - odd-sized DMA transfer attempt %d %% %d\n",
 +		      request->bytecount, ch->dma.alignment);
  	return EIO;
      }
      if (request->bytecount > ch->dma.max_iosize) {
 _______________________________________________
 svn-src-all@freebsd.org mailing list
 http://lists.freebsd.org/mailman/listinfo/svn-src-all
 To unsubscribe, send any mail to "svn-src-all-unsubscribe@freebsd.org"