Date: Sat, 21 May 2016 11:43:58 +0000 From: Alexey Dokuchaev <danfe@FreeBSD.org> To: marino@freebsd.org Cc: Ed Maste <emaste@freebsd.org>, Baptiste Daroussin <bapt@freebsd.org>, ports-committers@freebsd.org, svn-ports-all@freebsd.org, svn-ports-head@freebsd.org Subject: Re: svn commit: r415078 - in head: . Mk Message-ID: <20160521114358.GC624@FreeBSD.org> In-Reply-To: <364d3d9f-63ff-18c8-c730-a11c57dc0673@marino.st> References: <201605121820.u4CIKROJ004026@repo.freebsd.org> <20160513160151.GA30219@FreeBSD.org> <20160513182837.GF49383@ivaldir.etoilebsd.net> <20160513201919.GA48945@FreeBSD.org> <CAPyFy2A9L1cCikOrgBAWUo0GTCLJ4EgzqukhobaJp%2BZqv7_SpQ@mail.gmail.com> <20160519122306.GA24015@FreeBSD.org> <20160521112728.GA624@FreeBSD.org> <364d3d9f-63ff-18c8-c730-a11c57dc0673@marino.st>
next in thread | previous in thread | raw e-mail | index | archive | help
On Sat, May 21, 2016 at 01:33:36PM +0200, John Marino wrote: > On 5/21/2016 1:27 PM, Alexey Dokuchaev wrote: > > On Thu, May 19, 2016 at 12:23:06PM +0000, Alexey Dokuchaev wrote: > >> ... > >> I'm still not convinced though, sorry. Ports tree can be obtained by > >> a number of means, but this new ugly TIMESTAMP thingy is added for a > >> very specific usecase, and there should be no problem to require that > >> for that particular usecase, exported ports tree must have its files' > >> mtimes correctly set. (If svn/git/hg are not setting right mtimes on > >> export, they should be fixed.) It looks more like quick'n'dirty hack > >> rather than thoroughly thought-out solution. > > > > Given lack of replies, I guess I'd have to elaborate a bit on problems with > > TIMESTAMP and why I'm against it. > > > > 1. It does not line up with distinfo format... > > 2. It is not needed even if ports repo is obtained as tarball... > > Maybe it could/should be implemented as a makefile variable instead? > > e.g. REP_TIMESTAMP= > > Just a suggestion. I don't disagree with you. While still hackish, it's a *lot* less ugly and bogus as tainting distinfo. (New variable in Makefile is OK because that's what Makefiles are made of: variables, targets, and recipes. Adding TIMESTAMP to distinfo is NOT OK because distinfo describes port's distfiles in a form of FOO(), BAR(), ... values per each distfile.) ./danfe
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20160521114358.GC624>