From owner-cvs-all Mon Nov 19 12: 3:20 2001 Delivered-To: cvs-all@freebsd.org Received: from mail.musha.org (daemon.musha.org [61.122.44.178]) by hub.freebsd.org (Postfix) with ESMTP id 4EC9B37B42A; Mon, 19 Nov 2001 12:03:11 -0800 (PST) Received: from archon.local.idaemons.org (archon.local.idaemons.org [192.168.1.32]) by mail.musha.org (Postfix) with ESMTP id 10C384D81C; Tue, 20 Nov 2001 05:03:10 +0900 (JST) Date: Tue, 20 Nov 2001 05:03:10 +0900 Message-ID: <86itc68r5t.wl@archon.local.idaemons.org> From: "Akinori MUSHA" To: Brian Somers Cc: cvs-committers@FreeBSD.org, cvs-all@FreeBSD.org Subject: Re: cvs commit: src/share/man/man1 builtin.1 src/bin/sh Makefile builtins.def sh.1 src/bin/test test.1 test.c In-Reply-To: <200111191830.fAJIUqv15801@hak.lan.Awfulhak.org> References: <200111171910.fAHJABJ92986@freefall.freebsd.org> <200111191830.fAJIUqv15801@hak.lan.Awfulhak.org> User-Agent: Wanderlust/2.7.5 (Too Funky) SEMI/1.14.3 (Ushinoya) LIMIT/1.14.7 (Fujiidera) APEL/10.3 MULE XEmacs/21.1 (patch 14) (Cuyahoga Valley) (i386--freebsd) Organization: Associated I. Daemons X-PGP-Public-Key: finger knu@FreeBSD.org X-PGP-Fingerprint: 081D 099C 1705 861D 4B70 B04A 920B EFC7 9FD9 E1EE MIME-Version: 1.0 (generated by SEMI 1.14.3 - "Ushinoya") Content-Type: text/plain; charset=US-ASCII Sender: owner-cvs-all@FreeBSD.ORG Precedence: bulk List-ID: List-Archive: (Web Archive) List-Help: (List Instructions) List-Subscribe: List-Unsubscribe: X-Loop: FreeBSD.ORG At Mon, 19 Nov 2001 18:30:52 +0000, Brian Somers wrote: > This breaks sh: > > $ echo "program-not-found; test" | sh > > When testcmd() is given an argv[] of { "test", NULL } *and* an error > has occurred, things go pear shaped. Thanks for catching it! Actually, even this: $ sh -c 'ls; test' coredumped. I found it to be a longstanding bug of test(1) which had never been exposed, and fixed it by adding an argc/argv boundary check. -- / /__ __ Akinori.org / MUSHA.org / ) ) ) ) / FreeBSD.org / Ruby-lang.org Akinori MUSHA aka / (_ / ( (__( @ iDaemons.org / and.or.jp "Somewhere out of a memory.. of lighted streets on quiet nights.." To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe cvs-all" in the body of the message