Date: Tue, 11 Jan 2022 00:06:23 +0100 From: Stefan Esser <se@FreeBSD.org> To: Brooks Davis <brooks@freebsd.org> Cc: ports-committers@FreeBSD.org, dev-commits-ports-all@FreeBSD.org, dev-commits-ports-main@FreeBSD.org Subject: Re: git: bcaf25a8c804 - main - Fix CONFLICTS entries of multiple ports Message-ID: <681cf997-4065-ff1b-f55f-c06c82a17ca2@FreeBSD.org> In-Reply-To: <20220110221031.GA98055@spindle.one-eyed-alien.net> References: <202201101516.20AFGNau035475@gitrepo.freebsd.org> <20220110221031.GA98055@spindle.one-eyed-alien.net>
next in thread | previous in thread | raw e-mail | index | archive | help
This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --------------QveJN6ZFaOKKItl6wo2XfB9U Content-Type: multipart/mixed; boundary="------------L0vOgEvwAf2QMN2wWj06QYpA"; protected-headers="v1" From: Stefan Esser <se@FreeBSD.org> To: Brooks Davis <brooks@freebsd.org> Cc: ports-committers@FreeBSD.org, dev-commits-ports-all@FreeBSD.org, dev-commits-ports-main@FreeBSD.org Message-ID: <681cf997-4065-ff1b-f55f-c06c82a17ca2@FreeBSD.org> Subject: Re: git: bcaf25a8c804 - main - Fix CONFLICTS entries of multiple ports References: <202201101516.20AFGNau035475@gitrepo.freebsd.org> <20220110221031.GA98055@spindle.one-eyed-alien.net> In-Reply-To: <20220110221031.GA98055@spindle.one-eyed-alien.net> --------------L0vOgEvwAf2QMN2wWj06QYpA Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable >Am 10.01.22 um 23:10 schrieb Brooks Davis: > On Mon, Jan 10, 2022 at 03:16:23PM +0000, Stefan Esser wrote: >> The branch main has been updated by se: [...] > The devel/llvm-devel port change (truncated in the email) contains: >=20 > +CONFLICTS_INSTALL=3D llvm-devel >=20 > This confuses me. Why are we adding a self-conflict? This line is actually incomplete, I'll fix it. It should read: CONFLICTS_INSTALL=3D llvm-devel llvm-devel-lite There are 2 flavors, and the resulting packages contain identically named files. But due to the "same origin exclusion" no conflict will be detected, anyway, until my review D31151 https://reviews.freebsd.org/D31151 is finally reviewed and hopefully accepted. It fixes a feature from the time when different flavors could result in identical package base names (e.g. a py- prefix and not py38- as has long been enforced for all flavored ports). Currently flavors between different flavors are defined with much effort (see the devel/git example in D31151), but completely useless, since they are then ignored. With D31151 the 2 flavors of this port would correctly be detected as conflicting with each other, and that is important if such a port is used as a dependency. See PR 250335 for an issue this causes: https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=3D250335 Here the dependency on git-lite in one port with git already installed caused an attempt to install git-lite, too, with the conflict only being detected at install time. The conflicts check in the ports framework ignored this conflict despite the CONFLICTS entry, since both git and git-lite share the same origin. Regards, STefan --------------L0vOgEvwAf2QMN2wWj06QYpA-- --------------QveJN6ZFaOKKItl6wo2XfB9U Content-Type: application/pgp-signature; name="OpenPGP_signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="OpenPGP_signature" -----BEGIN PGP SIGNATURE----- wsB5BAABCAAjFiEEo3HqZZwL7MgrcVMTR+u171r99UQFAmHcu+8FAwAAAAAACgkQR+u171r99UR0 wAf+I0b0s3wUg/nP0kU3MnpvEd9w9xsuilWPJ6N3VxRm5/f1YO3VSgJGRVF7bKQUyi3sDMWn8l6Z 7vNzZ/swweGuRXqFe/Syeu1mEw7SaMDiclYiKUKTZ4JNGQRCJggBRFqcG2iAt1sQjSbPSm5CgHOU CvulE7gJvFyBqRdCA3e2tB/HWyaMfMxV4vy3pk+V289RGqH5HG2OWQiYg9GpFE8iT9nTp6bNu27w wt6qH90NQzIV/+3FJW8mVTi25wzI2JfAfl4pZmTMQe+QE/UWSqXDwXyJpIuxMnL5TS5Ylf1Fhf4y WDxYm6xuyGEs1tioI3L8zaFT8ZEtu0ffpUG+TcpfdA== =I5gc -----END PGP SIGNATURE----- --------------QveJN6ZFaOKKItl6wo2XfB9U--
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?681cf997-4065-ff1b-f55f-c06c82a17ca2>