From owner-svn-src-all@freebsd.org Wed Mar 8 21:57:35 2017 Return-Path: Delivered-To: svn-src-all@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id 346EBD03B52; Wed, 8 Mar 2017 21:57:35 +0000 (UTC) (envelope-from yaneurabeya@gmail.com) Received: from mail-pg0-x244.google.com (mail-pg0-x244.google.com [IPv6:2607:f8b0:400e:c05::244]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (Client CN "smtp.gmail.com", Issuer "Google Internet Authority G2" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 09DE31044; Wed, 8 Mar 2017 21:57:34 +0000 (UTC) (envelope-from yaneurabeya@gmail.com) Received: by mail-pg0-x244.google.com with SMTP id 25so4589042pgy.3; Wed, 08 Mar 2017 13:57:34 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=subject:mime-version:from:in-reply-to:date:cc:message-id:references :to; bh=YplC7S+W5c4bPyn9ZwQyZ/FkqEeFEMUbM+PnBePeA80=; b=fT6D7nu9wMtLNfERjTlTmykuRJBYkOmqvNxlk3HUJZa4syaNm1I/7/VPjnTI8+hjzH efVOVyXBHBeToGrHofIOSsurV6GIPJbU2ZZHcIaHE2L9r91BYv5nER6pCJR23RTs6JvI yXtaKS8Tue7aR6FXdTQDnnpmsWENQTGFKAPQTE7ECaCVDL1fKO2DdI3KWMY687u/UU+V 31fMuC4jVzQoDK/Y2obWc9mHRQh1TFrZY14iUlFGbg0S8PoCImj6TmXUAfnoVcgBDQWi 90spN/3w/syKId9O/MWyTP5FFkqJXdb6+7RVE1xYIiR52TD/V80djsDQoo5+cVArJUNV LDLg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:mime-version:from:in-reply-to:date:cc :message-id:references:to; bh=YplC7S+W5c4bPyn9ZwQyZ/FkqEeFEMUbM+PnBePeA80=; b=K2n0SU2JRseJee+N05J8K5lZLNw5Tr5uif6Pmbt5IMHq+gHBH4kTWZVFKOliipTHcw MouhpEyOxPae6J2iOx96CnJb+IZlnxwbt1Hyb9eAko7nk4S+qtRYTPuTg0UM5QaatvAx XgOOOSgdPe4je+bgbuuOARYOKGBKUzqf10lRwpHlg4HRRARABw+cuUkdmOIP6cmqWOzT J1Tn0aXu5qXvD2bMCDbWMZb+HASpmCIcGTtBIC2JGspsfHh2gQgHTaNl2zPLk78J438y WuStYBX4v2ky4voLNH9Ya/orvqNTJmVs9P5VhI++jxwVu1eZpUauWjwyGXNZLig5f5U2 GjDA== X-Gm-Message-State: AMke39m6bswoP9bXzjNLATaCw7vfayHxJWmb4qu5P8WezPBbl5XUl54mCd+v1rLNgZBhbg== X-Received: by 10.99.0.65 with SMTP id 62mr9734296pga.114.1489010254295; Wed, 08 Mar 2017 13:57:34 -0800 (PST) Received: from pinklady.local (c-73-19-52-228.hsd1.wa.comcast.net. [73.19.52.228]) by smtp.gmail.com with ESMTPSA id s26sm8064234pge.33.2017.03.08.13.57.33 (version=TLS1 cipher=ECDHE-RSA-AES128-SHA bits=128/128); Wed, 08 Mar 2017 13:57:33 -0800 (PST) Subject: Re: svn commit: r314862 - head/sys/modules/qlxgbe Mime-Version: 1.0 (Mac OS X Mail 9.3 \(3124\)) Content-Type: multipart/signed; boundary="Apple-Mail=_139152D0-5504-4E01-B805-BE1501A90845"; protocol="application/pgp-signature"; micalg=pgp-sha512 X-Pgp-Agent: GPGMail From: "Ngie Cooper (yaneurabeya)" In-Reply-To: <20170308215514.GQ1044@FreeBSD.org> Date: Wed, 8 Mar 2017 13:57:32 -0800 Cc: Andriy Gapon , src-committers@FreeBSD.org, svn-src-all@FreeBSD.org, svn-src-head@FreeBSD.org Message-Id: References: <201703071543.v27FhnoL024242@repo.freebsd.org> <20170307221733.GN1044@FreeBSD.org> <70fcdcf4-cfa5-2382-ea60-55ac1a91e06b@FreeBSD.org> <20170308215514.GQ1044@FreeBSD.org> To: Gleb Smirnoff X-Mailer: Apple Mail (2.3124) X-BeenThere: svn-src-all@freebsd.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: "SVN commit messages for the entire src tree \(except for " user" and " projects" \)" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 08 Mar 2017 21:57:35 -0000 --Apple-Mail=_139152D0-5504-4E01-B805-BE1501A90845 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset=utf-8 > On Mar 8, 2017, at 13:55, Gleb Smirnoff wrote: >=20 > On Wed, Mar 08, 2017 at 01:00:30AM +0200, Andriy Gapon wrote: > A> On 08/03/2017 00:17, Gleb Smirnoff wrote: > A> > On Tue, Mar 07, 2017 at 03:43:49PM +0000, Andriy Gapon wrote: > A> > A> Author: avg > A> > A> Date: Tue Mar 7 15:43:49 2017 > A> > A> New Revision: 314862 > A> > A> URL: https://svnweb.freebsd.org/changeset/base/314862 > A> > A> > A> > A> Log: > A> > A> qlxgbe: add GCC_MS_EXTENSIONS to CFLAGS to make old base GCC = happy > A> > A> > A> > A> The module uses unnamed structure and union fields and base = GCC in > A> > A> stable/10 doesn't like it. > A> > A> I think that that is a C11 feature, so it is courteous of = more modern > A> > A> compilers to not complain about it when compiling in C99 = mode. > A> > > A> > There are a lot of code in kernel, that uses anonymous structs = and unions. > A> > This feature is enabled globally. Why does this module need = special treatment? > A> > A> That's a good question and I don't have a good answer to it. > A> All I can say is that a GCC build of GENERIC and modules failed in = that fashion > A> only for this module (in stable/10). > A> Maybe I described the problem incorrectly. Then, a proper = explanation is welcome. >=20 > In head this is fixed properly: >=20 > https://svnweb.freebsd.org/base?view=3Drevision&revision=3D278913 >=20 > Can you please move your fix to stable/10 and revert it in head? I understand there might be conflicts, but wouldn=E2=80=99t it be better = to revert and MFC the change you committed to ^/head (which is already = in ^/stable/11) to ^/stable/10? Thanks, -Ngie --Apple-Mail=_139152D0-5504-4E01-B805-BE1501A90845 Content-Transfer-Encoding: 7bit Content-Disposition: attachment; filename=signature.asc Content-Type: application/pgp-signature; name=signature.asc Content-Description: Message signed with OpenPGP using GPGMail -----BEGIN PGP SIGNATURE----- Comment: GPGTools - https://gpgtools.org iQIcBAEBCgAGBQJYwH5MAAoJEPWDqSZpMIYVlNcQAIetsCUhiDb5d1thCN3adUOq XGpgPDxLLkXVVthmcGcJFowvUya0wzDLExxa2AzhXxXQmgDbwHHuglLStEBuOQkd C0FvVcF+aFydMoVuWQGZLGak+2bD9zTNh1wddr46CDSDLW4zS7kj+LUF5N+pHck1 VIL28UBD0T0NvKm11B1B6sD0DOpdM8+b8TONiNrzPwbCur0EEXpOB2CEfhVbcgTH 2SVO0lqLxkiYSJQuImWwwAKAR7M0rJZY3psbEYGJ4L/27gzm0U1GUgPxfIwkRdv3 KSWH+zFdbY9dLAoSLnnGq7evAfsfpwOFNlEjcN68nnE7g08WUIdOWsZxQxnXopas uBvqRpdXmFh0n46iY0iZQVTJKRkx8d/H1QSI0yLbujI+Mn4cqI0Twf0O9NfPw2Z0 ur3o3EqXXbC/5uzYLEOHQxhVHLgxE1BT7mv5mGtau8teTSs7G4F0L0X5qYjTYb8S eU0iwOKA6Oq00vdMTM5LbhwsbLwSBvOrquxsuNTi71QNfo41xaEG50t8WhIHU53H jUKBvCubRdaSU1IH/KScbEKW5gSxzFDacd06qa0u+UPsUUhXNf0d2b/fSfpEPDnX P4vPd4Fgq4hYUYcXlqRJIpsCXAPFegorYI+pCktwS+6e7ud/x1/wZ/RhKDRI4ln8 ZCM7xxPDHKU0d846DEVI =EkqE -----END PGP SIGNATURE----- --Apple-Mail=_139152D0-5504-4E01-B805-BE1501A90845--