From owner-freebsd-bugs@FreeBSD.ORG Sun Nov 8 12:20:04 2009 Return-Path: Delivered-To: freebsd-bugs@hub.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id D00901065672 for ; Sun, 8 Nov 2009 12:20:04 +0000 (UTC) (envelope-from gnats@FreeBSD.org) Received: from freefall.freebsd.org (freefall.freebsd.org [IPv6:2001:4f8:fff6::28]) by mx1.freebsd.org (Postfix) with ESMTP id 92BA68FC14 for ; Sun, 8 Nov 2009 12:20:04 +0000 (UTC) Received: from freefall.freebsd.org (localhost [127.0.0.1]) by freefall.freebsd.org (8.14.3/8.14.3) with ESMTP id nA8CK4Be064439 for ; Sun, 8 Nov 2009 12:20:04 GMT (envelope-from gnats@freefall.freebsd.org) Received: (from gnats@localhost) by freefall.freebsd.org (8.14.3/8.14.3/Submit) id nA8CK4SK064438; Sun, 8 Nov 2009 12:20:04 GMT (envelope-from gnats) Resent-Date: Sun, 8 Nov 2009 12:20:04 GMT Resent-Message-Id: <200911081220.nA8CK4SK064438@freefall.freebsd.org> Resent-From: FreeBSD-gnats-submit@FreeBSD.org (GNATS Filer) Resent-To: freebsd-bugs@FreeBSD.org Resent-Reply-To: FreeBSD-gnats-submit@FreeBSD.org, soulcatcher Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id AD8F11065672 for ; Sun, 8 Nov 2009 12:19:32 +0000 (UTC) (envelope-from nobody@FreeBSD.org) Received: from www.freebsd.org (www.freebsd.org [IPv6:2001:4f8:fff6::21]) by mx1.freebsd.org (Postfix) with ESMTP id 9CD5A8FC21 for ; Sun, 8 Nov 2009 12:19:32 +0000 (UTC) Received: from www.freebsd.org (localhost [127.0.0.1]) by www.freebsd.org (8.14.3/8.14.3) with ESMTP id nA8CJWJK014324 for ; Sun, 8 Nov 2009 12:19:32 GMT (envelope-from nobody@www.freebsd.org) Received: (from nobody@localhost) by www.freebsd.org (8.14.3/8.14.3/Submit) id nA8CJWgH014323; Sun, 8 Nov 2009 12:19:32 GMT (envelope-from nobody) Message-Id: <200911081219.nA8CJWgH014323@www.freebsd.org> Date: Sun, 8 Nov 2009 12:19:32 GMT From: soulcatcher To: freebsd-gnats-submit@FreeBSD.org X-Send-Pr-Version: www-3.1 Cc: Subject: kern/140386: segfault in fmtmsg(3) with MM_NULLACT X-BeenThere: freebsd-bugs@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: Bug reports List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sun, 08 Nov 2009 12:20:04 -0000 >Number: 140386 >Category: kern >Synopsis: segfault in fmtmsg(3) with MM_NULLACT >Confidential: no >Severity: non-critical >Priority: low >Responsible: freebsd-bugs >State: open >Quarter: >Keywords: >Date-Required: >Class: sw-bug >Submitter-Id: current-users >Arrival-Date: Sun Nov 08 12:20:04 UTC 2009 >Closed-Date: >Last-Modified: >Originator: soulcatcher >Release: FreeBSD 7.2-STABLE >Organization: >Environment: FreeBSD xxx.org 7.2-STABLE FreeBSD 7.2-STABLE #4: Sun Oct 4 19:58:35 UTC 2009 xxx.org:/usr/obj/usr/src/sys/GENERIC amd64 >Description: obvious bug in /usr/src/lib/libc/gen/fmtmsg.c >How-To-Repeat: #include int main(int argc, char * argv[]) { fmtmsg(MM_UTIL | MM_PRINT, "BSD:ls", MM_ERROR, "illegal option ‐‐ z", MM_NULLACT, "BSD:ls:001"); return 0; } gcc main.c ./a.out dumps core >Fix: Patch attached with submission follows: --- fmtmsg.c.bak 2009-11-08 15:01:29.000000000 +0300 +++ fmtmsg.c 2009-11-08 15:09:08.000000000 +0300 @@ -128,7 +128,7 @@ size += strlen(sevname); if (text != MM_NULLTXT) size += strlen(text); - if (text != MM_NULLACT) + if (act != MM_NULLACT) size += strlen(act); if (tag != MM_NULLTAG) size += strlen(tag); >Release-Note: >Audit-Trail: >Unformatted: