From owner-freebsd-geom@FreeBSD.ORG Sun Aug 8 19:09:17 2010 Return-Path: Delivered-To: freebsd-geom@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 46972106566B for ; Sun, 8 Aug 2010 19:09:17 +0000 (UTC) (envelope-from gcubfg-freebsd-geom@m.gmane.org) Received: from lo.gmane.org (lo.gmane.org [80.91.229.12]) by mx1.freebsd.org (Postfix) with ESMTP id E88108FC1B for ; Sun, 8 Aug 2010 19:09:16 +0000 (UTC) Received: from list by lo.gmane.org with local (Exim 4.69) (envelope-from ) id 1OiBF9-0006WT-Hf for freebsd-geom@freebsd.org; Sun, 08 Aug 2010 21:09:11 +0200 Received: from 47-197.dsl.iskon.hr ([89.164.47.197]) by main.gmane.org with esmtp (Gmexim 0.1 (Debian)) id 1AlnuQ-0007hv-00 for ; Sun, 08 Aug 2010 21:09:11 +0200 Received: from ivoras by 47-197.dsl.iskon.hr with local (Gmexim 0.1 (Debian)) id 1AlnuQ-0007hv-00 for ; Sun, 08 Aug 2010 21:09:11 +0200 X-Injected-Via-Gmane: http://gmane.org/ To: freebsd-geom@freebsd.org From: Ivan Voras Date: Sun, 08 Aug 2010 21:08:58 +0200 Lines: 28 Message-ID: References: <20100808103055.GA2037@garage.freebsd.pl> Mime-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-Complaints-To: usenet@dough.gmane.org X-Gmane-NNTP-Posting-Host: 47-197.dsl.iskon.hr User-Agent: Mozilla/5.0 (Windows; U; Windows NT 6.0; en-US; rv:1.9.1.11) Gecko/20100711 Thunderbird/3.0.6 In-Reply-To: Cc: freebsd-hackers@freebsd.org, freebsd-current@freebsd.org Subject: Re: glabel "force sectorsize" patch X-BeenThere: freebsd-geom@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: GEOM-specific discussions and implementations List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sun, 08 Aug 2010 19:09:17 -0000 On 8.8.2010 14:57, Marius Nünnerich wrote: > On Sun, Aug 8, 2010 at 14:02, Ivan Voras wrote: >>>> This mechanism is a band-aid until there's a better way of dealing >>>> with 4k drives. > I do not like this at all. Even if it's just for the KISS and POLA > principles. A geom should do one thing and do it right imo. As the addition will not modify general behaviour of glabel but add a new feature (which is actually clean and trivial to implement) invisible to most of the users, I don't think either KISS nor POLA are in any danger here. I do agree that it shouldn't be glabel's job to do this but also am *very* strongly against shipping 9.0 without any support for 4k drives, and the way I've chosen is the lesser of two evils. Code and patches by others are of course welcome. I'm hoping this discussion will trigger someone with experience in the lower levels of kernel to go and finally add the drive info parsing so it gets solved the right way :) > Why not write a new geom class that does what you want? I'm not against this approach also. Technically, if we go this way, the new GEOM class will be almost a line-for-line copy-paste of glabel with this single metadata field added, so I'd rather fold it into glabel.