From owner-freebsd-bugs@FreeBSD.ORG Sun Dec 28 16:57:33 2014 Return-Path: Delivered-To: freebsd-bugs@FreeBSD.org Received: from mx1.freebsd.org (mx1.freebsd.org [8.8.178.115]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by hub.freebsd.org (Postfix) with ESMTPS id D9A8078D for ; Sun, 28 Dec 2014 16:57:33 +0000 (UTC) Received: from kenobi.freebsd.org (kenobi.freebsd.org [IPv6:2001:1900:2254:206a::16:76]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client did not present a certificate) by mx1.freebsd.org (Postfix) with ESMTPS id C12D964D47 for ; Sun, 28 Dec 2014 16:57:33 +0000 (UTC) Received: from bugs.freebsd.org ([127.0.1.118]) by kenobi.freebsd.org (8.14.9/8.14.9) with ESMTP id sBSGvXMR028525 for ; Sun, 28 Dec 2014 16:57:33 GMT (envelope-from bugzilla-noreply@freebsd.org) From: bugzilla-noreply@freebsd.org To: freebsd-bugs@FreeBSD.org Subject: [Bug 186891] [puc] [patch] MCS9922 based card not known Date: Sun, 28 Dec 2014 16:57:33 +0000 X-Bugzilla-Reason: AssignedTo X-Bugzilla-Type: changed X-Bugzilla-Watch-Reason: None X-Bugzilla-Product: Base System X-Bugzilla-Component: kern X-Bugzilla-Version: 8.4-STABLE X-Bugzilla-Keywords: X-Bugzilla-Severity: Affects Only Me X-Bugzilla-Who: greg@codeconcepts.com X-Bugzilla-Status: In Progress X-Bugzilla-Priority: Normal X-Bugzilla-Assigned-To: freebsd-bugs@FreeBSD.org X-Bugzilla-Target-Milestone: --- X-Bugzilla-Flags: X-Bugzilla-Changed-Fields: cc Message-ID: In-Reply-To: References: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Bugzilla-URL: https://bugs.freebsd.org/bugzilla/ Auto-Submitted: auto-generated MIME-Version: 1.0 X-BeenThere: freebsd-bugs@freebsd.org X-Mailman-Version: 2.1.18-1 Precedence: list List-Id: Bug reports List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sun, 28 Dec 2014 16:57:34 -0000 https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=3D186891 greg@codeconcepts.com changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |greg@codeconcepts.com --- Comment #4 from greg@codeconcepts.com --- The suggested patch seems to work for me. Card is "SYBA PCI-Express 2 Port Serial Card" (16C450/16C550 UART, with 256-byte FIFO in tx/rx for each port= .=20 Based on PR 171746, I suspect the rx FIFO is being dumbed down to 16-bytes = by ns8250_bus_probe(). FreeBSD harper 10.1-STABLE FreeBSD 10.1-STABLE #2 r276320M: Sun Dec 28 08:0= 3:01 CST 2014 root@harper:/usr/obj/usr/src/sys/HARPER amd64 $ svn diff sys/dev/uart Index: sys/dev/uart/uart_bus_pci.c =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D --- sys/dev/uart/uart_bus_pci.c (revision 276320) +++ sys/dev/uart/uart_bus_pci.c (working copy) @@ -136,6 +136,8 @@ "MosChip MCS9901 PCIe to Peripheral Controller", 0x10 }, { 0x9710, 0x9904, 0xa000, 0x1000, "MosChip MCS9904 PCIe to Peripheral Controller", 0x10 }, +{ 0x9710, 0x9922, 0xa000, 0x1000, + "MosChip MCS9922 PCIe to Peripheral Controller", 0x10 }, { 0xdeaf, 0x9051, 0xffff, 0, "Middle Digital PC Weasel Serial Port", 0x10 = }, { 0xffff, 0, 0xffff, 0, NULL, 0, 0} }; pciconf -lv output: uart2@pci0:10:0:0: class=3D0x070002 card=3D0x1000a000 chip=3D0x99229710 re= v=3D0x00 hdr=3D0x00 vendor =3D 'NetMos Technology' device =3D 'PCIe 9922 Multi-I/O Controller' class =3D simple comms subclass =3D UART uart3@pci0:10:0:1: class=3D0x070002 card=3D0x1000a000 chip=3D0x99229710 re= v=3D0x00 hdr=3D0x00 vendor =3D 'NetMos Technology' device =3D 'PCIe 9922 Multi-I/O Controller' class =3D simple comms subclass =3D UART (In reply to Marius Strobl from comment #2) > On Thu, Apr 10, 2014 at 11:26:56PM +0200, Marius Strobl wrote: > > Could you please revert your > > patch for puc(4) and test whether the attached one provies you with > > two instances of uart(4) for that card? > >=20 > > Index: uart_bus_pci.c > > =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D > > --- uart_bus_pci.c (revision 264257) > > +++ uart_bus_pci.c (working copy) > > @@ -135,6 +135,8 @@ > > "MosChip MCS9901 PCIe to Peripheral Controller", 0x10 }, > > { 0x9710, 0x9904, 0xa000, 0x1000, > > "MosChip MCS9904 PCIe to Peripheral Controller", 0x10 }, > > +{ 0x9710, 0x9922, 0x0000, 0x0000, > > + "MosChip MCS9922 PCIe to Peripheral Controller", 0x10 }, > > { 0xdeaf, 0x9051, 0xffff, 0, "Middle Digital PC Weasel Serial Port", 0= x10 }, > > { 0xffff, 0, 0xffff, 0, NULL, 0, 0} > > }; >=20 > I'm not sure whether the sub vendor and sub device IDs taken from NetBSD > actually are correct. The MCS9922 datasheet suggests that the following > should be used instead: > +{ 0x9710, 0x9922, 0xa000, 0x1000, > + "MosChip MCS9922 PCIe to Peripheral Controller", 0x10 }, >=20 > Marius --=20 You are receiving this mail because: You are the assignee for the bug.=