From owner-svn-src-all@freebsd.org Thu Aug 22 23:57:46 2019 Return-Path: Delivered-To: svn-src-all@mailman.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.nyi.freebsd.org (Postfix) with ESMTP id 3C537D5973 for ; Thu, 22 Aug 2019 23:57:46 +0000 (UTC) (envelope-from wlosh@bsdimp.com) Received: from mail-qk1-x731.google.com (mail-qk1-x731.google.com [IPv6:2607:f8b0:4864:20::731]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) server-signature RSA-PSS (4096 bits) client-signature RSA-PSS (2048 bits) client-digest SHA256) (Client CN "smtp.gmail.com", Issuer "GTS CA 1O1" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 46F1gF3bXvz446c for ; Thu, 22 Aug 2019 23:57:45 +0000 (UTC) (envelope-from wlosh@bsdimp.com) Received: by mail-qk1-x731.google.com with SMTP id m2so6756402qki.12 for ; Thu, 22 Aug 2019 16:57:45 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=bsdimp-com.20150623.gappssmtp.com; s=20150623; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=GNanXvTZBarcjme4+Gs9g+38Bam3f46t4/uSMBxwxvc=; b=n2KkZan0/GuthY+CxpMFNv29BIjyPNyVd6sppCYntRdcg7h4q70n2jtr/MRzx3ZJ3/ ivE3UppgKmLh6Ns+8c+9C00NUTW1y+fMAr/Y7heicyj1H9OuKowWmvIESpGmVMv1LXLs t1ibQkY0+OJUFnMXKVPMr/5tCnFd1uGBTo0m0o220I4/ExdmFu+hIi+p0XOv60PfYNu6 eqOOYotwBA6LBpEvZ0N5Cu7vvOwvhdg4Dx5UyiZXUPRMOjuvaEHYhJqKHuicBAzZax2I 95Qhjs3xzbxN5yj4hthA95CHxiJSz/5o/Nto3za6hkJw2UVz9Se3nMStr1nTucsLoTNb hefw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=GNanXvTZBarcjme4+Gs9g+38Bam3f46t4/uSMBxwxvc=; b=Dzqe8xLX6+Ndi6QywUmZJvjXg5H5T49Mc9leGj2oG5gaua535Lwf2Ac44bTikGJ41j POCnNOy1n0R+uo2aYfQvPf6JDkhx8Kf4dUOgDPPS/2HFiXQdjIO4ZtrFcYc6SpdVY60r S+HUpB75v7AtpJCjpAcD5T8v2tABTv3C99ywjUAHMIFJ300Xb18QK4UsRzKch0hrOXCp 4cz+cxVw1ufqSPsz22V/3HRBPlAOqueKnT0F2TbvpW5BNbS9KICruikCR5cfr3IZl26D fAxENiiekMmT6SHy1aoTR3ttArr7lMoBIVrumTaKd75MD65GncG3Hqypal9gLSx/iznd FThA== X-Gm-Message-State: APjAAAWiwAPehW9zSB0yzov/i1+H6esycdBDKU0OHpc58EpF8+B1R1wT TGAv7xQAsX9dZqrjujZfX7nQSXGUhXLI/TFn4TyWqA== X-Google-Smtp-Source: APXvYqxoZs7BMaesz+GXEDdyBoqiy3+Cq6xT4NeQn4n8/sMBZTOgNwVZVoBgui34Yxg1FgPEn3UOWBF3oxokxq79crQ= X-Received: by 2002:a05:620a:621:: with SMTP id 1mr1727018qkv.380.1566518263347; Thu, 22 Aug 2019 16:57:43 -0700 (PDT) MIME-Version: 1.0 References: <201908222112.x7MLCpbt023647@repo.freebsd.org> In-Reply-To: From: Warner Losh Date: Thu, 22 Aug 2019 17:57:32 -0600 Message-ID: Subject: Re: svn commit: r351406 - head/sys/dev/nvme To: John Baldwin Cc: Warner Losh , src-committers , svn-src-all@freebsd.org, svn-src-head@freebsd.org X-Rspamd-Queue-Id: 46F1gF3bXvz446c X-Spamd-Bar: ---- Authentication-Results: mx1.freebsd.org; dkim=pass header.d=bsdimp-com.20150623.gappssmtp.com header.s=20150623 header.b=n2KkZan0; dmarc=none; spf=none (mx1.freebsd.org: domain of wlosh@bsdimp.com has no SPF policy when checking 2607:f8b0:4864:20::731) smtp.mailfrom=wlosh@bsdimp.com X-Spamd-Result: default: False [-4.92 / 15.00]; ARC_NA(0.00)[]; NEURAL_HAM_MEDIUM(-1.00)[-1.000,0]; R_DKIM_ALLOW(-0.20)[bsdimp-com.20150623.gappssmtp.com:s=20150623]; FROM_HAS_DN(0.00)[]; TO_DN_SOME(0.00)[]; NEURAL_HAM_LONG(-1.00)[-1.000,0]; MIME_GOOD(-0.10)[multipart/alternative,text/plain]; PREVIOUSLY_DELIVERED(0.00)[svn-src-all@freebsd.org]; DMARC_NA(0.00)[bsdimp.com]; URI_COUNT_ODD(1.00)[3]; RCPT_COUNT_FIVE(0.00)[5]; TO_MATCH_ENVRCPT_SOME(0.00)[]; DKIM_TRACE(0.00)[bsdimp-com.20150623.gappssmtp.com:+]; NEURAL_HAM_SHORT(-0.99)[-0.991,0]; RCVD_IN_DNSWL_NONE(0.00)[1.3.7.0.0.0.0.0.0.0.0.0.0.0.0.0.0.2.0.0.4.6.8.4.0.b.8.f.7.0.6.2.list.dnswl.org : 127.0.5.0]; R_SPF_NA(0.00)[]; FORGED_SENDER(0.30)[imp@bsdimp.com,wlosh@bsdimp.com]; MIME_TRACE(0.00)[0:+,1:+,2:~]; IP_SCORE(-2.93)[ip: (-9.35), ipnet: 2607:f8b0::/32(-2.90), asn: 15169(-2.35), country: US(-0.05)]; ASN(0.00)[asn:15169, ipnet:2607:f8b0::/32, country:US]; FROM_NEQ_ENVFROM(0.00)[imp@bsdimp.com,wlosh@bsdimp.com]; RCVD_TLS_ALL(0.00)[]; RCVD_COUNT_TWO(0.00)[2] Content-Type: text/plain; charset="UTF-8" X-Content-Filtered-By: Mailman/MimeDel 2.1.29 X-BeenThere: svn-src-all@freebsd.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "SVN commit messages for the entire src tree \(except for " user" and " projects" \)" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 22 Aug 2019 23:57:46 -0000 On Thu, Aug 22, 2019, 3:27 PM John Baldwin wrote: > On 8/22/19 2:12 PM, Warner Losh wrote: > > Author: imp > > Date: Thu Aug 22 21:12:51 2019 > > New Revision: 351406 > > URL: https://svnweb.freebsd.org/changeset/base/351406 > > > > Log: > > We need to define version 1 of nvme, not nvme_foo. Otherwise nvd won't > > load and people who pull in nvme/nvd from modules can't load nvd.ko > > since it depends on nvme, not nvme_foo. The duplicate doesn't matter > > since kldxref properly handles that case. > > I would perhaps have put the MODULE_VERSION for nvme and its dependency > on cam into nvme.c instead of duplicating it. I think that is more > consistent > with what we have done elsewhere in the tree. > That can't be true. Doing that doesn't work. We wind up dereferencing freed memory, as we discussed on IRC. Each DRIVER_MODULE needs its own MODULE_VERSION given the current code. I'd call that a bug, but not one I could dig into today... Warner >