From owner-freebsd-stable Sun Jul 14 9:18:34 2002 Delivered-To: freebsd-stable@freebsd.org Received: from mx1.FreeBSD.org (mx1.FreeBSD.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 3758B37B400 for ; Sun, 14 Jul 2002 09:18:31 -0700 (PDT) Received: from kpt-c-24-159-35-85.chartertn.net (kpt-c-24-159-35-85.chartertn.net [24.159.35.85]) by mx1.FreeBSD.org (Postfix) with ESMTP id 5A23343E65 for ; Sun, 14 Jul 2002 09:18:30 -0700 (PDT) (envelope-from ericg@chartertn.net) Received: from zaphod (zaphod.lonesome.org [192.168.1.88]) by kpt-c-24-159-35-85.chartertn.net (8.11.6/8.11.6) with ESMTP id g6EGIOj49199; Sun, 14 Jul 2002 12:18:25 -0400 (EDT) (envelope-from ericg@chartertn.net) Message-Id: <200207141618.g6EGIOj49199@kpt-c-24-159-35-85.chartertn.net> From: "Eric Olsen" To: Ian Dowse , stable@freebsd.org Date: Sun, 14 Jul 2002 12:18:24 -0400 MIME-Version: 1.0 Subject: Re: strange ATA behavior with -STABLE Reply-To: ericg@chartertn.net References: Your message of "Thu, 11 Jul 2002 10:01:37 +0200." <20020711095747.B19121-100000@carmel.diva.nl> In-reply-to: <200207122338.aa27236@salmon.maths.tcd.ie> X-mailer: Pegasus Mail for Windows (v4.01) Content-type: text/plain; charset=US-ASCII Content-transfer-encoding: 7BIT Content-description: Mail message body Sender: owner-freebsd-stable@FreeBSD.ORG Precedence: bulk List-ID: List-Archive: (Web Archive) List-Help: (List Instructions) List-Subscribe: List-Unsubscribe: X-Loop: FreeBSD.ORG On 12 Jul 2002 at 23:38, Ian Dowse wrote: > In message <20020711095747.B19121-100000@carmel.diva.nl>, Michiel Boland > writes : >Please correct me if I'm wrong but I don't think the splx > patch does >anything to help people with broken CD-ROM drives. > > Try the following. It fixes CD-ROM drives in VMWare for me, so > there is a good chance it may help with real CD-ROM drives too. > > Sorry, I meant to try to track this down ages ago as it sounded > (and was) really easy to find, but I rarely use CD-ROM drives in > VMWare so I never got around to it. It's just a simple race where > if the completion interrupt comes in between the splx() and the > tsleep(), the tsleep will sit in "atprq" forever. Moving the splx() to > after the tsleep ensures that this can't happen. > > Ian FWIW, a quick and dirty test shows that your patch works for me on this kernel: > uname -a FreeBSD hp.lonesome.org 4.6-STABLE FreeBSD 4.6-STABLE #1: Sun Jul 14 11:34:28 EDT 2002 ericg@hp.lonesome.org:/extra/src/sys/compile/HP i386 (that was 4-STABLE as of 02 July 2002, installed from a JP snapshot) with this CDROM: > dmesg |grep acd0 acd0: CDROM at ata1-slave PIO4 > and with the following sysctl settings: > sysctl -a | egrep "\.ata" hw.ata.ata_dma: 1 hw.ata.wc: 1 hw.ata.tags: 0 hw.ata.atapi_dma: 1 (The above sysctl settings didn't help before the patch. I haven't tried to find out if they matter after the patch.) Let's hope the patch can be included in 4.6.1-RELEASE. Thanks, Ian, for some much-needed relief! Eric To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe freebsd-stable" in the body of the message