From owner-svn-src-head@FreeBSD.ORG Wed Jul 16 10:45:21 2014 Return-Path: Delivered-To: svn-src-head@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [8.8.178.115]) (using TLSv1 with cipher ADH-AES256-SHA (256/256 bits)) (No client certificate requested) by hub.freebsd.org (Postfix) with ESMTPS id 5B351909; Wed, 16 Jul 2014 10:45:21 +0000 (UTC) Received: from mail-we0-x235.google.com (mail-we0-x235.google.com [IPv6:2a00:1450:400c:c03::235]) (using TLSv1 with cipher ECDHE-RSA-RC4-SHA (128/128 bits)) (Client CN "smtp.gmail.com", Issuer "Google Internet Authority G2" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 79819292C; Wed, 16 Jul 2014 10:45:20 +0000 (UTC) Received: by mail-we0-f181.google.com with SMTP id q59so687670wes.26 for ; Wed, 16 Jul 2014 03:45:18 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=date:from:to:cc:subject:message-id:references:mime-version :content-type:content-disposition:in-reply-to:user-agent; bh=v1l2p4vx7ghAM3WDQkXVBikqv2Nsb8whtMjr7v52SlE=; b=CxsHuo9ioolSSCdUDvpvrQdho9sGdbhWmMnntkvUV3nSuyvuyMvFAlrFcJhT7GaSTH JdNlVN8DZHzkNVEqVdA7rV/gx+8G2WoD9QUK8N71HKxh02nSfIM58PU5z2d8jsNmOD0j h1AdBX5ziD2eQx8EJc0mC813xkyUQCSaVG5X9s36Xh/MRKXJsneXBVdLQRoOohOmxDLP Nnngh4gaqzTEV9Z5m2qhXUAPpEk0+8sjcRzr/sLRmAge1Q1Jys9K0gGRNjy0LN3GbSsg A9YVxSvUB4rhrCzTXeByTODDSEYmsAFc19IawEFHykjfwj4OyEs+oOq6kM3lr94MT7yj MrSQ== X-Received: by 10.180.20.112 with SMTP id m16mr12971205wie.6.1405507515606; Wed, 16 Jul 2014 03:45:15 -0700 (PDT) Received: from dft-labs.eu (n1x0n-1-pt.tunnel.tserv5.lon1.ipv6.he.net. [2001:470:1f08:1f7::2]) by mx.google.com with ESMTPSA id cx5sm38940433wjb.8.2014.07.16.03.45.14 for (version=TLSv1.2 cipher=RC4-SHA bits=128/128); Wed, 16 Jul 2014 03:45:14 -0700 (PDT) Date: Wed, 16 Jul 2014 12:45:12 +0200 From: Mateusz Guzik To: Baptiste Daroussin Subject: Re: svn commit: r268745 - in head/usr.bin: . timeout Message-ID: <20140716104512.GB17076@dft-labs.eu> References: <201407160955.s6G9taro084054@svn.freebsd.org> <20140716102908.GA17076@dft-labs.eu> <20140716103411.GH48710@ivaldir.etoilebsd.net> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <20140716103411.GH48710@ivaldir.etoilebsd.net> User-Agent: Mutt/1.5.21 (2010-09-15) Cc: svn-src-head@freebsd.org, svn-src-all@freebsd.org, src-committers@freebsd.org X-BeenThere: svn-src-head@freebsd.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: SVN commit messages for the src tree for head/-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 16 Jul 2014 10:45:21 -0000 On Wed, Jul 16, 2014 at 12:34:11PM +0200, Baptiste Daroussin wrote: > On Wed, Jul 16, 2014 at 12:29:08PM +0200, Mateusz Guzik wrote: > > On Wed, Jul 16, 2014 at 09:55:36AM +0000, Baptiste Daroussin wrote: > > > +static void > > > +usage(void) > > > +{ > > > + fprintf(stderr, "Usage: %s [--signal sig | -s sig] [--preserve-status]" > > > + " [--kill-after time | -k time] [--foreground] " > > > + " \n", getprogname()); > > > + > > > > Missing newline at the begnning. > New line at the beginning? > > static void usage(void) { fprintf(...); > > > + exit(EX_USAGE); > > > +} > > > + > > > + switch(signo) { > > > + case 0: > > > > sig 0? I doubt it is ever delivered. > > one of the tests from the GNU testsuite is passing 0 signal I even checked. The kernel is not going to deliver signal 0, so checking for it in signal handler does not seem to make sense. Does the testcaes fail without it or something? -- Mateusz Guzik