Date: Thu, 5 Jun 2008 21:31:22 +0200 From: Max Laier <max@love2party.net> To: Julian Elischer <julian@elischer.org>, Rajkumar S <rajkumars@gmail.com> Cc: freebsd-net@freebsd.org Subject: Re: anyone tried the Multi routing table code yet? Message-ID: <200806052131.23063.max@love2party.net> In-Reply-To: <483FCCBC.6040802@elischer.org> References: <483763B5.4030205@elischer.org> <64de5c8b0805300118v3874ec3bx2b2978a80bae08b8@mail.gmail.com> <483FCCBC.6040802@elischer.org>
next in thread | previous in thread | raw e-mail | index | archive | help
--Boundary-00=_L8DSIfS2qfuGi2B Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit Content-Disposition: inline On Friday 30 May 2008 11:45:32 Julian Elischer wrote: > Rajkumar S wrote: > > On Sat, May 24, 2008 at 6:09 AM, Julian Elischer <julian@elischer.org> wrote: > >> subject says it all really.. > > > > I am using pf and rtable to setfib and get an pfctl: DIOCADDRULE: > > Device busy when trying to load "pass in quick on fxp0 from any to > > any keep state rtable 1" > > I'm not really familiar with the pf syntax > as I didn't do that part of the patch (max laier (CC'd) did) > and I don't use pf. > > Max may be able to see if the patch to the pf code ahs an error. See attached - stupid error, my bad. Confirmed to work now, with limited testing, though. -- /"\ Best regards, | mlaier@freebsd.org \ / Max Laier | ICQ #67774661 X http://pf4freebsd.love2party.net/ | mlaier@EFnet / \ ASCII Ribbon Campaign | Against HTML Mail and News --Boundary-00=_L8DSIfS2qfuGi2B Content-Type: message/rfc822 Content-Transfer-Encoding: 7bit Content-Description: Max Laier <mlaier@freebsd.org>: svn commit: r179570 - head/sys/contrib/pf/net Content-Disposition: inline; filename*= Return-Path: <owner-src-committers@FreeBSD.org> X-Spam-Checker-Version: SpamAssassin 3.2.4 (2008-01-01) on router.laiers.local X-Spam-Level: X-Spam-Status: No, score=-5.2 required=5.0 tests=AWL,BAYES_00, RCVD_IN_DNSWL_MED,SPF_PASS autolearn=ham version=3.2.4 Delivered-To: mlaier@vampire.homelinux.org Received: (qmail 74745 invoked by alias); 5 Jun 2008 19:28:30 -0000 Delivered-To: max@vampire.homelinux.org Received: (qmail 74742 invoked from network); 5 Jun 2008 19:28:30 -0000 Received: from mx2.freebsd.org (69.147.83.53) by dslb-088-066-027-213.pools.arcor-ip.net with SMTP; 5 Jun 2008 19:28:30 -0000 Received: from hub.freebsd.org (hub.freebsd.org [IPv6:2001:4f8:fff6::36]) by mx2.freebsd.org (Postfix) with ESMTP id 7FAFB178023 for <max@vampire.homelinux.org>; Thu, 5 Jun 2008 19:30:26 +0000 (UTC) (envelope-from owner-src-committers@FreeBSD.org) Received: by hub.freebsd.org (Postfix) id 6C09510656AD; Thu, 5 Jun 2008 19:30:25 +0000 (UTC) Delivered-To: mlaier@freebsd.org Received: by hub.freebsd.org (Postfix, from userid 538) id 98D4F106567C; Thu, 5 Jun 2008 19:30:21 +0000 (UTC) Delivered-To: src-committers@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 88FF71065678 for <src-committers@freebsd.org>; Thu, 5 Jun 2008 19:30:20 +0000 (UTC) (envelope-from mlaier@FreeBSD.org) Received: from svn.freebsd.org (svn.freebsd.org [IPv6:2001:4f8:fff6::2c]) by mx1.freebsd.org (Postfix) with ESMTP id 7E8A48FC12 for <src-committers@freebsd.org>; Thu, 5 Jun 2008 19:30:20 +0000 (UTC) (envelope-from mlaier@FreeBSD.org) Received: from svn.freebsd.org (localhost [127.0.0.1]) by svn.freebsd.org (8.14.2/8.14.2) with ESMTP id m55JUKSJ080639 for <src-committers@freebsd.org>; Thu, 5 Jun 2008 19:30:20 GMT (envelope-from mlaier@svn.freebsd.org) Received: (from mlaier@localhost) by svn.freebsd.org (8.14.2/8.14.2/Submit) id m55JUKb5080638 for src-committers@freebsd.org; Thu, 5 Jun 2008 19:30:20 GMT (envelope-from mlaier@svn.freebsd.org) Message-Id: <200806051930.m55JUKb5080638@svn.freebsd.org> From: Max Laier <mlaier@FreeBSD.org> Date: Thu, 5 Jun 2008 19:30:20 +0000 (UTC) To: src-committers@freebsd.org Subject: svn commit: r179570 - head/sys/contrib/pf/net MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Sender: owner-src-committers@FreeBSD.org Precedence: bulk X-Loop: FreeBSD.ORG X-Virus-Status: No X-Virus-Checker-Version: clamassassin 1.2.4 with clamdscan / ClamAV 0.93/7373/Thu Jun 5 18:55:14 2008 X-Length: 3606 X-UID: 74068 Author: mlaier Date: Thu Jun 5 19:30:20 2008 New Revision: 179570 URL: http://svn.freebsd.org/changeset/base/179570 Log: Fix range check for rtable id. Modified: head/sys/contrib/pf/net/pf_ioctl.c Modified: head/sys/contrib/pf/net/pf_ioctl.c ============================================================================== --- head/sys/contrib/pf/net/pf_ioctl.c Thu Jun 5 19:01:31 2008 (r179569) +++ head/sys/contrib/pf/net/pf_ioctl.c Thu Jun 5 19:30:20 2008 (r179570) @@ -1532,7 +1532,7 @@ } #ifdef __FreeBSD__ /* ROUTEING */ - if (rule->rtableid > 0 && rule->rtableid < rt_numfibs) + if (rule->rtableid > 0 && rule->rtableid > rt_numfibs) #else if (rule->rtableid > 0 && !rtable_exists(rule->rtableid)) #endif @@ -1795,7 +1795,7 @@ if (newrule->rtableid > 0 && #ifdef __FreeBSD__ /* ROUTING */ - newrule->rtableid < rt_numfibs) + newrule->rtableid > rt_numfibs) #else !rtable_exists(newrule->rtableid)) #endif --Boundary-00=_L8DSIfS2qfuGi2B--
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?200806052131.23063.max>