From owner-freebsd-ports@FreeBSD.ORG  Mon Jul 28 13:09:36 2003
Return-Path: <owner-freebsd-ports@FreeBSD.ORG>
Delivered-To: freebsd-ports@freebsd.org
Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125])
	by hub.freebsd.org (Postfix) with ESMTP id 1BA8737B401
	for <ports@freebsd.org>; Mon, 28 Jul 2003 13:09:36 -0700 (PDT)
Received: from graf.pompo.net (lns-th2-2f-81-56-186-139.adsl.proxad.net
	[81.56.186.139])
	by mx1.FreeBSD.org (Postfix) with ESMTP id E00CB43F93
	for <ports@freebsd.org>; Mon, 28 Jul 2003 13:09:32 -0700 (PDT)
	(envelope-from thierry@pompo.net)
Received: by graf.pompo.net (Postfix, from userid 1001)
	id 6C27576C5; Mon, 28 Jul 2003 22:02:50 +0200 (CEST)
Date: Mon, 28 Jul 2003 22:02:50 +0200
From: Thierry Thomas <thierry@pompo.net>
To: FreeBSD-ports <ports@freebsd.org>
Message-ID: <20030728200250.GC3905@graf.pompo.net>
Mail-Followup-To: FreeBSD-ports <ports@freebsd.org>,
	Mathieu Arnold <mat@mat.cc>
Mime-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
X-Face: (hRbQnK~Pt7$ct`!fupO(`y_WL4^-Iwn4@ly-.,[4xC4xc;
	y=\ipKMNm<1J>lv@PP~7Z<.t KjAnXLs:
User-Agent: Mutt/1.4.1i
X-Operating-System: FreeBSD 4.8-STABLE i386
Organization: Kabbale Eros
X-PGP: 0xC71405A2
cc: Mathieu Arnold <mat@mat.cc>
Subject: Libtoolize: where? Is it possible to rewrite configure-message?
X-BeenThere: freebsd-ports@freebsd.org
X-Mailman-Version: 2.1.1
Precedence: list
List-Id: Porting software to FreeBSD <freebsd-ports.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-ports>,
	<mailto:freebsd-ports-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/freebsd-ports>
List-Post: <mailto:freebsd-ports@freebsd.org>
List-Help: <mailto:freebsd-ports-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-ports>,
	<mailto:freebsd-ports-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Mon, 28 Jul 2003 20:09:36 -0000

Hello,

I have a problem with the port www/tidy-lib (slave port of
www/tidy-devel with defined WITH_SHLIB).

It required the sequence libtoolize & aclocal, and in the current port,
USE_AUTOMAKE_VER=15 is defined, and it is executed during post-patch:

post-patch:
.if !defined(WITH_SHLIB)
	@${CP} ${WRKSRC}/build/gmake/Makefile ${WRKSRC}
.else
	@${CP} -R -f ${WRKSRC}/build/gnuauto/* ${WRKSRC}
	(cd ${WRKSRC}	\
	&& ${LIBTOOLIZE} --force --copy	\
	&& ${ACLOCAL})
.endif

It kind-of-works, and even builds on Bento, but this is not
bullet-proof: Mathieu Arnold has reported a problem on a machine without
automake / aclocal. USE_AUTOMAKE produces a build-depends for
devel/automake, but the depends are brough in after post-patch, and it
aborts because aclocal is not found.

If I split this target and move (libtoolize & aclocal) to pre-configure,
this is too late: it must be somewhere between build-depends and
patch-libtool.

The /right way/ would be too introduce a new target do-libtoolize in
bsd.port.mk, but libtoolize is not used by a lot of ports.

The following patch works, but I don't know if it is legitimate to
rewrite configure-message?

--- tidy-devel.diff begins here ---
--- www/tidy-devel/Makefile.orig	Fri Jul 25 21:26:03 2003
+++ www/tidy-devel/Makefile	Sat Jul 26 23:01:12 2003
@@ -55,9 +55,14 @@
 	@${CP} ${WRKSRC}/build/gmake/Makefile ${WRKSRC}
 .else
 	@${CP} -R -f ${WRKSRC}/build/gnuauto/* ${WRKSRC}
+.endif
+
+configure-message:
+.if defined(WITH_SHLIB)
 	(cd ${WRKSRC}	\
 	&& ${LIBTOOLIZE} --force --copy	\
 	&& ${ACLOCAL})
+	@${ECHO_MSG} "===>  Configuring for ${PKGNAME}"
 .endif
 
 pre-install:
--- tidy-devel.diff ends here ---

Comments and better ideas are welcome!
-- 
Th. Thomas.