From nobody Sun Mar 1 19:31:33 2026 X-Original-To: dev-commits-src-all@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4fPByH03L8z6TXrG; Sun, 01 Mar 2026 19:31:35 +0000 (UTC) (envelope-from des@freebsd.org) Received: from smtp.freebsd.org (smtp.freebsd.org [IPv6:2610:1c1:1:606c::24b:4]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "smtp.freebsd.org", Issuer "R13" (not verified)) by mx1.freebsd.org (Postfix) with ESMTPS id 4fPByG6V2Zz3v2M; Sun, 01 Mar 2026 19:31:34 +0000 (UTC) (envelope-from des@freebsd.org) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1772393494; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=ZDQywyY6j3doTdwZ7f5PpbeuFsvuqCX2YtJ8U4WyOno=; b=AtH4jWG0VZHAku1T9SuSC/hDpWx4Yfnv0YCjnxPFsSZz0UEMn13bKPCriM/X4h9nhr/MSh 5EN6M691IaWBwEhIoiBWE/av+w4+woTEYwpS9OAZku79ICOC/Cu6qjd4HAUU4wG3WECkoT CeNF8PH2DcJNgQEruLz/6CytfD7D3UUzkudBKyQD8/0+M9q3cYtcpyHwfpEZsQ/z7qZO8Z 7JUVdxYqBk7UGsbI44u4zTO+CX3o8fFGJe1GdrNGA03K3eOwQIt23D8pBzYpgegwLkquHC O2fa/twumb2AAH+xmIpdDTuoxDuYIJSIYbyEg/tOeKNyCPM/txqhKRoh0mit7Q== ARC-Seal: i=1; s=dkim; d=freebsd.org; t=1772393494; a=rsa-sha256; cv=none; b=JHjpmOx+cmS6DazXGfk4s5eHssSLAVRmh/+STbHxC8Y6NK4ONLyu/asLscsJGg5RP1GWG4 a9874hFJ2TPDxOax/GRwNQ6nLEUknaqCFsYZTB5XwXrOPTPq3d1g9Km1TRtPeL8F+XM8UB JhYyTidvC288zQQTYJNK3+ubiLr0e47nhOLfrbIFoXg8DJ78xeEWY4RXeCn5EcP0NXTjwJ XIkjti8VQdnZJRXX3E8OqCc3i2w4y1z2Rjug/wibZTFOBBLoCvdGzIEGLoEZyIKgVv8NDu Nnx5YdIt9gnLJXygNMrvm7ackVLA70Tq3Q9iZqPY5Umfpb6jFWoJ9QX5Wn4Bww== ARC-Authentication-Results: i=1; mx1.freebsd.org; none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1772393494; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=ZDQywyY6j3doTdwZ7f5PpbeuFsvuqCX2YtJ8U4WyOno=; b=whZH2YZEKV1TrkD/qpsjO6wATqfN/DUD9tStRFKISFzT9BUORTcf6iE51VVAvNdXKaNLCX yR2gLQ8i3rdWipCYX/P0Yar+ct4Hh0HqX9XcU3MUzrzDtIB7Cf9Pws6q5W78ZJCF56QU0P xtYt4wBcX74bvhep69MqnRroRO45ed0IgzI6QfZAfNk0ebfMH52uPNZDxIyy/kuU6CVv4v NF9+TAUO7h2zRX0VfJPKW3DcKYw22RcrzuMjhkxjUOpI1UuayEcc4UiEST8V2dRtphyaVi 414GGCqCo4pMbPUdDQeBGqYS8UVdp6fBin9cxKvFGl03hWgzQTIxplRggU4N4Q== Received: from ltc.des.dev (2a01cb0585090500922e16fffef1acef.ipv6.abo.wanadoo.fr [IPv6:2a01:cb05:8509:500:922e:16ff:fef1:acef]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (Client did not present a certificate) (Authenticated sender: des) by smtp.freebsd.org (Postfix) with ESMTPSA id 4fPByG4y7dzNNM; Sun, 01 Mar 2026 19:31:34 +0000 (UTC) (envelope-from des@freebsd.org) Received: by ltc.des.dev (Postfix, from userid 1001) id 6F62DF703A; Sun, 01 Mar 2026 20:31:33 +0100 (CET) From: =?utf-8?Q?Dag-Erling_Sm=C3=B8rgrav?= To: Warner Losh Cc: Enji Cooper , src-committers@freebsd.org, dev-commits-src-all@freebsd.org, dev-commits-src-main@freebsd.org Subject: Re: git: c2dee7786bf3 - main - diff3: Code cleanup In-Reply-To: (Warner Losh's message of "Sun, 1 Mar 2026 12:22:25 -0700") References: <86tsuzojnj.fsf@ltc.des.dev> <5AF72509-9232-4B17-853D-A12D9862C422@gmail.com> <86pl5nnzbx.fsf@ltc.des.dev> User-Agent: Gnus/5.13 (Gnus v5.13) Date: Sun, 01 Mar 2026 20:31:33 +0100 Message-ID: <86ldgbny7e.fsf@ltc.des.dev> List-Id: Commit messages for all branches of the src repository List-Archive: https://lists.freebsd.org/archives/dev-commits-src-all List-Help: List-Post: List-Subscribe: List-Unsubscribe: X-BeenThere: dev-commits-src-all@freebsd.org Sender: owner-dev-commits-src-all@FreeBSD.org MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Warner Losh writes: > Dag-Erling Sm=C3=B8rgrav writes: > > EXIT_SUCCESS and EXIT_FAILURE are not sysexits, they are ISO C aliases > > for 0 and 1. They were only used in three places, while the rest of the > > code used 0, 1, or 2. I'm not opposed to switching to sysexits, but I > > don't really see any benefit. > Nor I. Aren't the current valutes mandated by POSIX or by what POSIX > mandates diff return though? Switching to sysexits would make that > harder since they don't align well with POSIX requirements. This is diff3, not diff, and is not covered by POSIX. If we want to be fully compatible with GNU diff3, we should change all our error exits to 2 (they are currently a mix of 1 and 2), and exit 1 if and only if we successfully found differences between the files. DES --=20 Dag-Erling Sm=C3=B8rgrav - des@FreeBSD.org