From owner-svn-ports-all@freebsd.org Thu Aug 6 12:35:03 2020 Return-Path: Delivered-To: svn-ports-all@mailman.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.nyi.freebsd.org (Postfix) with ESMTP id 63BB93A19DF; Thu, 6 Aug 2020 12:35:03 +0000 (UTC) (envelope-from danilogondolfo@gmail.com) Received: from mail-ua1-f52.google.com (mail-ua1-f52.google.com [209.85.222.52]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (2048 bits) client-digest SHA256) (Client CN "smtp.gmail.com", Issuer "GTS CA 1O1" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4BMnxy3yjtz454g; Thu, 6 Aug 2020 12:35:02 +0000 (UTC) (envelope-from danilogondolfo@gmail.com) Received: by mail-ua1-f52.google.com with SMTP id g11so2208736ual.2; Thu, 06 Aug 2020 05:35:02 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=DDD6ZM2agUb/E4hIqf3k6h73VVNglzxvzHua0aoVZtw=; b=Wk2j7ABbip3IWU4lgMSabSYJMMs6whU0FCX1ovQKzpGnlEFmvn1xilX4qqpxuqlVcQ B9RTlAtiO+9WMnRztHHseqAqqlPgC7+UZO74Ep30ocBcH2jlQR8P4ZUYIiBjQ+L7ucMG mHgVbCyg23i9Nwecrya8djb64CVIHXidtlLJPLiJv81llDRkhQwFvkRcM+vaSzwNN4mG yTvWBTCpT4m4pmllPjV1MXw6qGMK/uzAXLCFyqqx5fWhsg9rvYJv4iOlRbjNGG9YfBwr o3V+T7UNCgZc8v2ITl5uIOp17QyGF74rXIt9MDKSNAdqsCBAjv1I2NbAY+jSkJjMs+00 jzzg== X-Gm-Message-State: AOAM533/QRDu6VL1+6uRMbl4/wPDH8QIrvJJZ04d+scnP4l/KN19K1Qc C5h6QwMEwIUKulLS5d3hVD97eaYBxhfhtKfPsSS5IA== X-Google-Smtp-Source: ABdhPJzzY1Ik/eGTPiCrEJdueLoavb3ANW99v0J7vp81LTmmoTUEkSy//2V903zvOle3APp77/527bOMtMrJOqg3JhA= X-Received: by 2002:a9f:3e9b:: with SMTP id x27mr6208312uai.24.1596717301113; Thu, 06 Aug 2020 05:35:01 -0700 (PDT) MIME-Version: 1.0 References: <202008052155.075LtmtD072730@repo.freebsd.org> <20200806033440.GA53929@FreeBSD.org> In-Reply-To: From: =?UTF-8?Q?Danilo_Eg=C3=AAa_Gondolfo?= Date: Thu, 6 Aug 2020 13:34:50 +0100 Message-ID: Subject: Re: svn commit: r544245 - head/x11/sakura To: Mateusz Piotrowski <0mp@freebsd.org> Cc: Alexey Dokuchaev , ports-committers , svn-ports-all@freebsd.org, svn-ports-head@freebsd.org X-Rspamd-Queue-Id: 4BMnxy3yjtz454g X-Spamd-Bar: ---- Authentication-Results: mx1.freebsd.org; none X-Spamd-Result: default: False [-4.00 / 15.00]; REPLY(-4.00)[]; ASN(0.00)[asn:15169, ipnet:209.85.128.0/17, country:US] Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Content-Filtered-By: Mailman/MimeDel 2.1.33 X-BeenThere: svn-ports-all@freebsd.org X-Mailman-Version: 2.1.33 Precedence: list List-Id: SVN commit messages for the ports tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 06 Aug 2020 12:35:03 -0000 On Thu, Aug 6, 2020 at 12:50 PM Mateusz Piotrowski <0mp@freebsd.org> wrote: > On 8/6/20 12:46 PM, Danilo Eg=C3=AAa Gondolfo wrote: > > On Thu, Aug 6, 2020 at 4:34 AM Alexey Dokuchaev > wrote: > > > >> On Wed, Aug 05, 2020 at 09:55:48PM +0000, Danilo Egea Gondolfo wrote: > >>> New Revision: 544245 > >>> URL: https://svnweb.freebsd.org/changeset/ports/544245 > >>> > >>> @@ -14,9 +14,10 @@ LICENSE=3D GPLv2 > >>> LIB_DEPENDS=3D libgnutls.so:security/gnutls \ > >>> libpcre2-8.so:devel/pcre2 > >>> > >>> +USES=3D cmake gnome pkgconfig gettext perl5 tar:bz2 x= org > >>> + > >>> OPTIONS_DEFINE=3D DOCS > >>> > >>> -USES=3D cmake gnome pkgconfig gettext perl5 xorg > >>> USE_GNOME=3D cairo gdkpixbuf2 vte3 > >> I'd argue that USES was placed better before this change (right next t= o > >> USE_FOO knobs). It should've been left where it was and OPTIONS_DEFIN= E > >> moved downwards instead. > >> > >> ./danfe > >> > > Just tried to make portlint happy on this one ("USES should appear > > earlier"). > > Please try portfmt and portclippy from ports-mgmt/portfmt. They are much > better for order fixes and > simple style fixes than portlint in most cases. > > Cheers, > > Mateusz Piotrowski > > Interesting, I'll give it a try. Thanks ;)