From owner-svn-src-head@FreeBSD.ORG  Wed Jul 16 11:29:27 2014
Return-Path: <owner-svn-src-head@FreeBSD.ORG>
Delivered-To: svn-src-head@freebsd.org
Received: from mx1.freebsd.org (mx1.freebsd.org [8.8.178.115])
 (using TLSv1 with cipher ADH-AES256-SHA (256/256 bits))
 (No client certificate requested)
 by hub.freebsd.org (Postfix) with ESMTPS id 86564600;
 Wed, 16 Jul 2014 11:29:27 +0000 (UTC)
Received: from mail-wg0-x229.google.com (mail-wg0-x229.google.com
 [IPv6:2a00:1450:400c:c00::229])
 (using TLSv1 with cipher ECDHE-RSA-RC4-SHA (128/128 bits))
 (Client CN "smtp.gmail.com",
 Issuer "Google Internet Authority G2" (verified OK))
 by mx1.freebsd.org (Postfix) with ESMTPS id C392B2C91;
 Wed, 16 Jul 2014 11:29:26 +0000 (UTC)
Received: by mail-wg0-f41.google.com with SMTP id z12so732049wgg.12
 for <multiple recipients>; Wed, 16 Jul 2014 04:29:20 -0700 (PDT)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113;
 h=sender:date:from:to:cc:subject:message-id:references:mime-version
 :content-type:content-disposition:in-reply-to:user-agent;
 bh=7wPLjtgQX8TrmIvq9FfujI9gS2rBA+QbCnmzrbWOaqs=;
 b=XcL2gksfTjEs456Sa72I2k1FZyAieZgjfbfvYBlSja+CQymO2T+R5xUy4LihxF1VDn
 J5cK3g5pgR9vAiWs+YJRcz9Z53/XczIkuE3BKmEE3+tikUlvUZSBZ0L4fSv14Am3Y0NE
 Z5bmHS3BrDFR5Yo0hZRGtecza40lG/mqOm7P6hERASaDwMFLGOYPvkSk2lIZDSowGrpY
 nw6X75gO0NiEJgwIkW71zFlVdQ98D0wAZu6kAgiFBM9/i6JWYdt/1S8GcIGOyrETQN2I
 wMIme4sC/EAcMT1cUlDVtt5G5L4TaBK8wqppRR/9zhh8tu5r3WKtSmld8g9ycEEFQ2EH
 iMOA==
X-Received: by 10.180.188.203 with SMTP id gc11mr6004610wic.59.1405510160675; 
 Wed, 16 Jul 2014 04:29:20 -0700 (PDT)
Received: from ivaldir.etoilebsd.net ([2001:41d0:8:db4c::1])
 by mx.google.com with ESMTPSA id du6sm7988591wib.6.2014.07.16.04.29.19
 for <multiple recipients>
 (version=TLSv1.2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128);
 Wed, 16 Jul 2014 04:29:19 -0700 (PDT)
Sender: Baptiste Daroussin <baptiste.daroussin@gmail.com>
Date: Wed, 16 Jul 2014 13:29:14 +0200
From: Baptiste Daroussin <bapt@FreeBSD.org>
To: Mateusz Guzik <mjguzik@gmail.com>
Subject: Re: svn commit: r268745 - in head/usr.bin: . timeout
Message-ID: <20140716112914.GI48710@ivaldir.etoilebsd.net>
References: <201407160955.s6G9taro084054@svn.freebsd.org>
 <20140716102908.GA17076@dft-labs.eu>
 <20140716103411.GH48710@ivaldir.etoilebsd.net>
 <20140716104512.GB17076@dft-labs.eu>
MIME-Version: 1.0
Content-Type: multipart/signed; micalg=pgp-sha1;
 protocol="application/pgp-signature"; boundary="yhze8HlyfmXt1APY"
Content-Disposition: inline
In-Reply-To: <20140716104512.GB17076@dft-labs.eu>
User-Agent: Mutt/1.5.23 (2014-03-12)
Cc: svn-src-head@freebsd.org, svn-src-all@freebsd.org,
 src-committers@freebsd.org
X-BeenThere: svn-src-head@freebsd.org
X-Mailman-Version: 2.1.18
Precedence: list
List-Id: SVN commit messages for the src tree for head/-current
 <svn-src-head.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/options/svn-src-head>,
 <mailto:svn-src-head-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/svn-src-head/>
List-Post: <mailto:svn-src-head@freebsd.org>
List-Help: <mailto:svn-src-head-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/svn-src-head>,
 <mailto:svn-src-head-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Wed, 16 Jul 2014 11:29:27 -0000


--yhze8HlyfmXt1APY
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable

On Wed, Jul 16, 2014 at 12:45:12PM +0200, Mateusz Guzik wrote:
> On Wed, Jul 16, 2014 at 12:34:11PM +0200, Baptiste Daroussin wrote:
> > On Wed, Jul 16, 2014 at 12:29:08PM +0200, Mateusz Guzik wrote:
> > > On Wed, Jul 16, 2014 at 09:55:36AM +0000, Baptiste Daroussin wrote:
> > > > +static void
> > > > +usage(void)
> > > > +{
> > > > +	fprintf(stderr, "Usage: %s [--signal sig | -s sig] [--preserve-st=
atus]"
> > > > +	    " [--kill-after time | -k time] [--foreground] <duration> <co=
mmand>"
> > > > +	    " <arg ...>\n", getprogname());
> > > > +
> > >=20
> > > Missing newline at the begnning.
> > New line at the beginning?
> > >=20
>=20
> static void
> usage(void)
> {
>=20
> 	fprintf(...);

Fixed
>=20
> > > > +	exit(EX_USAGE);
> > > > +}
> > > > +
> > > > +	switch(signo) {
> > > > +	case 0:
> > >=20
> > > sig 0? I doubt it is ever delivered.
> >=20
> > one of the tests from the GNU testsuite is passing 0 signal
>=20
> I even checked. The kernel is not going to deliver signal 0, so checking
> for it in signal handler does not seem to make sense.
>=20
> Does the testcaes fail without it or something?
>=20

Yes the test fails without it

regards,
Bapt

--yhze8HlyfmXt1APY
Content-Type: application/pgp-signature

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v2

iEYEARECAAYFAlPGYgoACgkQ8kTtMUmk6ExTCgCeN5OA5fQShU36A1SBW2uMuGWs
WogAnA1/LZ2Q+cSZ+JgehXJHFEwq8KyV
=Bxr+
-----END PGP SIGNATURE-----

--yhze8HlyfmXt1APY--