Skip site navigation (1)Skip section navigation (2)
Date:      Tue, 13 Nov 2012 23:10:20 -0500 (EST)
From:      Benjamin Kaduk <kaduk@MIT.EDU>
To:        Eitan Adler <lists@eitanadler.com>
Cc:        FreeBSD Hackers <freebsd-hackers@freebsd.org>
Subject:   Re: Give users a hint when their locate database is too small.
Message-ID:  <alpine.GSO.1.10.1211132306440.2164@multics.mit.edu>
In-Reply-To: <CAF6rxgnA-prOCLh5w56dJBd3UsGMar_-ZYpoBT4OyRadVZAy2A@mail.gmail.com>
References:  <CAF6rxgkXXmSsoPHNVe6RLGpQ1C-qUq_y4YQSo3YgPhAeTdJAyQ@mail.gmail.com> <alpine.BSF.2.00.1211130731270.43524@wonkity.com> <CAF6rxgnA-prOCLh5w56dJBd3UsGMar_-ZYpoBT4OyRadVZAy2A@mail.gmail.com>

next in thread | previous in thread | raw e-mail | index | archive | help
On Tue, 13 Nov 2012, Eitan Adler wrote:

>
> Ack to all. Final patch sent for approval:
>
> diff --git a/usr.bin/locate/locate/locate.c b/usr.bin/locate/locate/locate.c
> index b0faefb..95b3fed 100644
> --- a/usr.bin/locate/locate/locate.c
> +++ b/usr.bin/locate/locate/locate.c
> @@ -292,7 +292,7 @@ search_mmap(db, s)
> 		err(1, "`%s'", db);
> 	len = sb.st_size;
> 	if (len < (2*NBG))
> -		errx(1, "database too small: %s", db);
> +		errx(1, "database too small: %s\nRun /usr/libexec/locate.updatedb", db);

That looks longer than 80 characters, a limit given implicitly in style.9.

-Ben


>
> 	if ((p = mmap((caddr_t)0, (size_t)len,
> 		      PROT_READ, MAP_SHARED,
>
> -- 
> Eitan Adler
> _______________________________________________
> freebsd-hackers@freebsd.org mailing list
> http://lists.freebsd.org/mailman/listinfo/freebsd-hackers
> To unsubscribe, send any mail to "freebsd-hackers-unsubscribe@freebsd.org"
>



Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?alpine.GSO.1.10.1211132306440.2164>