Date: Sat, 1 Oct 2022 12:50:56 +0200 From: Matthias Andree <mandree@FreeBSD.org> To: d@delphij.net, ports-committers@FreeBSD.org, dev-commits-ports-all@FreeBSD.org, dev-commits-ports-main@FreeBSD.org Subject: Re: git: 525e857368c8 - main - sysutils/e2fsprogs: revert bogus qsort_r() patch. Message-ID: <8fefd052-a8ff-dade-cc6c-0247569164be@FreeBSD.org> In-Reply-To: <e026e87b-6d27-ae3b-aa7a-1058272391d8@FreeBSD.org> References: <202210010713.2917DPgq077535@gitrepo.freebsd.org> <eaa1a01a-f52b-70c6-e506-d7efb7345464@delphij.net> <e026e87b-6d27-ae3b-aa7a-1058272391d8@FreeBSD.org>
next in thread | previous in thread | raw e-mail | index | archive | help
Following up my own message... > > Then the proper fix is to remove the unused ballast if it is getting > in the way. Done as of 5db803a6f269. While reviewing compiler logs I figured we had a long-standing buffer sizing bug in our own blkid extension; you can't char buf[5]; sscanf(input, "%5s", buf) because you don't have room for the 5 scanned characters plus trailing '\0'. Fixed as well.
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?8fefd052-a8ff-dade-cc6c-0247569164be>