From owner-dev-commits-src-all@freebsd.org Fri Feb 26 21:48:17 2021 Return-Path: Delivered-To: dev-commits-src-all@mailman.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.nyi.freebsd.org (Postfix) with ESMTP id 54DE155061E; Fri, 26 Feb 2021 21:48:17 +0000 (UTC) (envelope-from bapt@FreeBSD.org) Received: from smtp.freebsd.org (smtp.freebsd.org [IPv6:2610:1c1:1:606c::24b:4]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "smtp.freebsd.org", Issuer "R3" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4DnNZ91y5Fz3CQR; Fri, 26 Feb 2021 21:48:17 +0000 (UTC) (envelope-from bapt@FreeBSD.org) Received: from aniel.nours.eu (unknown [IPv6:2001:41d0:8:3a4d::1]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client did not present a certificate) (Authenticated sender: bapt) by smtp.freebsd.org (Postfix) with ESMTPSA id 1BDB347DA; Fri, 26 Feb 2021 21:48:17 +0000 (UTC) (envelope-from bapt@FreeBSD.org) Received: from [127.0.0.1] (10.246.39.62.rev.sfr.net [62.39.246.10]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by aniel.nours.eu (Postfix) with ESMTPSA id 043C13643D; Fri, 26 Feb 2021 22:48:14 +0100 (CET) Date: Fri, 26 Feb 2021 21:48:09 +0000 (UTC) From: Baptiste Daroussin To: Enji Cooper Cc: "src-committers@freebsd.org" , "dev-commits-src-all@freebsd.org" , "dev-commits-src-main@freebsd.org" Message-ID: <44c9cd7b-e032-4613-81be-6214f37d2fbe@FreeBSD.org> In-Reply-To: References: <202102251327.11PDR4eC083842@gitrepo.freebsd.org> Subject: Re: git: 2a50a9de8340 - main - terminfo: add terminfo database MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable X-Correlation-ID: <44c9cd7b-e032-4613-81be-6214f37d2fbe@FreeBSD.org> X-BeenThere: dev-commits-src-all@freebsd.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: Commit messages for all branches of the src repository List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 26 Feb 2021 21:48:17 -0000 26 f=C3=A9vr. 2021 22:41:37 Enji Cooper : > >> On Feb 25, 2021, at 5:27 AM, Baptiste Daroussin wrote= : >> >> The branch main has been updated by bapt: >> >> URL: https://cgit.FreeBSD.org/src/commit/?id=3D2a50a9de8340f08bd876e9e59= 93332ae14376f80 >> >> commit 2a50a9de8340f08bd876e9e5993332ae14376f80 >> Author:=C2=A0=C2=A0=C2=A0=C2=A0 Baptiste Daroussin >> AuthorDate: 2021-02-23 16:17:32 +0000 >> Commit:=C2=A0=C2=A0=C2=A0=C2=A0 Baptiste Daroussin >> CommitDate: 2021-02-25 13:25:32 +0000 >> >> =C2=A0=C2=A0 terminfo: add terminfo database >> >> =C2=A0=C2=A0 Tested by:=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 manu, jbeich > > Hi Baptiste, > =C2=A0 A question and a comment: > =C2=A0 1. Was this reviewed in Phabricator? > =C2=A0 2. The details on why the terminfo database is being added are a b= it lean too to non-Unix users. It would be nice if the motivation for the c= hange was documented in the commit message. > Thanks! > -Enji No it was not reviewed in phabricator as it does not really bring any code,= but it was discussed on the mailing lists with a heads up on the plan and = the motivation, and all the reaction were in favor of this change. Note thay while it could have been better written this commit is the third = of a serie, where the first one explain a bit more things. Bapt