From owner-freebsd-current@FreeBSD.ORG Tue Jan 6 23:10:51 2015 Return-Path: Delivered-To: freebsd-current@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by hub.freebsd.org (Postfix) with ESMTPS id 5B9F4479; Tue, 6 Jan 2015 23:10:51 +0000 (UTC) Received: from mail-wi0-x22d.google.com (mail-wi0-x22d.google.com [IPv6:2a00:1450:400c:c05::22d]) (using TLSv1 with cipher ECDHE-RSA-RC4-SHA (128/128 bits)) (Client CN "smtp.gmail.com", Issuer "Google Internet Authority G2" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id E1C3EDE3; Tue, 6 Jan 2015 23:10:50 +0000 (UTC) Received: by mail-wi0-f173.google.com with SMTP id r20so6361876wiv.12; Tue, 06 Jan 2015 15:10:49 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=mime-version:in-reply-to:references:date:message-id:subject:from:to :cc:content-type; bh=lnrLaNsFaFkFMjelQPyk8KgJabfGUzCgSP1eLfyynQA=; b=gIiFWNj8dhfoG5SQdojgEn9V0RR0wVnZlg/AF42yCruGfy/hU3Q9ulfb9pfEndkJ43 h0NqmBrFVDXFe2d23unjDJu4uQDmtVdlIVO69J0YllD/tCFg/hXlkefoZsaxhpkSsZ3B hnH4+bY/yyq1Aq2RAo5j/Np5cOpyCO1TfG7w9nZTstPf1pYI4TU3zwnecW7qM5HcormY 23sU/xfz2QW3c/FYJzuHrT54Dj3hgvVtPKN9sKosMbmpPWWxvJx3o6g4lzbLm2lblU7W E/Uz5fE/fQLwRWRyj0u7f86sK4GBxr2jOlZEo+OjyHH1Xbm34Dqt1OA9i4KkEcI+PbFd 6hrw== MIME-Version: 1.0 X-Received: by 10.180.73.108 with SMTP id k12mr1275504wiv.24.1420585849407; Tue, 06 Jan 2015 15:10:49 -0800 (PST) Received: by 10.217.118.194 with HTTP; Tue, 6 Jan 2015 15:10:49 -0800 (PST) In-Reply-To: <54A9A71E.70609@selasky.org> References: <54A1B38C.1000709@selasky.org> <20150101005613.4f788b0c@nonamehost.local> <54A49CA5.2060801@selasky.org> <54A4A002.8010802@selasky.org> <54A53F4F.2000003@selasky.org> <54A92ED1.2070906@selasky.org> <54A9A71E.70609@selasky.org> Date: Tue, 6 Jan 2015 16:10:49 -0700 Message-ID: Subject: Re: [RFC] kern/kern_timeout.c rewrite in progress From: Jason Wolfe To: Hans Petter Selasky Content-Type: text/plain; charset=UTF-8 X-Mailman-Approved-At: Tue, 06 Jan 2015 23:19:49 +0000 Cc: Adrian Chadd , FreeBSD Current , "freebsd-arch@freebsd.org" X-BeenThere: freebsd-current@freebsd.org X-Mailman-Version: 2.1.18-1 Precedence: list List-Id: Discussions about the use of FreeBSD-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 06 Jan 2015 23:10:51 -0000 On Sun, Jan 4, 2015 at 1:48 PM, Hans Petter Selasky wrote: > On 01/04/15 19:58, Adrian Chadd wrote: >> >> Hi! >> >> Can you throw this into reviews.freebsd.org please? This is something >> that should be very closely reviewed and tested. >> >> (I'm going to go over this quite closely as it related to a lot of the >> random crap I do ..) >> > > Hi Adrian, > > Here you go: > > https://reviews.freebsd.org/D1438 > > Thank you for your time to review this! > > > --HPS Hans, We've been running into 'spin lock held too long' panics in the kernel idle threads on 10-STABLE over the past 6 months, so I was interested to see your work here in the callout code. I went ahead and brought this patch back to a recent 10.1-STABLE base without much issue, kern_timeout.c was actually the only piece with some easily resolvable rejections. I've had a box running stable under load with this patch for a few days, and 10 more have just been added to the rotation. Anyway just figured you might be interested in the some feedback while the changes are reviewed. Thanks! Jason