From owner-freebsd-net Fri May 31 22:32:41 2002 Delivered-To: freebsd-net@freebsd.org Received: from patrocles.silby.com (d115.as13.nwbl0.wi.voyager.net [169.207.135.243]) by hub.freebsd.org (Postfix) with ESMTP id 0BC9437B405 for ; Fri, 31 May 2002 22:32:37 -0700 (PDT) Received: from patrocles.silby.com (localhost [127.0.0.1]) by patrocles.silby.com (8.12.3/8.12.3) with ESMTP id g515XtOA027402; Sat, 1 Jun 2002 00:33:55 -0500 (CDT) (envelope-from silby@silby.com) Received: from localhost (silby@localhost) by patrocles.silby.com (8.12.3/8.12.3/Submit) with ESMTP id g515XrEp027399; Sat, 1 Jun 2002 00:33:55 -0500 (CDT) X-Authentication-Warning: patrocles.silby.com: silby owned process doing -bs Date: Sat, 1 Jun 2002 00:33:52 -0500 (CDT) From: Mike Silbersack To: Andre Oppermann Cc: freebsd-net@freebsd.org Subject: Re: Bug in net/route.[ch] with rmx_pksent while cloning In-Reply-To: <3CF761DA.72AE838A@pipeline.ch> Message-ID: <20020601003230.T27367-100000@patrocles.silby.com> MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII Sender: owner-freebsd-net@FreeBSD.ORG Precedence: bulk List-ID: List-Archive: (Web Archive) List-Help: (List Instructions) List-Subscribe: List-Unsubscribe: X-Loop: FreeBSD.org On Fri, 31 May 2002, Andre Oppermann wrote: > I think it will break. Isn't there a compiler warning in net/rtsocket.c > on 64bit platforms about the u_long to int assignment? > > IMO the right solution would to simply axe this field from rt_msghdr. > It serves no purpose. At least none of the base utilites look at it and > I don't see neither gated nor Zebra using it. > > My vote would go to axe it in -CURRENT and bump the version number. Netstat > and route need to be recompiled. Note in UPDATING. Even in -current, that's an annoying step to take. What I'm thinking of doing is renaming the field to rt_unused with a comment indicating that it should be axed if anyone else has a good reason to change the structure. I'll look over your latest round of patches tomorrow. They're a bit more in depth, I can't evaluate them in 5 minutes. :) Mike "Silby" Silbersack To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe freebsd-net" in the body of the message