From owner-p4-projects Sat Nov 23 15:47:28 2002 Delivered-To: p4-projects@freebsd.org Received: by hub.freebsd.org (Postfix, from userid 32767) id 45DAF37B401; Sat, 23 Nov 2002 15:47:25 -0800 (PST) Delivered-To: perforce@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id CFC4137B404 for ; Sat, 23 Nov 2002 15:47:24 -0800 (PST) Received: from herring.nlsystems.com (mailgate.nlsystems.com [62.49.251.130]) by mx1.FreeBSD.org (Postfix) with ESMTP id 5AA8643EA3 for ; Sat, 23 Nov 2002 15:47:11 -0800 (PST) (envelope-from dfr@nlsystems.com) Received: from herring.nlsystems.com (herring.nlsystems.com [10.0.0.2]) by herring.nlsystems.com (8.12.6/8.12.6) with ESMTP id gANNkfqb069651; Sat, 23 Nov 2002 23:46:41 GMT (envelope-from dfr@nlsystems.com) Content-Type: text/plain; charset="iso-8859-1" From: Doug Rabson To: Marcel Moolenaar Subject: Re: PERFORCE change 21417 for review Date: Sat, 23 Nov 2002 23:46:41 +0000 User-Agent: KMail/1.4.3 Cc: Perforce Change Reviews References: <200211232017.gANKHAAk090869@repoman.freebsd.org> <200211232250.38412.dfr@nlsystems.com> <20021123230017.GB8744@dhcp01.pn.xcllnt.net> In-Reply-To: <20021123230017.GB8744@dhcp01.pn.xcllnt.net> MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Message-Id: <200211232346.41171.dfr@nlsystems.com> X-Spam-Status: No, hits=-7.7 required=5.0 tests=IN_REP_TO,QUOTED_EMAIL_TEXT,REFERENCES,SPAM_PHRASE_00_01, USER_AGENT,USER_AGENT_KMAIL version=2.41 Sender: owner-p4-projects@FreeBSD.ORG Precedence: bulk List-ID: List-Archive: (Web Archive) List-Help: (List Instructions) List-Subscribe: List-Unsubscribe: X-Loop: FreeBSD.ORG On Saturday 23 November 2002 11:00 pm, Marcel Moolenaar wrote: > On Sat, Nov 23, 2002 at 10:50:38PM +0000, Doug Rabson wrote: > > On Saturday 23 November 2002 8:17 pm, Marcel Moolenaar wrote: > > > http://perforce.freebsd.org/chv.cgi?CH=3D21417 > > > > > > Change 21417 by marcel@marcel_nfs on 2002/11/23 12:17:09 > > > > > > =09Raw, untested implementation of EPC syscalls. > > > > This seems to be missing the bit after calling syscall() which > > checks for a full exception_restore, e.g. after an execve and also > > the check for calling ast(), e.g. after a signal. > > Yes. > > [snip] > > > One other thing after re-familiarising myself with exception.s. You > > have added unwind records to all the kernel IVT entry points. This > > is quite unhelpful when trying to debug kernel faults. The previous > > version which manually unwound past the exception to the code which > > faulted was extremely useful and saved me a lot of time in > > debugging. Can we have it back please :-). > > If we want to use unwinding to get to the register state of the > process, we can never unwind over the exception code. It's probably > much easier to restart unwinding after it stopped at the exception > entry point. This would also hold for signal handlers. Would a DDB > command to resume unwinding work? I think it would be ok to just put back the code in db_stack_trace_cmd()=20 which spots kernel entry points and resets the unwind state based on=20 the contents of the appropriate stack frame. That would give complete=20 stack traces in DDB without disturbing the real unwind records. --=20 Doug Rabson=09=09=09=09Mail: dfr@nlsystems.com =09=09=09=09=09Phone: +44 20 8348 6160 To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe p4-projects" in the body of the message