From owner-freebsd-ports-bugs@FreeBSD.ORG Sun May 24 05:20:02 2009 Return-Path: Delivered-To: freebsd-ports-bugs@hub.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 2E6C6106566B; Sun, 24 May 2009 05:20:02 +0000 (UTC) (envelope-from gnats@FreeBSD.org) Received: from freefall.freebsd.org (freefall.freebsd.org [IPv6:2001:4f8:fff6::28]) by mx1.freebsd.org (Postfix) with ESMTP id 099158FC18; Sun, 24 May 2009 05:20:02 +0000 (UTC) (envelope-from gnats@FreeBSD.org) Received: from freefall.freebsd.org (gnats@localhost [127.0.0.1]) by freefall.freebsd.org (8.14.3/8.14.3) with ESMTP id n4O5K1T0067087; Sun, 24 May 2009 05:20:01 GMT (envelope-from gnats@freefall.freebsd.org) Received: (from gnats@localhost) by freefall.freebsd.org (8.14.3/8.14.3/Submit) id n4O5K1ip067086; Sun, 24 May 2009 05:20:01 GMT (envelope-from gnats) Resent-Date: Sun, 24 May 2009 05:20:01 GMT Resent-Message-Id: <200905240520.n4O5K1ip067086@freefall.freebsd.org> Resent-From: FreeBSD-gnats-submit@freebsd.org (GNATS Filer) Resent-To: freebsd-ports-bugs@FreeBSD.org Resent-Cc: skv@freebsd.org, pgollucci@freebsd.org Resent-Reply-To: FreeBSD-gnats-submit@freebsd.org, Eygene Ryabinkin Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 40F29106566B for ; Sun, 24 May 2009 05:18:27 +0000 (UTC) (envelope-from rea-fbsd@codelabs.ru) Received: from 0.mx.codelabs.ru (0.mx.codelabs.ru [144.206.177.45]) by mx1.freebsd.org (Postfix) with ESMTP id EA7368FC13 for ; Sun, 24 May 2009 05:18:26 +0000 (UTC) (envelope-from rea-fbsd@codelabs.ru) Received: from phoenix.codelabs.ru (ppp91-78-117-66.pppoe.mtu-net.ru [91.78.117.66]) by 0.mx.codelabs.ru with esmtps (TLSv1:CAMELLIA256-SHA:256) id 1M866L-000J05-Uh for FreeBSD-gnats-submit@freebsd.org; Sun, 24 May 2009 09:18:26 +0400 Message-Id: <20090524051825.F00D0B806B@phoenix.codelabs.ru> Date: Sun, 24 May 2009 09:18:25 +0400 (MSD) From: Eygene Ryabinkin To: FreeBSD-gnats-submit@freebsd.org X-Send-Pr-Version: 3.113 X-GNATS-Notify: skv@freebsd.org, pgollucci@freebsd.org Cc: Subject: ports/134889: [patch] www/p5-libapreq2: pass down MAKE=${GMAKE} to let MakeMAker generate proper makefiles X-BeenThere: freebsd-ports-bugs@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list Reply-To: Eygene Ryabinkin List-Id: Ports bug reports List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sun, 24 May 2009 05:20:02 -0000 >Number: 134889 >Category: ports >Synopsis: [patch] www/p5-libapreq2: pass down MAKE=${GMAKE} to let MakeMAker generate proper makefiles >Confidential: no >Severity: serious >Priority: medium >Responsible: freebsd-ports-bugs >State: open >Quarter: >Keywords: >Date-Required: >Class: sw-bug >Submitter-Id: current-users >Arrival-Date: Sun May 24 05:20:01 UTC 2009 >Closed-Date: >Last-Modified: >Originator: Eygene Ryabinkin >Release: FreeBSD 7.1-STABLE amd64 >Organization: Code Labs >Environment: System: FreeBSD 7.1-STABLE amd64 >Description: Port build for 2.12 chokes at the time of processing of Makefile generated by Makefile.PL: ----- gmake[2]: Entering directory `/usr/ports/www/p5-libapreq2/work/libapreq2-2.12/glue/perl' cp lib/Apache2/Cookie.pm blib/lib/Apache2/Cookie.pm cp lib/Apache2/Upload.pm blib/lib/Apache2/Upload.pm cp lib/Apache2/Request.pm blib/lib/Apache2/Request.pm cp lib/APR/DummyVersions.pm blib/lib/APR/DummyVersions.pm make: don't know how to make w. Stop gmake[2]: *** [subdirs] Error 2 gmake[2]: Leaving directory `/usr/ports/www/p5-libapreq2/work/libapreq2-2.12/glue/perl' gmake[1]: *** [perl_glue] Error 2 gmake[1]: Leaving directory `/usr/ports/www/p5-libapreq2/work/libapreq2-2.12/glue' gmake: *** [all-recursive] Error 1 *** Error code 1 Stop in /usr/ports/www/p5-libapreq2. ----- The problem is that MakeMaker defines ----- MAKE=make ---- and that's wrong -- we should invoke gmake for the subdirectories. >How-To-Repeat: Just try to build www/p2-libapreq2. >Fix: The following patch adds make variable MAKE that is set to ${GMAKE}. This fixes the issue for me. Tinderbox builds on 6.x, 7.x and 8.x are also fine for the patched port. --- 2.12-pass-down-MAKE-equal-to-gmake.diff begins here --- >From 5c3686e8a59007a6c15fcc8eaa4b320902317162 Mon Sep 17 00:00:00 2001 From: Eygene Ryabinkin Date: Sun, 24 May 2009 00:18:47 +0400 Without this, Perl's MakeMaker generates Makefiles with 'MAKE=make' and this is bad for subdirectory targets where $(MAKE) is used: pmake is invoked instead of GNU Make, so make process chokes at this point, ----- gmake[2]: Entering directory `/usr/ports/www/p5-libapreq2/work/libapreq2-2.12/glue/perl' cp lib/Apache2/Cookie.pm blib/lib/Apache2/Cookie.pm cp lib/Apache2/Upload.pm blib/lib/Apache2/Upload.pm cp lib/Apache2/Request.pm blib/lib/Apache2/Request.pm cp lib/APR/DummyVersions.pm blib/lib/APR/DummyVersions.pm make: don't know how to make w. Stop gmake[2]: *** [subdirs] Error 2 gmake[2]: Leaving directory `/usr/ports/www/p5-libapreq2/work/libapreq2-2.12/glue/perl' gmake[1]: *** [perl_glue] Error 2 gmake[1]: Leaving directory `/usr/ports/www/p5-libapreq2/work/libapreq2-2.12/glue' gmake: *** [all-recursive] Error 1 *** Error code 1 Stop in /usr/ports/www/p5-libapreq2. ----- Signed-off-by: Eygene Ryabinkin --- www/p5-libapreq2/Makefile | 3 +++ 1 files changed, 3 insertions(+), 0 deletions(-) diff --git a/www/p5-libapreq2/Makefile b/www/p5-libapreq2/Makefile index 15e6485..b93ae27 100644 --- a/www/p5-libapreq2/Makefile +++ b/www/p5-libapreq2/Makefile @@ -10,8 +10,11 @@ CATEGORIES= www perl5 devel MAINTAINER= skv@FreeBSD.org COMMENT= Generic Apache2 Request Library with perl binding +PORTREVISION= 1 + MASTERDIR= ${.CURDIR}/../libapreq2 WITH_MODPERL2= yes +MAKE_ENV+= MAKE=${GMAKE} .include "${MASTERDIR}/Makefile" -- 1.6.3.1 --- 2.12-pass-down-MAKE-equal-to-gmake.diff ends here --- And this patch fixes pkg-plist. --- 2.12-fix-plist.diff begins here --- >From 7abb5b715c2173fb133d0ea264dc2439fe3746e9 Mon Sep 17 00:00:00 2001 From: Eygene Ryabinkin Date: Sun, 24 May 2009 09:03:26 +0400 Subject: [PATCH] www/p5-libapreq: fix pkg-plist Signed-off-by: Eygene Ryabinkin --- www/libapreq2/pkg-plist | 1 + 1 files changed, 1 insertions(+), 0 deletions(-) diff --git a/www/libapreq2/pkg-plist b/www/libapreq2/pkg-plist index 58a26de..2ca70c0 100644 --- a/www/libapreq2/pkg-plist +++ b/www/libapreq2/pkg-plist @@ -15,6 +15,7 @@ lib/libapreq2.so.%%SHLIB_MAJOR%% %%APACHEMODDIR%%/mod_apreq2.a %%APACHEMODDIR%%/mod_apreq2.la %%APACHEMODDIR%%/mod_apreq2.so +%%WITH_MODPERL2%%%%SITE_PERL%%/%%PERL_ARCH%%/APR/DummyVersions.pm %%WITH_MODPERL2%%%%SITE_PERL%%/%%PERL_ARCH%%/APR/Request.pm %%WITH_MODPERL2%%%%SITE_PERL%%/%%PERL_ARCH%%/APR/Request.pod %%WITH_MODPERL2%%%%SITE_PERL%%/%%PERL_ARCH%%/APR/Request/Apache2.pm -- 1.6.3.1 --- 2.12-fix-plist.diff ends here --- >Release-Note: >Audit-Trail: >Unformatted: