From nobody Mon Aug 21 17:24:52 2023 X-Original-To: dev-commits-ports-main@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4RTzrp4CrXz4r4xb for ; Mon, 21 Aug 2023 17:25:30 +0000 (UTC) (envelope-from sunpoet@freebsd.org) Received: from smtp.freebsd.org (smtp.freebsd.org [96.47.72.83]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "smtp.freebsd.org", Issuer "R3" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4RTzrp3L5lz3WDN for ; Mon, 21 Aug 2023 17:25:30 +0000 (UTC) (envelope-from sunpoet@freebsd.org) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1692638730; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=X8bc+3F2s6tFpBFLNi+SloNxHAm81Gs2Q62aS8GUKKQ=; b=gDjIc0S+xByo4umcw5r5sCZ9ESl7ISG6agKsLXF25OyJY6f+LXIcvMZYl80ljuFupIACfR sDyBLbp0puxqJszdm+yov3iOJLyjwbcSRDpQ/pJ/fB1oJZuZHV3KYpnlB+5XqC1Q8ZJPsY ASkpT+Hw1evlFnin8kNxKZL4NFf5s5e9x7xFk6JIdHAQxbgwDj82jUs/ut4pOZZVziT30v FH+sd3S3rf7u4NV6NJ73pzPn/daJL8BcZ0BPWNMULhUEQ1CFEeTrXNK9Aev0EmMt+gyvcP No0ov+67cNxSK9BVFKE4xomhevDBzey9LVfkHyojLBri4yDNcT/zH0YsVgi+6A== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1692638730; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=X8bc+3F2s6tFpBFLNi+SloNxHAm81Gs2Q62aS8GUKKQ=; b=EMa55o3CVo7rIRrpdbd1VfKYrqPyZ3XJcApUR2z+X2nZ+0+PswGYRLF/BXIIzdQ+vz8c4z YlTl4YQoix+gee9EVktr/kWh6helZTVGkjsD1S+0HTrJetsIFzW/LaI0FGbuwhvti3o7C1 qhtVCkOO/ilXwi6yOAzBLe18dUSw9HAKt60R1aKzfB2WrbpYecua3VNq9ZbXVRSpaMfKx6 JqC+S4wgE4gV6h7E3gs0ewPCIc1RNpKZoWrpzYxaFKycmRB9z8q1qAWrMl+NfobIMTVNOS gDF3RV1hDyIA9S5J9v2y1mZPVl0xzqH3sUpY+hCcwGrnMbdAwPRcClwF/E9Q6g== ARC-Seal: i=1; s=dkim; d=freebsd.org; t=1692638730; a=rsa-sha256; cv=none; b=cxLO5VVpwA7xQj7dQ6hsbRC9rChsYGyxu+rwI0fzsy2QqN+rB3kIHtoc+/L31QaKMahsA8 8147uGIfjP0aAkGNNS8EcMn+m7IFFnk1GNXY0PWjH4h4jwvub8ju4Y8MfFDNtBj+HQZVrE RpPsphYlRqlWLLI1Ca53Q+P8Shx3lToeXVPwK/lwc/dSKkDaqGUhrVtrct1/Px3BNVjbTs R6I9FCKSXgc9dnCUntXLJ87FZW9Cmfp5KN+b3p4d7GIBD+SiHmgoR378EsVlOUouybCPi+ lE1LcHREq2sF3mh2LDyVnT7q7U1ebJKUxFzHX9v6qpKWtt1NqgleMkNH427Kng== ARC-Authentication-Results: i=1; mx1.freebsd.org; none Received: from mail-ed1-f50.google.com (mail-ed1-f50.google.com [209.85.208.50]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (2048 bits) client-digest SHA256) (Client CN "smtp.gmail.com", Issuer "GTS CA 1D4" (verified OK)) (Authenticated sender: sunpoet) by smtp.freebsd.org (Postfix) with ESMTPSA id 4RTzrp2Hf7zBVS for ; Mon, 21 Aug 2023 17:25:30 +0000 (UTC) (envelope-from sunpoet@freebsd.org) Received: by mail-ed1-f50.google.com with SMTP id 4fb4d7f45d1cf-5280ef23593so4296977a12.3 for ; Mon, 21 Aug 2023 10:25:30 -0700 (PDT) X-Gm-Message-State: AOJu0YynodGjFMgUJZVJn7UktWSyU4r2I0JgBWs42z0IWT9hxrmB9fKy 8bD3eApX6fz64uMbFQs1eUGyah1hw8gl8F+m9Qqj9g== X-Google-Smtp-Source: AGHT+IELkSVVY6V/t1rc0UoiyL6nGncaFVZ+Cci+fU1b2++c1g4gPZ1gxLSCuCqW9oJnQ3pEpnl5volhH+Ve14G+yhc= X-Received: by 2002:aa7:c245:0:b0:523:471e:681a with SMTP id y5-20020aa7c245000000b00523471e681amr3919312edo.41.1692638729109; Mon, 21 Aug 2023 10:25:29 -0700 (PDT) List-Id: Commits to the main branch of the FreeBSD ports repository List-Archive: https://lists.freebsd.org/archives/dev-commits-ports-main List-Help: List-Post: List-Subscribe: List-Unsubscribe: Sender: owner-dev-commits-ports-main@freebsd.org X-BeenThere: dev-commits-ports-main@freebsd.org MIME-Version: 1.0 References: <202308180657.37I6vKKC082833@gitrepo.freebsd.org> In-Reply-To: From: Po-Chuan Hsieh Date: Tue, 22 Aug 2023 01:24:52 +0800 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: git: 578591807a5d - main - net/xprobe: Fix build on 14 To: Alexey Dokuchaev Cc: Muhammad Moinur Rahman , ports-committers@freebsd.org, dev-commits-ports-all@freebsd.org, dev-commits-ports-main@freebsd.org Content-Type: multipart/alternative; boundary="0000000000002e9b0d0603722ade" --0000000000002e9b0d0603722ade Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable On Mon, Aug 21, 2023 at 4:17=E2=80=AFPM Alexey Dokuchaev wrote: > On Fri, Aug 18, 2023 at 06:57:20AM +0000, Muhammad Moinur Rahman wrote: > > commit 578591807a5d9bc9dd08130e63d268358b90e100 > > > > net/xprobe: Fix build on 14 > > sunpoet@ had fixed the `register' issue with commit b5c1ed98827f, but > apparently it was incomplete as it still uses deprecated std::shuffle(). > > > +.include > > + > > +.if ${OPSYS} =3D=3D FreeBSD && ( ${OSVERSION} >=3D 1400091 || ( ${OSVE= RSION} > >=3D 1302505 && ${OSVERSION} < 1400000 )) > > +USES+=3D llvm:max=3D15 > > +CC=3D clang${LLVM_VERSION} > > +CPP=3D clang-cpp${LLVM_VERSION} > > +CXX=3D clang++${LLVM_VERSION} > > +.endif > > Why not follow e.g. commit 2c1a536ebca3 and patch this properly? > > ./danfe > > I've fixed it in 29873d969e02af4315ba32ac52ae43c9d6597040. Thanks. --0000000000002e9b0d0603722ade Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable
On Mon, Aug 21, 2023 at 4:17=E2=80=AFPM A= lexey Dokuchaev <danfe@freebsd.org<= /a>> wrote:
On Fri, Aug 18, 2023 at 06:57:20AM +0000, Muhamma= d Moinur Rahman wrote:
> commit 578591807a5d9bc9dd08130e63d268358b90e100
>
>=C2=A0 =C2=A0net/xprobe: Fix build on 14

sunpoet@ had fixed the `register' issue with commit b5c1ed98827f, but apparently it was incomplete as it still uses deprecated std::shuffle().
> +.include <bsd.port.options.mk>
> +
> +.if ${OPSYS} =3D=3D FreeBSD && ( ${OSVERSION} >=3D 1400091= || ( ${OSVERSION} >=3D 1302505 && ${OSVERSION} < 1400000 ))<= br> > +USES+=3D=C2=A0 =C2=A0 =C2=A0 =C2=A0llvm:max=3D15
> +CC=3D=C2=A0 clang${LLVM_VERSION}
> +CPP=3D clang-cpp${LLVM_VERSION}
> +CXX=3D clang++${LLVM_VERSION}
> +.endif

Why not follow e.g. commit 2c1a536ebca3 and patch this properly?

./danfe


I've fixed it in=C2=A029873d969e02= af4315ba32ac52ae43c9d6597040.
Thanks.=C2=A0
--0000000000002e9b0d0603722ade--