From owner-cvs-src@FreeBSD.ORG Tue Aug 22 09:54:57 2006 Return-Path: X-Original-To: cvs-src@freebsd.org Delivered-To: cvs-src@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id E105F16A4DF; Tue, 22 Aug 2006 09:54:56 +0000 (UTC) (envelope-from flz@FreeBSD.org) Received: from smtp2-g19.free.fr (smtp2-g19.free.fr [212.27.42.28]) by mx1.FreeBSD.org (Postfix) with ESMTP id 121B643D5C; Tue, 22 Aug 2006 09:54:53 +0000 (GMT) (envelope-from flz@FreeBSD.org) Received: from smtp.xbsd.org (unknown [82.233.2.192]) by smtp2-g19.free.fr (Postfix) with ESMTP id 00D1D759C7; Tue, 22 Aug 2006 11:54:52 +0200 (CEST) Received: from localhost (localhost.xbsd.org [127.0.0.1]) by smtp.xbsd.org (Postfix) with ESMTP id 594F7114B8; Tue, 22 Aug 2006 11:54:51 +0200 (CEST) Received: from smtp.xbsd.org ([127.0.0.1]) by localhost (srv1.xbsd.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id 39652-05; Tue, 22 Aug 2006 11:54:44 +0200 (CEST) Received: from mayday.esat.net (mayday.esat.net [193.95.134.156]) by smtp.xbsd.org (Postfix) with ESMTP id 69C0811458; Tue, 22 Aug 2006 11:54:43 +0200 (CEST) From: Florent Thoumie To: Kris Kennaway In-Reply-To: <20060822093819.GA48419@xor.obsecurity.org> References: <200601161951.k0GJpfNx017833@repoman.freebsd.org> <20060821080945.A48690@p-i-n.com> <20060821110753.GA99959@xor.obsecurity.org> <1156159640.53353.29.camel@mayday.esat.net> <20060821115657.GA1425@xor.obsecurity.org> <1156162582.53353.37.camel@mayday.esat.net> <20060822093819.GA48419@xor.obsecurity.org> Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="=-C/LfteExxuF45P2ES8QA" Date: Tue, 22 Aug 2006 10:54:41 +0100 Message-Id: <1156240481.53353.48.camel@mayday.esat.net> Mime-Version: 1.0 X-Mailer: Evolution 2.6.3 FreeBSD GNOME Team Port X-Virus-Scanned: amavisd-new at xbsd.org Cc: cvs-src@freebsd.org, src-committers@freebsd.org, "Raphael H. Becker" , cvs-all@freebsd.org Subject: Re: PKGDIR ambiguous (was: cvs commit: src/usr.sbin/pkg_install/info info.h main.c perform.c pkg_info.1 src/usr.sbin/pkg_install/add add.h main.c perform.c pkg_add.1 src/usr.sbin/pkg_install/lib lib.h url.c) X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 22 Aug 2006 09:54:57 -0000 --=-C/LfteExxuF45P2ES8QA Content-Type: text/plain Content-Transfer-Encoding: quoted-printable On Tue, 2006-08-22 at 05:38 -0400, Kris Kennaway wrote: > On Mon, Aug 21, 2006 at 01:16:22PM +0100, Florent Thoumie wrote: > > On Mon, 2006-08-21 at 07:56 -0400, Kris Kennaway wrote: > > > On Mon, Aug 21, 2006 at 12:27:20PM +0100, Florent Thoumie wrote: > > > > On Mon, 2006-08-21 at 07:07 -0400, Kris Kennaway wrote: > > > > > On Mon, Aug 21, 2006 at 08:09:45AM +0200, Raphael H. Becker wrote= : > > > > > >=20 > > > > > > Hi Florent, > > > > > >=20 > > > > > > PKGDIR is ambiguous in the context of ports and packages. > > > > > >=20 > > > > > > I set PKGDIR=3D/some/where/my/pkg in my /etc/profile which caus= es the > > > > > > ports to fail badly creating any packages: > > > > > >=20 > > > > > > It is used in ports/Mk/bsd.port.mk: > > > > > > # PKGDIR - A directory containing any package cr= eation > > > > > > # files. > > > > > > # Default: ${MASTERDIR} > > > > > > [...] > > > > > > PKGDIR?=3D ${MASTERDIR} > > > > > >=20 > > > > > > Havin set PKGDIR statically is a very bad idea here. > > > > >=20 > > > > > Yes, PKGDIR is incorrect in this usage. The documented place whe= re > > > > > packages are stored is: > > > > >=20 > > > > > # PACKAGES - A top level directory where all package= s go (rather than > > > > > # going locally to each port). > > > > > # Default: ${PORTSDIR}/packages > > > > > # > > > >=20 > > > > PACKAGES is a better choice than PKGDIR, but I'd like to avoid conf= usion > > > > between "cached" packages (as in, copies of downloaded packages), a= nd > > > > "home-brewed" packages.=20 > > >=20 > > > Not sure there is a need to; they're both just packages. > >=20 > > I think there is, or there should be another subdirectory under PACKAGE= S > > to tell where the packages come from. Like what apt does, something lik= e > > ${PACKAGES}/ftp.freebsd.org.packages.6.stable/All/blah.tbz. > >=20 > > You definitely don't want to mix packages from different sources, or > > made from different ports trees. >=20 > I don't really see the need for this; but if you want to go this route > there are other tools that also need to be taught about the proposed > new directory layout). Hum, actually you can have PACKAGES=3D/blah/packages/homebrewed/ in make.conf and PACKAGES=3D/blah/packages/freebsd/ in your environment, so I guess it's fine. I'll commit the s/PKG_DBDIR/PACKAGES/ change in a few minutes. --=20 Florent Thoumie flz@FreeBSD.org FreeBSD Committer --=-C/LfteExxuF45P2ES8QA Content-Type: application/pgp-signature; name=signature.asc Content-Description: This is a digitally signed message part -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.4 (FreeBSD) iD8DBQBE6tRhMxEkbVFH3PQRAhyVAJ99Z27EU86/1SsA+i+tr6btMd8cIgCdFL/H hKXKSZ4i7TPjz9Xxi3ps5Q0= =HBXY -----END PGP SIGNATURE----- --=-C/LfteExxuF45P2ES8QA--