From owner-svn-ports-head@FreeBSD.ORG Wed Feb 5 11:14:43 2014 Return-Path: Delivered-To: svn-ports-head@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) (using TLSv1 with cipher ADH-AES256-SHA (256/256 bits)) (No client certificate requested) by hub.freebsd.org (Postfix) with ESMTPS id 947CEB2C; Wed, 5 Feb 2014 11:14:43 +0000 (UTC) Received: from freefall.freebsd.org (freefall.freebsd.org [IPv6:2001:1900:2254:206c::16:87]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mx1.freebsd.org (Postfix) with ESMTPS id 7DB561C0F; Wed, 5 Feb 2014 11:14:43 +0000 (UTC) Received: from nemysis4now (localhost [127.0.0.1]) by freefall.freebsd.org (8.14.7/8.14.7) with SMTP id s15BEefR064255; Wed, 5 Feb 2014 11:14:41 GMT (envelope-from nemysis@FreeBSD.org) Received: by nemysis4now (sSMTP sendmail emulation); Wed, 05 Feb 2014 12:14:39 +0100 Date: Wed, 5 Feb 2014 12:14:39 +0100 From: Rusmir Dusko To: Dmitry Marakasov Subject: Re: svn commit: r342296 - in head/games/gnurobots: . files Message-ID: <20140205111439.GA86427@nemysis4now> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline User-Agent: Mutt/1.5.22 (2013-10-16) Cc: svn-ports-head@freebsd.org, nemysis@FreeBSD.org, svn-ports-all@freebsd.org, ports-committers@freebsd.org X-BeenThere: svn-ports-head@freebsd.org X-Mailman-Version: 2.1.17 Precedence: list List-Id: SVN commit messages for the ports tree for head List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 05 Feb 2014 11:14:43 -0000 > * Rusmir Dusko (nemysis@FreeBSD.org) wrote: > - Disable all warnings with -w > Why? These should be fixed upstream and never silenced. Because Upstream no longer maintains these Sources. The last is from 2008 and some patches that do not work from 2009. Please look http://git.savannah.gnu.org/gitweb/?p=gnurobots.git;a=summary This I have seen before but these patches do not fix anything... Does not actually fix anything 2009-11-18 Bradley Smith Fix autoconf mess such that you can actually specify... This have some fixes which do not help for deprecated messages for old GTK code 2009-11-18 Bradley Smith Fix issues when compiling with optimisations. I have added to test src/grobot.c @${REINPLACE_CMD} -e 's|gint dx, dy;|gint dx = 0, dy = 0;|' \ ${WRKSRC}/src/grobot.c src/main.c files/patch-src__main.c /usr/local/ports/local/In-Review/games/gnurobots/ > cat files/patch-src__main.c --- ./src/main.c.orig 2008-08-03 17:19:46.000000000 +0200 +++ ./src/main.c 2014-02-05 11:27:35.000000000 +0100 @@ -282,6 +282,7 @@ gchar *map_file = argv[1]; gchar *robot_program = argv[2]; gboolean loading = TRUE; + volatile gboolean *ploading = &loading; api_init(); @@ -304,7 +305,7 @@ G_ROBOT_POSITION_X(robot), ROBOT); g_printf("Loading GTK Interface ... Please wait\n\n"); - while(loading); + while(*ploading); /* Now initialize the rest of the Robot properties */ g_object_set(G_OBJECT(robot), Sorry for my bad English. -- Best regards, Rusmir Dusko