From owner-freebsd-current@FreeBSD.ORG Tue Feb 3 05:10:21 2004 Return-Path: Delivered-To: freebsd-current@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id C21FB16A4CE; Tue, 3 Feb 2004 05:10:21 -0800 (PST) Received: from mailout1.pacific.net.au (mailout1.pacific.net.au [61.8.0.84]) by mx1.FreeBSD.org (Postfix) with ESMTP id 36A8343D2D; Tue, 3 Feb 2004 05:10:20 -0800 (PST) (envelope-from bde@zeta.org.au) Received: from mailproxy2.pacific.net.au (mailproxy2.pacific.net.au [61.8.0.87])i13DAJLE000408; Wed, 4 Feb 2004 00:10:19 +1100 Received: from gamplex.bde.org (katana.zip.com.au [61.8.7.246]) i13DAHYc023006; Wed, 4 Feb 2004 00:10:18 +1100 Date: Wed, 4 Feb 2004 00:10:17 +1100 (EST) From: Bruce Evans X-X-Sender: bde@gamplex.bde.org To: jhb@freebsd.org Message-ID: <20040204000759.F593@gamplex.bde.org> MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII cc: current@freebsd.org Subject: WITNESS broken in subr_witness.c 1.168 X-BeenThere: freebsd-current@freebsd.org X-Mailman-Version: 2.1.1 Precedence: list List-Id: Discussions about the use of FreeBSD-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 03 Feb 2004 13:10:22 -0000 % RCS file: /home/ncvs/src/sys/kern/subr_witness.c,v % Working file: subr_witness.c % head: 1.168 % ... % ---------------------------- % revision 1.168 % date: 2004/02/02 22:15:17; author: jhb; state: Exp; lines: +2 -1 % - Assert that witness_cold is not true in enroll(). % - Only check witness_watch once in enroll(). % % Reported by: ru (2) % ---------------------------- This is equivalent to asserting that 1 is not true in enroll(), since enroll() is always called from witness_initialize() before the latter has set witness_cold to 0. The quick fix is to remove the assertion. Bruce