From owner-cvs-all@FreeBSD.ORG Sun Jun 27 03:36:30 2004 Return-Path: Delivered-To: cvs-all@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 83EF216A4CE; Sun, 27 Jun 2004 03:36:30 +0000 (GMT) Received: from TRANG.nuxi.com (trang.nuxi.com [66.93.134.19]) by mx1.FreeBSD.org (Postfix) with ESMTP id 5276543D39; Sun, 27 Jun 2004 03:36:30 +0000 (GMT) (envelope-from obrien@NUXI.com) Received: from dragon.nuxi.com (obrien@localhost [127.0.0.1]) by TRANG.nuxi.com (8.12.11/8.12.11) with ESMTP id i5R3Zv2G044455; Sat, 26 Jun 2004 20:35:57 -0700 (PDT) (envelope-from obrien@dragon.nuxi.com) Received: (from obrien@localhost) by dragon.nuxi.com (8.12.11/8.12.11/Submit) id i5R3Zu2h044454; Sat, 26 Jun 2004 20:35:56 -0700 (PDT) (envelope-from obrien) Date: Sat, 26 Jun 2004 20:35:56 -0700 From: "David O'Brien" To: Alexander Kabaev Message-ID: <20040627033556.GC43829@dragon.nuxi.com> References: <200406250154.i5P1sQcp072094@repoman.freebsd.org> <20040625120329.GB37003@ip.net.ua> <20040625123827.GA55913@freefall.freebsd.org> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20040625123827.GA55913@freefall.freebsd.org> User-Agent: Mutt/1.4.1i X-Operating-System: FreeBSD 5.2-CURRENT Organization: The NUXI BSD Group X-Pgp-Rsa-Fingerprint: B7 4D 3E E9 11 39 5F A3 90 76 5D 69 58 D9 98 7A X-Pgp-Rsa-Keyid: 1024/34F9F9D5 cc: Dag-Erling Sm?rgrav cc: src-committers@FreeBSD.org cc: Ruslan Ermilov cc: cvs-all@FreeBSD.org cc: cvs-src@FreeBSD.org Subject: Re: cvs commit: src/lib/libpam/modules/pam_radius pam_radius.c X-BeenThere: cvs-all@freebsd.org X-Mailman-Version: 2.1.1 Precedence: list Reply-To: obrien@FreeBSD.org List-Id: CVS commit messages for the entire tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sun, 27 Jun 2004 03:36:30 -0000 On Fri, Jun 25, 2004 at 12:38:27PM +0000, Alexander Kabaev wrote: > On Fri, Jun 25, 2004 at 02:16:27PM +0200, Dag-Erling Sm?rgrav wrote: > > Ruslan Ermilov writes: > > > On Fri, Jun 25, 2004 at 11:28:50AM +0200, Dag-Erling Sm?rgrav wrote: > > > > Alexander Kabaev writes: > > > > > Log: > > > > > Remove the use of cast as lvalue. > > > > This trades one style bug for another (missing space before *), breaks > > > > the build on 64-bit platforms, and violates maintainership. > > > Ah, so this commit is responsible for a cross-build breakage... > > > > No, this one currently only breaks Alpha because we apparently don't > > enforce alignment requirements on other platforms. > > > It definitely worked for amd64 world, which I guess does not have such > strict alignment requirements. Not at all -- AMD64 is an x86 platform first and fore most. That means no traps or exceptions on misalignments like for Alpha and other RISC platforms. There is of course a performance degradation on AMD64, but its the same as misalignments for x86 32-bit. -- -- David (obrien@FreeBSD.org)