From owner-freebsd-ports@FreeBSD.ORG Tue Nov 6 08:20:52 2012 Return-Path: Delivered-To: ports@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [69.147.83.52]) by hub.freebsd.org (Postfix) with ESMTP id BDE08366 for ; Tue, 6 Nov 2012 08:20:52 +0000 (UTC) (envelope-from gahr@FreeBSD.org) Received: from cpanel09.rubas.ch (cpanel09.rubas.ch [195.182.222.79]) by mx1.freebsd.org (Postfix) with ESMTP id 68CB18FC12 for ; Tue, 6 Nov 2012 08:20:52 +0000 (UTC) Received: from 175-3.192-178.cust.bluewin.ch ([178.192.3.175]:50138 helo=gahrfit.gahr.ch) by cpanel09.rubas.ch with esmtpsa (TLSv1:DHE-RSA-AES256-SHA:256) (Exim 4.80) (envelope-from ) id 1TVeOp-001ciK-Cr; Tue, 06 Nov 2012 09:20:44 +0100 Date: Tue, 6 Nov 2012 09:20:40 +0100 From: Pietro Cerutti To: Joseph a Nagy Jr Subject: Re: tk85 Port Maintenance Message-ID: <20121106082040.GM90275@gahrfit.gahr.ch> References: <20121031135749.GC90275@gahrfit.gahr.ch> <50913253.3060700@gmail.com> <20121031152109.GD90275@gahrfit.gahr.ch> <20121031153958.GE90275@gahrfit.gahr.ch> <50915194.6010101@gmail.com> <20121031165507.GF90275@gahrfit.gahr.ch> <509162C9.9060701@gmail.com> <20121102112131.GG90275@gahrfit.gahr.ch> <50968056.8080602@gmail.com> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="q6mBvMCt6oafMx9a" Content-Disposition: inline In-Reply-To: <50968056.8080602@gmail.com> X-PGP-Key: 0x9571F78E X-PGP-Fingerprint: 1203 92B5 3919 AF84 9B97 28D6 C0C2 6A98 9571 F78E User-Agent: Mutt/1.5.21 (2010-09-15) X-AntiAbuse: This header was added to track abuse, please include it with any abuse report X-AntiAbuse: Primary Hostname - cpanel09.rubas.ch X-AntiAbuse: Original Domain - freebsd.org X-AntiAbuse: Originator/Caller UID/GID - [47 12] / [47 12] X-AntiAbuse: Sender Address Domain - FreeBSD.org Cc: ports@freebsd.org, Chris Rees X-BeenThere: freebsd-ports@freebsd.org X-Mailman-Version: 2.1.14 Precedence: list Reply-To: gahr@FreeBSD.org List-Id: Porting software to FreeBSD List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 06 Nov 2012 08:20:52 -0000 --q6mBvMCt6oafMx9a Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On 2012-Nov-04, 08:48, Joseph a Nagy Jr wrote: > On 11/02/12 06:21, Pietro Cerutti wrote: > > On 2012-Oct-31, 12:41, Joseph a Nagy Jr wrote: > >> On 10/31/12 11:55, Pietro Cerutti wrote: > >>> On 2012-Oct-31, 11:28, Joseph a Nagy Jr wrote: > >> > >>>> New diff[0], undoing some of the earlier changes even though portlint > >>>> complains: > >>>> > >>>> portlint ~/port-maintenance/tk85/ > >>>> WARN: Makefile: unless this is a master port, COMMENT has to be set = by > >>>> "=3D", not by "?=3D". > >>> > >>> This *is* a master port, so it's ok to have COMMENT?=3D > >>> > >>>> WARN: Makefile: "LIB_DEPENDS" has to appear earlier. > >>> > >>> This should be fixed as portlint suggests. > >>> > >>>> WARN: Makefile: no port directory > >>>> /usr/ports/lang/tcl${SHORT_TK_VER}-thread found, even though it is > >>>> listed in LIB_DEPENDS. > >>> > >>> I would try and use USE_TCL instead of LIB_DEPENDS here > >>> > >>>> WARN: Makefile: LIB_DEPENDS don't specify the ABI version number .2 = in > >>>> Xft.2 unless it is really necessary. > >>> > >>> This should be fixed as portlint suggests. > >>> > >>>> 0 fatal errors and 4 warnings found. > >>>> > >>>> [0]: http://pastebin.com/apf1Y9H0 > >>> > >>> I'll have a look at it on Friday, thanks! > >>> > >>> > >> > >> Going ahead to make those changes, old pastebin link is defunct. > >> > >> New diff with all changes: > >> http://pastebin.com/iwhpXfcp > >=20 > > This won't apply, either. Could you provide a diff as dumped by svn diff > > in tk85's directory? > >=20 >=20 > Try this diff: > http://pastebin.com/9YacWnss * I won't comment on the LICENSE stuff, I don't know enough about it * XFT_DESC This is already defined in bsd.options.desc.mk. I'd say that=20 "Xft font library" is ok as a description. * LIB_DEPENDS+=3D Xft:${PORTSDIR}/x11-fonts/libXft This should really be USE_XORG+=3D xft * LIB_DEPENDS=3D tcl${SHORT_TK_VER}${THREADS_SUFFIX}:.... If you're ok to wait until I get rid of the -thread slave ports, you don't need to bother about this part of the Makefile --=20 Pietro Cerutti The FreeBSD Project gahr@FreeBSD.org PGP Public Key: http://gahr.ch/pgp --q6mBvMCt6oafMx9a Content-Type: application/pgp-signature -----BEGIN PGP SIGNATURE----- Version: GnuPG v2.0.19 (FreeBSD) iEYEARECAAYFAlCYyFcACgkQwMJqmJVx947bkACdEEOhlUytuzo6qQHcpN/oTJWh 68gAniCDxm3Kc4Go3FDKxvJqPy53nuFw =DIZI -----END PGP SIGNATURE----- --q6mBvMCt6oafMx9a--