From owner-svn-src-head@freebsd.org Sun Feb 14 15:42:25 2016 Return-Path: Delivered-To: svn-src-head@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id 0339BAA8F94; Sun, 14 Feb 2016 15:42:25 +0000 (UTC) (envelope-from s3erios@gmail.com) Received: from mail-lf0-x236.google.com (mail-lf0-x236.google.com [IPv6:2a00:1450:4010:c07::236]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (Client CN "smtp.gmail.com", Issuer "Google Internet Authority G2" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 7FFBE15E9; Sun, 14 Feb 2016 15:42:24 +0000 (UTC) (envelope-from s3erios@gmail.com) Received: by mail-lf0-x236.google.com with SMTP id l143so76217521lfe.2; Sun, 14 Feb 2016 07:42:24 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=content-type:to:subject:references:date:cc:mime-version :content-transfer-encoding:from:message-id:in-reply-to:user-agent; bh=kj52p7DxshrBfxz+ZAwyg43sTNNi6/c6j1fmPTStx+M=; b=aS2fB/2pEi/uIhbHyrNDy5DpJakCLZV+bgNhcrjyU1rY3jAK21YGQfowGhfFlwA1EY 7ZXjKE2KV4lHXtmuJ5xPGN+NuisE6AIwu06HidUnpN6eRcRHJ/ERbGRnyvdmv8Cy3Uim Vcch+khCSh9EBJVFTrGzeLkvxYmfjaiw1/SSf0SDY006k3qRmSvickT2DVhzyqrLz1Xy EnjRnWYrTcMlyTM8QuHK2+Kd+wbjIoIkT+tMVglW+L+yxT+/SqnM4tL3zU4un06YjZzt hDdLClp7uT/n2jtRdnTGW0+Ed8aM3cnJJw41GUCytQWfsGayXSJEb+GutFlEeHrvV5op 9tQg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:content-type:to:subject:references:date:cc :mime-version:content-transfer-encoding:from:message-id:in-reply-to :user-agent; bh=kj52p7DxshrBfxz+ZAwyg43sTNNi6/c6j1fmPTStx+M=; b=QYbL6GDVYWMwkbdMpL77BJAdxgxqphz0tAtaHRdU8AM6byZPVmw/nexyHkzh1/TmtC GlpZoAso+xpycq/knIS6AG/XmvT2UBlKyLz/isHWMfOjuRMagnyhvgVjvlgJfPQt/Y4Y 0APHiEvn5FTM12FJ3n8a8sqKyLuPv5yhaF9YvWalljFd0hpp7WFnBCCYMZg5D41d5CAp l5UhMc4h06kQc1akPZ53ODR+Ay8APBu/dPJt3jbVxkx7dQEzDrH72v7ivRmaLMT/hcUx tFM9Fxjjwg6ipfvOxYE1AuktvJuYZ6vu0P4E3vmuUGqi+hNkMGCRECemxEU+XOavbopi hHLg== X-Gm-Message-State: AG10YOTmCovcfFmVytkuN80kfF3pKvG2z5HSB29p7xEB4yv47MzW26hBAh4GbE5VGxOTkw== X-Received: by 10.25.15.23 with SMTP id e23mr4650430lfi.111.1455464541583; Sun, 14 Feb 2016 07:42:21 -0800 (PST) Received: from localhost (host-176-37-109-22.la.net.ua. [176.37.109.22]) by smtp.gmail.com with ESMTPSA id i1sm3054355lbs.38.2016.02.14.07.42.20 (version=TLS1 cipher=AES128-SHA bits=128/128); Sun, 14 Feb 2016 07:42:20 -0800 (PST) Content-Type: text/plain; charset=utf-8; format=flowed; delsp=yes To: "Hans Petter Selasky" , "Adrian Chadd" Subject: Re: svn commit: r295607 - head/sys/dev/usb/wlan References: <201602140716.u1E7Gaot040504@repo.freebsd.org> <56C09FB4.4000201@selasky.org> Date: Sun, 14 Feb 2016 17:42:21 +0200 Cc: "src-committers@freebsd.org" , "svn-src-all@freebsd.org" , "svn-src-head@freebsd.org" MIME-Version: 1.0 Content-Transfer-Encoding: Quoted-Printable From: "Andriy Voskoboinyk" Message-ID: In-Reply-To: <56C09FB4.4000201@selasky.org> User-Agent: Opera Mail/12.16 (FreeBSD) X-BeenThere: svn-src-head@freebsd.org X-Mailman-Version: 2.1.20 Precedence: list List-Id: SVN commit messages for the src tree for head/-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sun, 14 Feb 2016 15:42:25 -0000 Sun, 14 Feb 2016 17:39:32 +0200 =D0=B1=D1=83=D0=BB=D0=BE =D0=BD=D0=B0=D0= =BF=D0=B8=D1=81=D0=B0=D0=BD=D0=BE Hans Petter Selasky = : This does not related to pairwise keys management: static void rum_group_key_set_cb(struct rum_softc *sc, union sec_param *data, uint8_t rvp_id) { ... /* Set cipher mode. */ if (rum_modbits(sc, rvp_id < 2 ? RT2573_SEC_CSR1 : = RT2573_SEC_CSR5, mode << (rvp_id % 2 + k->wk_keyix) * RT2573_SKEY_MAX, RT2573_MODE_MASK << (rvp_id % 2 + k->wk_keyix) * = RT2573_SKEY_MAX) !=3D 0) goto print_err; ... } For group keys, k->wk_keyix is assigned in another way: static int rum_key_alloc(struct ieee80211vap *vap, struct ieee80211_key *k, ieee80211_keyix *keyix, ieee80211_keyix *rxkeyix) { ... *keyix =3D k - vap->iv_nw_keys; } ... } > On 02/14/16 16:23, Adrian Chadd wrote: >> uhm, why'd you not just file a separate pr for this? >> >> 8 keys limits how many stations it can support in hostap mode :( I'd >> rather the bitmap management code gets fixed. >> > > Hi, > > From what I can see 8 keys is the maximum due to the following shift:= > > /* Set cipher mode. */ > if (rum_modbits(sc, rvp_id < 2 ? RT2573_SEC_CSR1 : = > RT2573_SEC_CSR5, > mode << (rvp_id % 2 + k->wk_keyix) * RT2573_SKEY_MAX, > RT2573_MODE_MASK << (rvp_id % 2 + k->wk_keyix) * = > RT2573_SKEY_MAX) > !=3D 0) > goto print_err; > > > It is only about bitmanagement, but about where to actually write thos= e = > bits. Feel free to fix it. > > --HPS