From owner-svn-src-all@freebsd.org Thu Oct 13 07:29:07 2016 Return-Path: Delivered-To: svn-src-all@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id 68CAAC0F866; Thu, 13 Oct 2016 07:29:07 +0000 (UTC) (envelope-from yaneurabeya@gmail.com) Received: from mail-pf0-x241.google.com (mail-pf0-x241.google.com [IPv6:2607:f8b0:400e:c00::241]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (Client CN "smtp.gmail.com", Issuer "Google Internet Authority G2" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 34F78C8E; Thu, 13 Oct 2016 07:29:07 +0000 (UTC) (envelope-from yaneurabeya@gmail.com) Received: by mail-pf0-x241.google.com with SMTP id 128so4472277pfz.1; Thu, 13 Oct 2016 00:29:07 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=subject:mime-version:from:in-reply-to:date:cc:message-id:references :to; bh=Q9Pc48UgwyFtzRPfU8aHXLV5E9WGw/wZ9Dgy5cRYQ6A=; b=Ro8tdM9RyMP0OR/3TGHccVHZY+8FDstOAfQTjtBAQ4YaPOClg3MfagPGWso2+ywtef 9tYl1ruTs/0ROs7RVXXMDV4VmYxJbc96VZXR82vkHifHYlN84Lu2ObO6ePFUTRN0jn8x BvwFFCtS7XXyjL2CwDItk4RZbyr7YXl1CIKjZ1tAx9YeOdKqqN4iGn6JbGDwpF0c99bT hp1K2G+XEsyAWJ8Yho0QLCp/reHD5srYXxF3htRqNJWvNLjfsygiuuf9y7hC9XwQz6xL 06wsSrGkTYks3PsuVIB1S2q6VmgTBTiaMUxy3nHAe40acQn2LM4LrbIcBDXNFJv/48KQ eBYA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:subject:mime-version:from:in-reply-to:date:cc :message-id:references:to; bh=Q9Pc48UgwyFtzRPfU8aHXLV5E9WGw/wZ9Dgy5cRYQ6A=; b=bE0dhirJrOC7Pmw6ug/c4H20t9Ii1kGXo3Fpma2kBnCfm20q0uh0B5jzX5rXDDpIm0 3Gjj44KLh9gIO5Qgh6Ez/Jrr6WtbikzNhyFvd+9Ravuvzw5sq3QJEIic+pVkuWnCwmzv tRg6g52d52JgdZ6XZCt2jDDvqkcUEizpbr3yPe7e2J+wLHB3yZh4HWgoztPVP9H7Rg2A BvcBSzHXkhBmwaAGd/em6+NBdXOl4LQal38wGWhhYQ/vKTJafoCc2RyyjNGZn+XZROlz LbHLmCxfoxhyaIDVESirUABVo1jV87Nj0ypSljLiVds7tyrW+6jGwRBANLabzuI4TAcv a9aA== X-Gm-Message-State: AA6/9Rn/VcJm5vj4V3ltjilkGxyRB1yJu54kqIl6Ikyfrjs1ch1WzfA8KzM5/9we/Mq25A== X-Received: by 10.98.158.143 with SMTP id f15mr7934784pfk.133.1476343746842; Thu, 13 Oct 2016 00:29:06 -0700 (PDT) Received: from [192.168.20.12] (c-73-19-52-228.hsd1.wa.comcast.net. [73.19.52.228]) by smtp.gmail.com with ESMTPSA id j63sm16888055pfj.70.2016.10.13.00.29.05 (version=TLS1 cipher=ECDHE-RSA-AES128-SHA bits=128/128); Thu, 13 Oct 2016 00:29:06 -0700 (PDT) Subject: Re: svn commit: r307190 - head/contrib/netbsd-tests/fs/tmpfs Mime-Version: 1.0 (Mac OS X Mail 9.3 \(3124\)) Content-Type: multipart/signed; boundary="Apple-Mail=_A0114B37-B420-4886-AA83-5E15D9B6FAB4"; protocol="application/pgp-signature"; micalg=pgp-sha512 X-Pgp-Agent: GPGMail From: "Ngie Cooper (yaneurabeya)" In-Reply-To: Date: Thu, 13 Oct 2016 00:29:04 -0700 Cc: Ngie Cooper , src-committers@freebsd.org, svn-src-all@freebsd.org, svn-src-head@freebsd.org Message-Id: References: <201610130702.u9D72sgd007580@repo.freebsd.org> To: Julio Merino X-Mailer: Apple Mail (2.3124) X-BeenThere: svn-src-all@freebsd.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: "SVN commit messages for the entire src tree \(except for " user" and " projects" \)" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 13 Oct 2016 07:29:07 -0000 --Apple-Mail=_A0114B37-B420-4886-AA83-5E15D9B6FAB4 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset=utf-8 > On Oct 13, 2016, at 00:20, Julio Merino wrote: >=20 > On Thu, Oct 13, 2016 at 3:02 AM, Ngie Cooper wrote: > Author: ngie > Date: Thu Oct 13 07:02:54 2016 > New Revision: 307190 > URL: https://svnweb.freebsd.org/changeset/base/307190 >=20 > Log: > Skip :uchg on FreeBSD >=20 > Unfortunately removing files with uchg set always succeeds with root = on > FreeBSD. Unfortunately running the test as an unprivileged user = isn't doable > because mounting tmpfs requires root >=20 > PR: 212861 > Sponsored by: Dell EMC Isilon >=20 > Modified: > head/contrib/netbsd-tests/fs/tmpfs/t_remove.sh >=20 > Modified: head/contrib/netbsd-tests/fs/tmpfs/t_remove.sh > = =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D > --- head/contrib/netbsd-tests/fs/tmpfs/t_remove.sh Thu Oct 13 = 06:56:23 2016 (r307189) > +++ head/contrib/netbsd-tests/fs/tmpfs/t_remove.sh Thu Oct 13 = 07:02:54 2016 (r307190) > @@ -53,6 +53,10 @@ uchg_head() { > atf_set "require.user" "root" > } > uchg_body() { > + # Begin FreeBSD > + atf_skip "this fails on FreeBSD with root - bug 212861" > + # End FreeBSD >=20 > This is a bad way of disabling a test due to a known bug because, when = the bug is resolved, the test won't notice. You should be using the = "expected failures" functionality if possible, and based on the change = description, I think you can do this here easily. Try: >=20 > atf_expect_fail "FreeBSD bug 213861 blah blah" >=20 > right before the line that triggers the test failure. The problem is that this leaves tmpfs mounts lying around, which atf = won=E2=80=99t cleanup. Otherwise, I would totally agree with you. Thanks, -Ngie --Apple-Mail=_A0114B37-B420-4886-AA83-5E15D9B6FAB4 Content-Transfer-Encoding: 7bit Content-Disposition: attachment; filename=signature.asc Content-Type: application/pgp-signature; name=signature.asc Content-Description: Message signed with OpenPGP using GPGMail -----BEGIN PGP SIGNATURE----- Comment: GPGTools - https://gpgtools.org iQIcBAEBCgAGBQJX/zfBAAoJEPWDqSZpMIYVs64P/0JR4ZNY5nhp66HcTDMWrc+y QK5SSjmLK1AGcguGs54Yt6RWR12zEozYaC6Aq8AojvEAe4oE6wCpUqeFSTChlZ6a NWS2gsZ658+MVyOeyQp2CnryeTWF9/QmUnEi7Z6YtDwLHfOauqzgihwsIkZ2zR47 WCqTuyXX5u/aQqWvmflFc02u6mfkeDDylFbcHEtSJJgoSqpc5VjKrB5WMg8rWw+r FgbK/jRgxmEW5dR+6lVsgVaeSNtTs5nju7QHFEwwwK4FNaAsXb0z4RcSi2ZKwl0R G/a/XhOn6WyuJyBgFWJLh6PRtfv5a2ZphO7NDC4Rwmb3N/ee1hHuJ726GPrKcmdm uniRWHOBgvGPnD78SVyA/z0L4WE7HmqXXxofxz25pNccpzIzAhCQnuEHiPa3FdHg en7r50w6pTEtctlRBWP7vv+7yOdvBtCHoIz2YGJxckF2V/Y6G9rHTeDFYZMLvhim UdXfGHUJfIvRCqMKpjC8OHGPco80mDPwB/prO0uyHdis/u70Wc6I58JD8KDd7t75 VyM8sHtwPEa7i92hWLAsKI/0kiYUd62TiWHi51rjnGyvr84vRAQvRY2VbwHNxfzI 9RbP2rcewIDnwqm2ly9KAqjDEIBa3NekdwRzIMnUOCoJCITO1GYhkGY8MB2dHdB3 fR2x+WzDUl1X3eF6wfFv =lAg2 -----END PGP SIGNATURE----- --Apple-Mail=_A0114B37-B420-4886-AA83-5E15D9B6FAB4--